From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DE50C282CB for ; Tue, 5 Feb 2019 13:19:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 076622175B for ; Tue, 5 Feb 2019 13:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729450AbfBENTF (ORCPT ); Tue, 5 Feb 2019 08:19:05 -0500 Received: from verein.lst.de ([213.95.11.211]:54212 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729424AbfBENTF (ORCPT ); Tue, 5 Feb 2019 08:19:05 -0500 Received: by newverein.lst.de (Postfix, from userid 2005) id CE54468D93; Tue, 5 Feb 2019 14:19:02 +0100 (CET) Date: Tue, 5 Feb 2019 14:19:02 +0100 From: Torsten Duwe To: Vasily Khoruzhick Cc: Icenowy Zheng , devicetree , Archit Taneja , Andrzej Hajda , David Airlie , linux-kernel , dri-devel , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Laurent Pinchart , Daniel Vetter , Mark Rutland , Thierry Reding , Sean Paul , arm-linux Subject: Re: [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support Message-ID: <20190205131902.GA7432@lst.de> References: <20181018073327.64942-1-icenowy@aosc.io> <20190204122250.GB7660@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190203185501.8958-6-anarsoul@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First thing that struck me is that the chip's reset is actually low active reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */ ^^^^ (please correct this in patches 11 and 12) Consequently, you're using inverted values here in the driver: > +static void anx6345_poweron(struct anx6345 *anx6345) > +{ [...] > + gpiod_set_value_cansleep(pdata->gpiod_reset, 0); 0 = reset on, ok. > + usleep_range(1000, 2000); > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); 1 = reset off, also fine. > + > + /* Power on registers module */ > + anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_HDCP_PD | SP_AUDIO_PD | SP_VIDEO_PD | SP_LINK_PD); > + anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_REGISTER_PD | SP_TOTAL_PD); > + > + anx6345->powered = true; > +} > + > +static void anx6345_poweroff(struct anx6345 *anx6345) > +{ > + struct anx6345_platform_data *pdata = &anx6345->pdata; > + int err; > + > + if (WARN_ON(!anx6345->powered)) > + return; > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); > + usleep_range(1000, 2000); This one got me a bit confused. Assert or deassert reset (again) before poweroff? Please stick to the logical value of the reset line. Torsten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371BEC282CB for ; Tue, 5 Feb 2019 13:19:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04D71206DD for ; Tue, 5 Feb 2019 13:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ClYu84oF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04D71206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LjGMRW+hRa1GcIJUwoiepNAj+TLjyzcGelGT8DPxuO4=; b=ClYu84oFvCAqro mh4ml062CyDCCYz3Eymd8h/PEXXHcDsNDrZJpWyzF1sCZDNu2QlMh3PNBkURECI7s+6BnzHjhpBFU Zh+Vz5+XzdBy59zv77yQhQyPvZW5/5DYrsrb+4+kU//F0+nj2iE7OikqAEMKZ3ObgMcs3vtvsFjyb IJ8IAB6oF6FlH3iqDT3XhT9CCZO25Xy9JDIa4SL596lRxhawGvNZevvEMR6gCxoU79bMyngQDmtr3 jFiwAzh1CSEpk8BrL1ZuIZKaR/Pi3H/PFCEmm9wb244nGVNcpXr/dz16/r05AQG110jTUbT/D+iB5 xUwIbmJUB4Y6sX/s8iGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr0d8-0003xb-4A; Tue, 05 Feb 2019 13:19:14 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr0d2-0003mH-6n for linux-arm-kernel@lists.infradead.org; Tue, 05 Feb 2019 13:19:12 +0000 Received: by newverein.lst.de (Postfix, from userid 2005) id CE54468D93; Tue, 5 Feb 2019 14:19:02 +0100 (CET) Date: Tue, 5 Feb 2019 14:19:02 +0100 From: Torsten Duwe To: Vasily Khoruzhick Subject: Re: [PATCH RESEND v2 05/12] drm/bridge: Add Analogix anx6345 support Message-ID: <20190205131902.GA7432@lst.de> References: <20181018073327.64942-1-icenowy@aosc.io> <20190204122250.GB7660@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190203185501.8958-6-anarsoul@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190205_051909_203141_D1C627B4 X-CRM114-Status: UNSURE ( 9.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Archit Taneja , David Airlie , linux-kernel , dri-devel , Andrzej Hajda , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Daniel Vetter , Maxime Ripard , Sean Paul , arm-linux , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org First thing that struck me is that the chip's reset is actually low active reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 */ ^^^^ (please correct this in patches 11 and 12) Consequently, you're using inverted values here in the driver: > +static void anx6345_poweron(struct anx6345 *anx6345) > +{ [...] > + gpiod_set_value_cansleep(pdata->gpiod_reset, 0); 0 = reset on, ok. > + usleep_range(1000, 2000); > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); 1 = reset off, also fine. > + > + /* Power on registers module */ > + anx6345_set_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_HDCP_PD | SP_AUDIO_PD | SP_VIDEO_PD | SP_LINK_PD); > + anx6345_clear_bits(anx6345->map[I2C_IDX_TXCOM], SP_POWERDOWN_CTRL_REG, > + SP_REGISTER_PD | SP_TOTAL_PD); > + > + anx6345->powered = true; > +} > + > +static void anx6345_poweroff(struct anx6345 *anx6345) > +{ > + struct anx6345_platform_data *pdata = &anx6345->pdata; > + int err; > + > + if (WARN_ON(!anx6345->powered)) > + return; > + > + gpiod_set_value_cansleep(pdata->gpiod_reset, 1); > + usleep_range(1000, 2000); This one got me a bit confused. Assert or deassert reset (again) before poweroff? Please stick to the logical value of the reset line. Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel