From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F7BC282CC for ; Tue, 5 Feb 2019 18:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49645217FA for ; Tue, 5 Feb 2019 18:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729128AbfBESZU (ORCPT ); Tue, 5 Feb 2019 13:25:20 -0500 Received: from verein.lst.de ([213.95.11.211]:55584 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728020AbfBESZU (ORCPT ); Tue, 5 Feb 2019 13:25:20 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 6D4AB68D93; Tue, 5 Feb 2019 19:25:18 +0100 (CET) Date: Tue, 5 Feb 2019 19:25:18 +0100 From: Christoph Hellwig To: Carlos Maiolino Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, adilger@dilger.ca, sandeen@redhat.com, david@fromorbit.com Subject: Re: [PATCH 09/10 V2] Use FIEMAP for FIBMAP calls Message-ID: <20190205182518.GB3302@lst.de> References: <20181205091728.29903-1-cmaiolino@redhat.com> <20181205091728.29903-10-cmaiolino@redhat.com> <20190114165617.GG7187@lst.de> <20190205095601.drsskdfzbpul2zh2@hades.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190205095601.drsskdfzbpul2zh2@hades.usersys.redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 05, 2019 at 10:56:01AM +0100, Carlos Maiolino wrote: > > Any reason this function isn't in inode.c next to the caller and marked > > static? > > > > No reason other than to keep it close to its peer fiemap_fill_user_extent(), I > honestly do prefer to keep both together than in separated files. But, I'm up > to move it to fs/inode.c if required. After your series fiemap_fill_user_extent should be static and close to it's caller, so with the kernel one in inode.c everything should be neat and symmetric.