From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, roberto.sassu@huawei.com,
zohar@linux.ibm.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon
Date: Tue, 5 Feb 2019 22:59:55 +0200 [thread overview]
Message-ID: <20190205205955.GC13023@linux.intel.com> (raw)
In-Reply-To: <1549395622.2923.14.camel@HansenPartnership.com>
On Tue, Feb 05, 2019 at 02:40:22PM -0500, James Bottomley wrote:
> On Mon, 2019-02-04 at 15:37 +0200, Jarkko Sakkinen wrote:
> > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c
> > b/drivers/char/tpm/tpm_i2c_infineon.c
> > index 9086edc9066b..b9d5a1dda8d2 100644
> > --- a/drivers/char/tpm/tpm_i2c_infineon.c
> > +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> [...]
> > @@ -527,8 +528,8 @@ static int tpm_tis_i2c_send(struct tpm_chip
> > *chip, u8 *buf, size_t len)
> > u8 retries = 0;
> > u8 sts = TPM_STS_GO;
> >
> > - if (len > TPM_BUFSIZE)
> > - return -E2BIG; /* command is too long for our
> > tpm, sorry */
> > + if (len > TPM_I2C_INFINEON_BUFSIZE)
>
> TPM_I2C_INFINEON_MAX_BUFSIZE, surely, otherwise it won't compile ...
> the kbuild robot just spotted this as well.
Correct, unluckily, I had unstaged diff.
/Jarkko
prev parent reply other threads:[~2019-02-05 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 13:37 [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon Jarkko Sakkinen
2019-02-04 13:49 ` Roberto Sassu
2019-02-04 23:31 ` Jarkko Sakkinen
2019-02-04 23:40 ` Jarkko Sakkinen
2019-02-05 8:08 ` Roberto Sassu
2019-02-05 8:36 ` Jarkko Sakkinen
2019-02-05 7:42 ` kbuild test robot
2019-02-05 8:10 ` kbuild test robot
2019-02-05 19:40 ` James Bottomley
2019-02-05 20:59 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205205955.GC13023@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=stable@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.