From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27933C169C4 for ; Wed, 6 Feb 2019 18:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E089920663 for ; Wed, 6 Feb 2019 18:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726747AbfBFSjQ (ORCPT ); Wed, 6 Feb 2019 13:39:16 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33678 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbfBFSjQ (ORCPT ); Wed, 6 Feb 2019 13:39:16 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0A80413FDE79F; Wed, 6 Feb 2019 10:39:14 -0800 (PST) Date: Wed, 06 Feb 2019 10:39:11 -0800 (PST) Message-Id: <20190206.103911.39041593306699812.davem@davemloft.net> To: pablo@netfilter.org Cc: netdev@vger.kernel.org, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com, marcelo.leitner@gmail.com, mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com, julia.lawall@lip6.fr, john.fastabend@gmail.com, netfilter-devel@vger.kernel.org, cphealy@gmail.com Subject: Re: [PATCH 00/12 net-next,v7] add flow_rule infrastructure From: David Miller In-Reply-To: <20190202115054.4880-1-pablo@netfilter.org> References: <20190202115054.4880-1-pablo@netfilter.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Feb 2019 10:39:15 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Pablo Neira Ayuso Date: Sat, 2 Feb 2019 12:50:42 +0100 > This patchset, as is, allows us to reuse the driver codebase to > configure ACL hardware offloads for the ethtool_rxnfc and the TC flower > interfaces. A few clients for this infrastructure are presented, such as > the bcm_sf2 and the qede drivers, for reference. Moreover all of the > existing drivers in the tree are converted to use this infrastructure. > > This patchset is re-using the existing flow dissector infrastructure > that was introduced by Jiri Pirko et al. so the amount of abstractions > that this patchset adds are minimal. Well, just a few wrapper structures > for the selector side of the rules. And, in order to express actions, > this patchset exposes an action API that is based on the existing TC > action infrastructure and what existing drivers already support on that > front. > > v7: This patchset is a rebase on top of the net-next tree, after > addressing questions and feedback from driver developers in the > last batch. Ok, I've thought long and hard about this. Applied to net-next, let's see where this goes. I'll push this out after my build testing completes. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 00/12 net-next,v7] add flow_rule infrastructure Date: Wed, 06 Feb 2019 10:39:11 -0800 (PST) Message-ID: <20190206.103911.39041593306699812.davem@davemloft.net> References: <20190202115054.4880-1-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com, marcelo.leitner@gmail.com, mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com, julia.lawall@lip6.fr, john.fastabend@gmail.com, netfilter-devel@vger.kernel.org, cphealy@gmail To: pablo@netfilter.org Return-path: In-Reply-To: <20190202115054.4880-1-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org From: Pablo Neira Ayuso Date: Sat, 2 Feb 2019 12:50:42 +0100 > This patchset, as is, allows us to reuse the driver codebase to > configure ACL hardware offloads for the ethtool_rxnfc and the TC flower > interfaces. A few clients for this infrastructure are presented, such as > the bcm_sf2 and the qede drivers, for reference. Moreover all of the > existing drivers in the tree are converted to use this infrastructure. > > This patchset is re-using the existing flow dissector infrastructure > that was introduced by Jiri Pirko et al. so the amount of abstractions > that this patchset adds are minimal. Well, just a few wrapper structures > for the selector side of the rules. And, in order to express actions, > this patchset exposes an action API that is based on the existing TC > action infrastructure and what existing drivers already support on that > front. > > v7: This patchset is a rebase on top of the net-next tree, after > addressing questions and feedback from driver developers in the > last batch. Ok, I've thought long and hard about this. Applied to net-next, let's see where this goes. I'll push this out after my build testing completes. Thanks!