From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: netdev@vger.kernel.org, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/2] tools/bpf: add const qualifier to btf__get_map_kv_tids() map_name parameter
Date: Tue, 5 Feb 2019 18:27:06 -0800 [thread overview]
Message-ID: <20190206022704.eu5dh6a5fxzzxy3i@ast-mbp> (raw)
In-Reply-To: <20190205194822.1804874-1-yhs@fb.com>
On Tue, Feb 05, 2019 at 11:48:22AM -0800, Yonghong Song wrote:
> Commit 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
> added the API function btf__get_map_kv_tids():
> btf__get_map_kv_tids(const struct btf *btf, char *map_name, ...)
>
> The parameter map_name has type "char *". This is okay inside libbpf library since
> the map_name is from bpf_map->name which also has type "char *".
>
> This will be problematic if the caller for map_name already has attribute "const",
> e.g., from C++ string.c_str(). It will result in either a warning or an error.
>
> /home/yhs/work/bcc/src/cc/btf.cc:166:51:
> error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]
> return btf__get_map_kv_tids(btf_, map_name.c_str()
>
> This patch added "const" attributes to map_name parameter.
>
> Fixes: 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
> Signed-off-by: Yonghong Song <yhs@fb.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2019-02-06 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 19:48 [PATCH bpf-next 0/2] tools/bpf: two changes in libbpf Yonghong Song
2019-02-05 19:48 ` [PATCH bpf-next 1/2] tools/bpf: add const qualifier to btf__get_map_kv_tids() map_name parameter Yonghong Song
2019-02-06 2:27 ` Alexei Starovoitov [this message]
2019-02-06 2:41 ` Alexei Starovoitov
2019-02-05 19:48 ` [PATCH bpf-next 2/2] tools/bpf: add log_level to bpf_load_program_attr Yonghong Song
2019-02-06 2:26 ` Alexei Starovoitov
2019-02-06 5:51 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206022704.eu5dh6a5fxzzxy3i@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.