From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3 2/3] drm/i915: Refactor icl_is_hdr_plane
Date: Wed, 6 Feb 2019 14:42:21 +0200
Message-ID: <20190206124221.GA20097@intel.com>
References: <1549423762-18302-1-git-send-email-kevin.strasser@intel.com>
 <1549423762-18302-3-git-send-email-kevin.strasser@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <1549423762-18302-3-git-send-email-kevin.strasser@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Kevin Strasser <kevin.strasser@intel.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBGZWIgMDUsIDIwMTkgYXQgMDc6Mjk6MjFQTSAtMDgwMCwgS2V2aW4gU3RyYXNzZXIg
d3JvdGU6Cj4gQ2hhbmdlIHRoZSBhcGkgaW4gb3JkZXIgdG8gZW5hYmxlIGNhbGxlcnMgdGhhdCBj
YW4ndCBzdXBwbHkgYSB2YWxpZAo+IGludGVsX3BsYW5lIHBvaW50ZXIsIGFzIHdvdWxkIGJlIHRo
ZSBjYXNlIHByaW9yIHRvIGNhbGxpbmcKPiBkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQuCj4gCj4g
Q2M6IFVtYSBTaGFua2FyIDx1bWEuc2hhbmthckBpbnRlbC5jb20+Cj4gQ2M6IFNoYXNoYW5rIFNo
YXJtYSA8c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2
aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVk
QGxpbnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+
IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTogS2V2
aW4gU3RyYXNzZXIgPGtldmluLnN0cmFzc2VyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljLmMgIHwgNCArKystCj4gIGRyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2Rpc3BsYXkuYyB8IDUgKysrLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZHJ2LmggICAgIHwgNyArKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nw
cml0ZS5jICB8IDYgKysrLS0tCj4gIDQgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwg
OSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfYXRvbWljLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+IGluZGV4
IDE2MjYzYWQuLjdmODI0ZmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfYXRvbWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+
IEBAIC0yMTAsNiArMjEwLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfYXRvbWljX3NldHVwX3NjYWxl
cihzdHJ1Y3QgaW50ZWxfY3J0Y19zY2FsZXJfc3RhdGUgKnNjYWxlcl9zdGEKPiAgCQkJCSAgICAg
IGludCAqc2NhbGVyX2lkKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYgPSB0b19pOTE1KGludGVsX2NydGMtPmJhc2UuZGV2KTsKPiArCXN0cnVjdCBpbnRlbF9wbGFu
ZSAqaW50ZWxfcGxhbmU7CgpzL2ludGVsX3BsYW5lL3BsYW5lLyBoZXJlIHBsZWFzZS4gSSdtIHRy
eWluZyB0byBtYWtlIG91ciB2YXJpYWJsZQpuYW1pbmcgdG8gYmUgbW9yZSBjb25zaXN0ZW50LiBT
dGlsbCB3YXlzIHRvIGdvIGFzIHdlIGNhbiBzZWUgZnJvbQp0aGUgbGF0ZXIgaHVua3MsIGJ1dCBh
dCBsZWFzdCBuZXcgY29kZSBzaG91bGQgdXNlIGNvbnNpc3RlbnQgbmFtZXMuCgpBbHNvIHRoZSBk
ZWNsYXJhdGlvbiBjYW4gYmUgbW92ZWQgaW50byB0aGUgaWYgYmxvY2sgaXRzZWxmLgoKPiAgCWlu
dCBqOwo+ICAJdTMyIG1vZGU7Cj4gIAo+IEBAIC0yMzIsMTAgKzIzMywxMSBAQCBzdGF0aWMgdm9p
ZCBpbnRlbF9hdG9taWNfc2V0dXBfc2NhbGVyKHN0cnVjdCBpbnRlbF9jcnRjX3NjYWxlcl9zdGF0
ZSAqc2NhbGVyX3N0YQo+ICAJaWYgKHBsYW5lX3N0YXRlICYmIHBsYW5lX3N0YXRlLT5iYXNlLmZi
ICYmCj4gIAkgICAgcGxhbmVfc3RhdGUtPmJhc2UuZmItPmZvcm1hdC0+aXNfeXV2ICYmCj4gIAkg
ICAgcGxhbmVfc3RhdGUtPmJhc2UuZmItPmZvcm1hdC0+bnVtX3BsYW5lcyA+IDEpIHsKPiArCQlp
bnRlbF9wbGFuZSA9IHRvX2ludGVsX3BsYW5lKHBsYW5lX3N0YXRlLT5iYXNlLnBsYW5lKTsKPiAg
CQlpZiAoSVNfR0VOKGRldl9wcml2LCA5KSAmJgo+ICAJCSAgICAhSVNfR0VNSU5JTEFLRShkZXZf
cHJpdikpIHsKPiAgCQkJbW9kZSA9IFNLTF9QU19TQ0FMRVJfTU9ERV9OVjEyOwo+IC0JCX0gZWxz
ZSBpZiAoaWNsX2lzX2hkcl9wbGFuZSh0b19pbnRlbF9wbGFuZShwbGFuZV9zdGF0ZS0+YmFzZS5w
bGFuZSkpKSB7Cj4gKwkJfSBlbHNlIGlmIChpY2xfaXNfaGRyX3BsYW5lKGRldl9wcml2LCBpbnRl
bF9wbGFuZS0+aWQpKSB7Cj4gIAkJCS8qCj4gIAkJCSAqIE9uIGdlbjExKydzIEhEUiBwbGFuZXMg
d2Ugb25seSB1c2UgdGhlIHNjYWxlciBmb3IKPiAgCQkJICogc2NhbGluZy4gVGhleSBoYXZlIGEg
ZGVkaWNhdGVkIGNocm9tYSB1cHNhbXBsZXIsIHNvCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp
c3BsYXkuYwo+IGluZGV4IDRkNWVjOTIuLjJkOTYzOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZGlzcGxheS5jCj4gQEAgLTM3MjYsNyArMzcyNiw3IEBAIHUzMiBnbGtfcGxhbmVfY29s
b3JfY3RsKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJcGxh
bmVfY29sb3JfY3RsIHw9IFBMQU5FX0NPTE9SX1BMQU5FX0dBTU1BX0RJU0FCTEU7Cj4gIAlwbGFu
ZV9jb2xvcl9jdGwgfD0gZ2xrX3BsYW5lX2NvbG9yX2N0bF9hbHBoYShwbGFuZV9zdGF0ZSk7Cj4g
IAo+IC0JaWYgKGZiLT5mb3JtYXQtPmlzX3l1diAmJiAhaWNsX2lzX2hkcl9wbGFuZShwbGFuZSkp
IHsKPiArCWlmIChmYi0+Zm9ybWF0LT5pc195dXYgJiYgIWljbF9pc19oZHJfcGxhbmUoZGV2X3By
aXYsIHBsYW5lLT5pZCkpIHsKPiAgCQlpZiAocGxhbmVfc3RhdGUtPmJhc2UuY29sb3JfZW5jb2Rp
bmcgPT0gRFJNX0NPTE9SX1lDQkNSX0JUNzA5KQo+ICAJCQlwbGFuZV9jb2xvcl9jdGwgfD0gUExB
TkVfQ09MT1JfQ1NDX01PREVfWVVWNzA5X1RPX1JHQjcwOTsKPiAgCQllbHNlCj4gQEAgLTUwNTIs
MTMgKzUwNTIsMTQgQEAgc3RhdGljIGludCBza2xfdXBkYXRlX3NjYWxlcl9wbGFuZShzdHJ1Y3Qg
aW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgewo+ICAJc3RydWN0IGludGVsX3BsYW5l
ICppbnRlbF9wbGFuZSA9Cj4gIAkJdG9faW50ZWxfcGxhbmUocGxhbmVfc3RhdGUtPmJhc2UucGxh
bmUpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShpbnRl
bF9wbGFuZS0+YmFzZS5kZXYpOwo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwbGFu
ZV9zdGF0ZS0+YmFzZS5mYjsKPiAgCWludCByZXQ7Cj4gIAlib29sIGZvcmNlX2RldGFjaCA9ICFm
YiB8fCAhcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZTsKPiAgCWJvb2wgbmVlZF9zY2FsZXIgPSBm
YWxzZTsKPiAgCj4gIAkvKiBQcmUtZ2VuMTEgYW5kIFNEUiBwbGFuZXMgYWx3YXlzIG5lZWQgYSBz
Y2FsZXIgZm9yIHBsYW5hciBmb3JtYXRzLiAqLwo+IC0JaWYgKCFpY2xfaXNfaGRyX3BsYW5lKGlu
dGVsX3BsYW5lKSAmJgo+ICsJaWYgKCFpY2xfaXNfaGRyX3BsYW5lKGRldl9wcml2LCBpbnRlbF9w
bGFuZS0+aWQpICYmCj4gIAkgICAgZmIgJiYgZmItPmZvcm1hdC0+Zm9ybWF0ID09IERSTV9GT1JN
QVRfTlYxMikKPiAgCQluZWVkX3NjYWxlciA9IHRydWU7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rydi5oCj4gaW5kZXggOTBiYTU0My4uMTU0OTAxZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rydi5oCj4gQEAgLTIzMTMsMTIgKzIzMTMsMTMgQEAgc3RhdGljIGlubGluZSBib29sIGljbF9p
c19udjEyX3lfcGxhbmUoZW51bSBwbGFuZV9pZCBpZCkKPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+
ICAKPiAtc3RhdGljIGlubGluZSBib29sIGljbF9pc19oZHJfcGxhbmUoc3RydWN0IGludGVsX3Bs
YW5lICpwbGFuZSkKPiArc3RhdGljIGlubGluZSBib29sIGljbF9pc19oZHJfcGxhbmUoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJICAgIGVudW0gcGxhbmVfaWQgaWQp
CgpzL2lkL3BsYW5lX2lkLyBwbGVhc2UuIEFnYWluLCBnb2luZyBmb3IgY29uc2lzdGVuY3kuCgpX
aXRoIHRob3NlIHRoaXMgaXMKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly
amFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICB7Cj4gLQlpZiAoSU5URUxfR0VOKHRvX2k5MTUocGxh
bmUtPmJhc2UuZGV2KSkgPCAxMSkKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgMTEpCj4g
IAkJcmV0dXJuIGZhbHNlOwo+ICAKPiAtCXJldHVybiBwbGFuZS0+aWQgPCBQTEFORV9TUFJJVEUy
Owo+ICsJcmV0dXJuIGlkIDwgUExBTkVfU1BSSVRFMjsKPiAgfQo+ICAKPiAgLyogaW50ZWxfdHYu
YyAqLwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gaW5kZXggY2Q0MmU4MS4uMTBi
MzdlOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4gQEAgLTMzNiw3ICsz
MzYsNyBAQCBza2xfcHJvZ3JhbV9zY2FsZXIoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiAg
Cj4gIAkvKiBUT0RPOiBoYW5kbGUgc3ViLXBpeGVsIGNvb3JkaW5hdGVzICovCj4gIAlpZiAocGxh
bmVfc3RhdGUtPmJhc2UuZmItPmZvcm1hdC0+Zm9ybWF0ID09IERSTV9GT1JNQVRfTlYxMiAmJgo+
IC0JICAgICFpY2xfaXNfaGRyX3BsYW5lKHBsYW5lKSkgewo+ICsJICAgICFpY2xfaXNfaGRyX3Bs
YW5lKGRldl9wcml2LCBwbGFuZS0+aWQpKSB7Cj4gIAkJeV9ocGhhc2UgPSBza2xfc2NhbGVyX2Nh
bGNfcGhhc2UoMSwgaHNjYWxlLCBmYWxzZSk7Cj4gIAkJeV92cGhhc2UgPSBza2xfc2NhbGVyX2Nh
bGNfcGhhc2UoMSwgdnNjYWxlLCBmYWxzZSk7Cj4gIAo+IEBAIC01MTEsNyArNTExLDcgQEAgc2ts
X3Byb2dyYW1fcGxhbmUoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiAgCUk5MTVfV1JJVEVf
RlcoUExBTkVfQVVYX0RJU1QocGlwZSwgcGxhbmVfaWQpLAo+ICAJCSAgICAgIChwbGFuZV9zdGF0
ZS0+Y29sb3JfcGxhbmVbMV0ub2Zmc2V0IC0gc3VyZl9hZGRyKSB8IGF1eF9zdHJpZGUpOwo+ICAK
PiAtCWlmIChpY2xfaXNfaGRyX3BsYW5lKHBsYW5lKSkgewo+ICsJaWYgKGljbF9pc19oZHJfcGxh
bmUoZGV2X3ByaXYsIHBsYW5lX2lkKSkgewo+ICAJCXUzMiBjdXNfY3RsID0gMDsKPiAgCj4gIAkJ
aWYgKGxpbmtlZCkgewo+IEBAIC01MzYsNyArNTM2LDcgQEAgc2tsX3Byb2dyYW1fcGxhbmUoc3Ry
dWN0IGludGVsX3BsYW5lICpwbGFuZSwKPiAgCQlJOTE1X1dSSVRFX0ZXKFBMQU5FX0NPTE9SX0NU
TChwaXBlLCBwbGFuZV9pZCksCj4gIAkJCSAgICAgIHBsYW5lX3N0YXRlLT5jb2xvcl9jdGwpOwo+
ICAKPiAtCWlmIChmYi0+Zm9ybWF0LT5pc195dXYgJiYgaWNsX2lzX2hkcl9wbGFuZShwbGFuZSkp
Cj4gKwlpZiAoZmItPmZvcm1hdC0+aXNfeXV2ICYmIGljbF9pc19oZHJfcGxhbmUoZGV2X3ByaXYs
IHBsYW5lX2lkKSkKPiAgCQlpY2xfcHJvZ3JhbV9pbnB1dF9jc2MocGxhbmUsIGNydGNfc3RhdGUs
IHBsYW5lX3N0YXRlKTsKPiAgCj4gIAlza2xfd3JpdGVfcGxhbmVfd20ocGxhbmUsIGNydGNfc3Rh
dGUpOwo+IC0tIAo+IDIuNy40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp
c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=