From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de,
Marco Felsch <m.felsch@pengutronix.de>,
kernel@pengutronix.de, lgirdwood@gmail.com
Subject: Re: [PATCH v2 1/2] ASoC: ssm2602: switch to SPDX identifier
Date: Wed, 6 Feb 2019 17:51:05 +0100 [thread overview]
Message-ID: <20190206165105.phye4het2dywu3ez@pengutronix.de> (raw)
In-Reply-To: <20190206153244.GB17630@sirena.org.uk>
On Wed, Feb 06, 2019 at 03:32:44PM +0000, Mark Brown wrote:
> On Wed, Feb 06, 2019 at 04:29:46PM +0100, Marco Felsch wrote:
>
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > /*
> > * File: sound/soc/codecs/ssm2602.c
> > * Author: Cliff Cai <Cliff.Cai@analog.com>
>
> Please convert the entire comment to C++ style so it looks more
> intentional and is consistent with other ASoC stuff.
I don't know about how ASoC is special here, but I've seen the style
picked by Marco quite often and considered that the "usual" style.
Usually kernel code mandates C style comments and I though only the
SPDX-specifier is special.
So ASoC is different in this aspect?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-02-06 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 15:29 [PATCH v2 1/2] ASoC: ssm2602: switch to SPDX identifier Marco Felsch
2019-02-06 15:29 ` [PATCH v2 2/2] ASoC: ssm2602: Fix ADC powerup sequencing Marco Felsch
2019-02-06 15:32 ` [PATCH v2 1/2] ASoC: ssm2602: switch to SPDX identifier Mark Brown
2019-02-06 16:29 ` Marco Felsch
2019-02-06 16:51 ` Uwe Kleine-König [this message]
2019-02-06 16:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206165105.phye4het2dywu3ez@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.