From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/3] components: multiple components for a device Date: Thu, 7 Feb 2019 23:40:24 +0100 Message-ID: <20190207224024.GF23159@phenom.ffwll.local> References: <1548917996-28081-2-git-send-email-ramalingam.c@intel.com> <20190206164551.29400-1-daniel.vetter@ffwll.ch> <20190206164551.29400-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 149FB6ED2E for ; Thu, 7 Feb 2019 22:40:29 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id g4so1256610eds.4 for ; Thu, 07 Feb 2019 14:40:29 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Rafael J. Wysocki" Cc: Daniel Vetter , Intel Graphics Development , Rodrigo Vivi , Takashi Iwai , DRI Development , Jaroslav Kysela , Greg Kroah-Hartman , Russell King List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBGZWIgMDYsIDIwMTkgYXQgMTE6NTc6MDRQTSArMDEwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gKSBPbiBXZWQsIEZlYiA2LCAyMDE5IGF0IDU6NDYgUE0gRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gd3JvdGU6Cj4gPgo+ID4gQ29tcG9uZW50IGZyYW1l d29yayBpcyBleHRlbmRlZCB0byBzdXBwb3J0IG11bHRpcGxlIGNvbXBvbmVudHMgZm9yCj4gPiBh IHN0cnVjdCBkZXZpY2UuIFRoZXNlIHdpbGwgYmUgbWF0Y2hlZCB3aXRoIGRpZmZlcmVudCBtYXN0 ZXJzIGJhc2VkIG9uCj4gPiBpdHMgc3ViIGNvbXBvbmVudCB2YWx1ZS4KPiA+Cj4gPiBXZSBhcmUg aW50cm9kdWNpbmcgdGhpcywgYXMgSTkxNSBuZWVkcyB0d28gZGlmZmVyZW50IGNvbXBvbmVudHMK PiA+IHdpdGggZGlmZmVyZW50IHN1YmNvbXBvbmVudCB2YWx1ZSwgd2hpY2ggd2lsbCBiZSBtYXRj aGVkIHRvIHR3bwo+ID4gZGlmZmVyZW50IGNvbXBvbmVudCBtYXN0ZXJzKEF1ZGlvIGFuZCBIRENQ KSBiYXNlZCBvbiB0aGUgc3ViY29tcG9uZW50Cj4gPiB2YWx1ZXMuCj4gPgo+ID4gdjI6IEFkZCBk b2N1bWVuYXRpb24uCj4gPgo+ID4gdjM6IFJlYmFzZSBvbiB0b3Agb2YgdXBkYXRlZCBkb2N1bWVu YXRpb24uCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBmZndsbC5jaD4gKHYxIGNvZGUpCj4gPiBTaWduZWQtb2ZmLWJ5OiBSYW1hbGluZ2FtIEMgPHJh bWFsaW5nYW0uY0BpbnRlbC5jb20+ICh2MSBjb21taXQgbWVzc2FnZSkKPiA+IENjOiBSYW1hbGlu Z2FtIEMgPHJhbWFsaW5nYW0uY0BpbnRlbC5jb20+Cj4gPiBDYzogR3JlZyBLcm9haC1IYXJ0bWFu IDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiA+IENjOiBSdXNzZWxsIEtpbmcgPHJtaytr ZXJuZWxAYXJtLmxpbnV4Lm9yZy51az4KPiA+IENjOiBSYWZhZWwgSi4gV3lzb2NraSA8cmFmYWVs QGtlcm5lbC5vcmc+Cj4gPiBDYzogSmFyb3NsYXYgS3lzZWxhIDxwZXJleEBwZXJleC5jej4KPiA+ IENjOiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuY29tPgo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8 cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA bGludXguaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvYmFzZS9jb21wb25lbnQuYyAg fCAxNjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiA+ICBpbmNsdWRl L2xpbnV4L2NvbXBvbmVudC5oIHwgICA5ICsrLQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTI5IGlu c2VydGlvbnMoKyksIDQwIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2Jhc2UvY29tcG9uZW50LmMgYi9kcml2ZXJzL2Jhc2UvY29tcG9uZW50LmMKPiA+IGluZGV4IGYz NGQ0Yjc4NDcwOS4uNjhjY2Q1YTBkNWQ2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9iYXNlL2Nv bXBvbmVudC5jCj4gPiArKysgYi9kcml2ZXJzL2Jhc2UvY29tcG9uZW50LmMKPiA+IEBAIC00Nyw2 ICs0Nyw3IEBAIHN0cnVjdCBjb21wb25lbnQ7Cj4gPiAgc3RydWN0IGNvbXBvbmVudF9tYXRjaF9h cnJheSB7Cj4gPiAgICAgICAgIHZvaWQgKmRhdGE7Cj4gPiAgICAgICAgIGludCAoKmNvbXBhcmUp KHN0cnVjdCBkZXZpY2UgKiwgdm9pZCAqKTsKPiA+ICsgICAgICAgaW50ICgqY29tcGFyZV90eXBl ZCkoc3RydWN0IGRldmljZSAqLCBpbnQsIHZvaWQgKik7Cj4gPiAgICAgICAgIHZvaWQgKCpyZWxl YXNlKShzdHJ1Y3QgZGV2aWNlICosIHZvaWQgKik7Cj4gPiAgICAgICAgIHN0cnVjdCBjb21wb25l bnQgKmNvbXBvbmVudDsKPiA+ICAgICAgICAgYm9vbCBkdXBsaWNhdGU7Cj4gPiBAQCAtNzQsNiAr NzUsNyBAQCBzdHJ1Y3QgY29tcG9uZW50IHsKPiA+ICAgICAgICAgYm9vbCBib3VuZDsKPiA+Cj4g PiAgICAgICAgIGNvbnN0IHN0cnVjdCBjb21wb25lbnRfb3BzICpvcHM7Cj4gPiArICAgICAgIGlu dCBzdWJjb21wb25lbnQ7Cj4gPiAgICAgICAgIHN0cnVjdCBkZXZpY2UgKmRldjsKPiA+ICB9Owo+ ID4KPiA+IEBAIC0xNTgsNyArMTYwLDcgQEAgc3RhdGljIHN0cnVjdCBtYXN0ZXIgKl9fbWFzdGVy X2ZpbmQoc3RydWN0IGRldmljZSAqZGV2LAo+ID4gIH0KPiA+Cj4gPiAgc3RhdGljIHN0cnVjdCBj b21wb25lbnQgKmZpbmRfY29tcG9uZW50KHN0cnVjdCBtYXN0ZXIgKm1hc3RlciwKPiA+IC0gICAg ICAgaW50ICgqY29tcGFyZSkoc3RydWN0IGRldmljZSAqLCB2b2lkICopLCB2b2lkICpjb21wYXJl X2RhdGEpCj4gPiArICAgICAgIHN0cnVjdCBjb21wb25lbnRfbWF0Y2hfYXJyYXkgKm1jKQo+ID4g IHsKPiA+ICAgICAgICAgc3RydWN0IGNvbXBvbmVudCAqYzsKPiA+Cj4gPiBAQCAtMTY2LDggKzE2 OCwxMyBAQCBzdGF0aWMgc3RydWN0IGNvbXBvbmVudCAqZmluZF9jb21wb25lbnQoc3RydWN0IG1h c3RlciAqbWFzdGVyLAo+ID4gICAgICAgICAgICAgICAgIGlmIChjLT5tYXN0ZXIgJiYgYy0+bWFz dGVyICE9IG1hc3RlcikKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4K PiA+IC0gICAgICAgICAgICAgICBpZiAoY29tcGFyZShjLT5kZXYsIGNvbXBhcmVfZGF0YSkpCj4g PiArICAgICAgICAgICAgICAgaWYgKG1jLT5jb21wYXJlX3R5cGVkKSB7Cj4gPiArICAgICAgICAg ICAgICAgICAgICAgICBpZiAobWMtPmNvbXBhcmVfdHlwZWQoYy0+ZGV2LCBjLT5zdWJjb21wb25l bnQsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWMt PmRhdGEpKQo+IAo+IFRoaXMgbGluZSBicmVhayBsb29rcyBraW5kIG9mIHdlaXJkIHRvIG1lLAo+ IAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gYzsKPiA+ICsgICAg ICAgICAgICAgICB9IGVsc2UgaWYgKG1jLT5jb21wYXJlKGMtPmRldiwgbWMtPmRhdGEpKSB7Cj4g PiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gYzsKPiA+ICsgICAgICAgICAgICAgICB9 Cj4gCj4gQWxzbywgd2h5IGRvbid0IHlvdSBkbwo+IAo+IGlmIChtYy0+Y29tcGFyZShjLT5kZXYs IG1jLT5kYXRhKSB8fCAobWMtPmNvbXBhcmVfdHlwZWQgJiYKPiAgICAgbWMtPmNvbXBhcmVfdHlw ZWQoYy0+ZGV2LCBjLT5zdWJjb21wb25lbnQsIG1jLT5kYXRhKSkpCj4gICAgICAgICByZXR1cm4g YzsKPiAKPiBUaGUgb25seSBkaWZmZXJlbmNlIGlzIHRoYXQgLT5jb21wYXJlKCkgd2lsbCBydW4g Zmlyc3QgYW5kIGlmIGl0IGZpbmRzCj4gYSBtYXRjaCwgYyB3aWxsIGJlIHJldHVybmVkIHJpZ2h0 IGF3YXkuICBEb2VzIGl0IG1hdHRlcj8KClRyaWVkIGl0LCB5ZXMgaXQgZG9lcyBtYXR0ZXI6IFdl IGhhdmUgZWl0aGVyIC0+Y29tcGFyZSBvciAtPmNvbXBhcmVfdHlwZWQsCnNvIGNhbGxpbmcgb25l IHVuY29uZGl0aW9uYWxseSBibG93cyB1cC4gQ2FuIHN0aWxsIGJlIHN0cmVhbWxpbmVkIGEgYml0 IEkKdGhpbmsuCi1EYW5pZWwKCj4gCj4gPiAgICAgICAgIH0KPiA+Cj4gPiAgICAgICAgIHJldHVy biBOVUxMOwo+ID4gQEAgLTE5Miw3ICsxOTksNyBAQCBzdGF0aWMgaW50IGZpbmRfY29tcG9uZW50 cyhzdHJ1Y3QgbWFzdGVyICptYXN0ZXIpCj4gPiAgICAgICAgICAgICAgICAgaWYgKG1hdGNoLT5j b21wYXJlW2ldLmNvbXBvbmVudCkKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVl Owo+ID4KPiA+IC0gICAgICAgICAgICAgICBjID0gZmluZF9jb21wb25lbnQobWFzdGVyLCBtYy0+ Y29tcGFyZSwgbWMtPmRhdGEpOwo+ID4gKyAgICAgICAgICAgICAgIGMgPSBmaW5kX2NvbXBvbmVu dChtYXN0ZXIsIG1jKTsKPiA+ICAgICAgICAgICAgICAgICBpZiAoIWMpIHsKPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgIHJldCA9IC1FTlhJTzsKPiA+ICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwo+ID4gQEAgLTMyNywzMCArMzM0LDEyIEBAIHN0YXRpYyBpbnQgY29tcG9uZW50X21h dGNoX3JlYWxsb2Moc3RydWN0IGRldmljZSAqZGV2LAo+ID4gICAgICAgICByZXR1cm4gMDsKPiA+ ICB9Cj4gPgo+ID4gLS8qKgo+ID4gLSAqIGNvbXBvbmVudF9tYXRjaF9hZGRfcmVsZWFzZSAtIGFk ZCBhIGNvbXBvbmVudCBtYXRjaCB3aXRoIHJlbGVhc2UgY2FsbGJhY2sKPiA+IC0gKiBAbWFzdGVy OiBkZXZpY2Ugd2l0aCB0aGUgYWdncmVnYXRlIGRyaXZlcgo+ID4gLSAqIEBtYXRjaHB0cjogcG9p bnRlciB0byB0aGUgbGlzdCBvZiBjb21wb25lbnQgbWF0Y2hlcwo+ID4gLSAqIEByZWxlYXNlOiBy ZWxlYXNlIGZ1bmN0aW9uIGZvciBAY29tcGFyZV9kYXRhCj4gPiAtICogQGNvbXBhcmU6IGNvbXBh cmUgZnVuY3Rpb24gdG8gbWF0Y2ggYWdhaW5zdCBhbGwgY29tcG9uZW50cwo+ID4gLSAqIEBjb21w YXJlX2RhdGE6IG9wYXF1ZSBwb2ludGVyIHBhc3NlZCB0byB0aGUgQGNvbXBhcmUgZnVuY3Rpb24K PiA+IC0gKgo+ID4gLSAqIFRoaXMgYWRkcyBhIG5ldyBjb21wb25lbnQgbWF0Y2ggdG8gdGhlIGxp c3Qgc3RvcmVkIGluIEBtYXRjaHB0ciwgd2hpY2ggdGhlCj4gCj4gIlRoaXMiIGFwcGVhcnMgdG8g YmUgcmVkdW5kYW50IGhlcmUgKGFuZCBpbiBzb21lIHBsYWNlcyBiZWxvdyB0b28pLgoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=