From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH v2 49/49] drm/omap: Remove panel-dpi driver
Date: Sat, 9 Feb 2019 04:27:31 +0100
Message-ID: <20190209032731.pxvddbihcgdunpjl@earth.universe>
References: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com>
 <20190111035120.20668-50-laurent.pinchart@ideasonboard.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0386669784=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 107A06E41D
 for <dri-devel@lists.freedesktop.org>; Sat,  9 Feb 2019 18:57:41 +0000 (UTC)
In-Reply-To: <20190111035120.20668-50-laurent.pinchart@ideasonboard.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org


--===============0386669784==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7h5phxslf6kpegul"
Content-Disposition: inline


--7h5phxslf6kpegul
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Jan 11, 2019 at 05:51:20AM +0200, Laurent Pinchart wrote:
> Panels are now supported through the drm_panel infrastructure, remove
> the omapdrm-specific driver.
>=20
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---

Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/gpu/drm/omapdrm/displays/Kconfig      |   6 -
>  drivers/gpu/drm/omapdrm/displays/Makefile     |   1 -
>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c  | 199 ------------------
>  .../gpu/drm/omapdrm/dss/omapdss-boot-init.c   |   1 -
>  4 files changed, 207 deletions(-)
>  delete mode 100644 drivers/gpu/drm/omapdrm/displays/panel-dpi.c
>=20
> diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/o=
mapdrm/displays/Kconfig
> index 38d066ac966e..7b0bcb494b5c 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
> @@ -22,12 +22,6 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
>  	help
>  	  Driver for a generic analog TV connector.
> =20
> -config DRM_OMAP_PANEL_DPI
> -	tristate "Generic DPI panel"
> -	depends on BACKLIGHT_CLASS_DEVICE
> -	help
> -	  Driver for generic DPI panels.
> -
>  config DRM_OMAP_PANEL_DSI_CM
>  	tristate "Generic DSI Command Mode Panel"
>  	depends on BACKLIGHT_CLASS_DEVICE
> diff --git a/drivers/gpu/drm/omapdrm/displays/Makefile b/drivers/gpu/drm/=
omapdrm/displays/Makefile
> index da1d5321ef50..1db34d4fed64 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Makefile
> +++ b/drivers/gpu/drm/omapdrm/displays/Makefile
> @@ -3,7 +3,6 @@ obj-$(CONFIG_DRM_OMAP_ENCODER_OPA362) +=3D encoder-opa362=
=2Eo
>  obj-$(CONFIG_DRM_OMAP_ENCODER_TPD12S015) +=3D encoder-tpd12s015.o
>  obj-$(CONFIG_DRM_OMAP_CONNECTOR_HDMI) +=3D connector-hdmi.o
>  obj-$(CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV) +=3D connector-analog-tv.o
> -obj-$(CONFIG_DRM_OMAP_PANEL_DPI) +=3D panel-dpi.o
>  obj-$(CONFIG_DRM_OMAP_PANEL_DSI_CM) +=3D panel-dsi-cm.o
>  obj-$(CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM) +=3D panel-sony-acx565akm.o
>  obj-$(CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02) +=3D panel-lgphilips-lb0=
35q02.o
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/d=
rm/omapdrm/displays/panel-dpi.c
> deleted file mode 100644
> index 389ae2821222..000000000000
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ /dev/null
> @@ -1,199 +0,0 @@
> -/*
> - * Generic MIPI DPI Panel Driver
> - *
> - * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
> - * Author: Tomi Valkeinen <tomi.valkeinen@ti.com>
> - *
> - * This program is free software; you can redistribute it and/or modify =
it
> - * under the terms of the GNU General Public License version 2 as publis=
hed by
> - * the Free Software Foundation.
> - */
> -
> -#include <linux/gpio/consumer.h>
> -#include <linux/module.h>
> -#include <linux/platform_device.h>
> -#include <linux/slab.h>
> -#include <linux/of.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/backlight.h>
> -
> -#include <video/of_display_timing.h>
> -
> -#include "../dss/omapdss.h"
> -
> -struct panel_drv_data {
> -	struct omap_dss_device dssdev;
> -
> -	struct videomode vm;
> -
> -	struct backlight_device *backlight;
> -
> -	struct gpio_desc *enable_gpio;
> -	struct regulator *vcc_supply;
> -};
> -
> -#define to_panel_data(p) container_of(p, struct panel_drv_data, dssdev)
> -
> -static int panel_dpi_connect(struct omap_dss_device *src,
> -			     struct omap_dss_device *dst)
> -{
> -	return 0;
> -}
> -
> -static void panel_dpi_disconnect(struct omap_dss_device *src,
> -				 struct omap_dss_device *dst)
> -{
> -}
> -
> -static void panel_dpi_enable(struct omap_dss_device *dssdev)
> -{
> -	struct panel_drv_data *ddata =3D to_panel_data(dssdev);
> -	int r;
> -
> -	r =3D regulator_enable(ddata->vcc_supply);
> -	if (r)
> -		return;
> -
> -	gpiod_set_value_cansleep(ddata->enable_gpio, 1);
> -	backlight_enable(ddata->backlight);
> -}
> -
> -static void panel_dpi_disable(struct omap_dss_device *dssdev)
> -{
> -	struct panel_drv_data *ddata =3D to_panel_data(dssdev);
> -
> -	backlight_disable(ddata->backlight);
> -
> -	gpiod_set_value_cansleep(ddata->enable_gpio, 0);
> -	regulator_disable(ddata->vcc_supply);
> -}
> -
> -static int panel_dpi_get_modes(struct omap_dss_device *dssdev,
> -			       struct drm_connector *connector)
> -{
> -	struct panel_drv_data *ddata =3D to_panel_data(dssdev);
> -
> -	return omapdss_display_get_modes(connector, &ddata->vm);
> -}
> -
> -static const struct omap_dss_device_ops panel_dpi_ops =3D {
> -	.connect	=3D panel_dpi_connect,
> -	.disconnect	=3D panel_dpi_disconnect,
> -
> -	.enable		=3D panel_dpi_enable,
> -	.disable	=3D panel_dpi_disable,
> -
> -	.get_modes	=3D panel_dpi_get_modes,
> -};
> -
> -static int panel_dpi_probe_of(struct platform_device *pdev)
> -{
> -	struct panel_drv_data *ddata =3D platform_get_drvdata(pdev);
> -	struct device_node *node =3D pdev->dev.of_node;
> -	int r;
> -	struct display_timing timing;
> -	struct gpio_desc *gpio;
> -
> -	gpio =3D devm_gpiod_get_optional(&pdev->dev, "enable", GPIOD_OUT_LOW);
> -	if (IS_ERR(gpio))
> -		return PTR_ERR(gpio);
> -
> -	ddata->enable_gpio =3D gpio;
> -
> -	/*
> -	 * Many different panels are supported by this driver and there are
> -	 * probably very different needs for their reset pins in regards to
> -	 * timing and order relative to the enable gpio. So for now it's just
> -	 * ensured that the reset line isn't active.
> -	 */
> -	gpio =3D devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);
> -	if (IS_ERR(gpio))
> -		return PTR_ERR(gpio);
> -
> -	ddata->vcc_supply =3D devm_regulator_get(&pdev->dev, "vcc");
> -	if (IS_ERR(ddata->vcc_supply))
> -		return PTR_ERR(ddata->vcc_supply);
> -
> -	ddata->backlight =3D devm_of_find_backlight(&pdev->dev);
> -
> -	if (IS_ERR(ddata->backlight))
> -		return PTR_ERR(ddata->backlight);
> -
> -	r =3D of_get_display_timing(node, "panel-timing", &timing);
> -	if (r) {
> -		dev_err(&pdev->dev, "failed to get video timing\n");
> -		return r;
> -	}
> -
> -	videomode_from_timing(&timing, &ddata->vm);
> -
> -	return 0;
> -}
> -
> -static int panel_dpi_probe(struct platform_device *pdev)
> -{
> -	struct panel_drv_data *ddata;
> -	struct omap_dss_device *dssdev;
> -	int r;
> -
> -	ddata =3D devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
> -	if (ddata =3D=3D NULL)
> -		return -ENOMEM;
> -
> -	platform_set_drvdata(pdev, ddata);
> -
> -	r =3D panel_dpi_probe_of(pdev);
> -	if (r)
> -		return r;
> -
> -	dssdev =3D &ddata->dssdev;
> -	dssdev->dev =3D &pdev->dev;
> -	dssdev->ops =3D &panel_dpi_ops;
> -	dssdev->type =3D OMAP_DISPLAY_TYPE_DPI;
> -	dssdev->display =3D true;
> -	dssdev->owner =3D THIS_MODULE;
> -	dssdev->of_ports =3D BIT(0);
> -	dssdev->ops_flags =3D OMAP_DSS_DEVICE_OP_MODES;
> -	drm_bus_flags_from_videomode(&ddata->vm, &dssdev->bus_flags);
> -
> -	omapdss_display_init(dssdev);
> -	omapdss_device_register(dssdev);
> -
> -	return 0;
> -}
> -
> -static int __exit panel_dpi_remove(struct platform_device *pdev)
> -{
> -	struct panel_drv_data *ddata =3D platform_get_drvdata(pdev);
> -	struct omap_dss_device *dssdev =3D &ddata->dssdev;
> -
> -	omapdss_device_unregister(dssdev);
> -
> -	if (omapdss_device_is_enabled(dssdev))
> -		panel_dpi_disable(dssdev);
> -
> -	return 0;
> -}
> -
> -static const struct of_device_id panel_dpi_of_match[] =3D {
> -	{ .compatible =3D "omapdss,panel-dpi", },
> -	{},
> -};
> -
> -MODULE_DEVICE_TABLE(of, panel_dpi_of_match);
> -
> -static struct platform_driver panel_dpi_driver =3D {
> -	.probe =3D panel_dpi_probe,
> -	.remove =3D __exit_p(panel_dpi_remove),
> -	.driver =3D {
> -		.name =3D "panel-dpi",
> -		.of_match_table =3D panel_dpi_of_match,
> -		.suppress_bind_attrs =3D true,
> -	},
> -};
> -
> -module_platform_driver(panel_dpi_driver);
> -
> -MODULE_AUTHOR("Tomi Valkeinen <tomi.valkeinen@ti.com>");
> -MODULE_DESCRIPTION("Generic MIPI DPI Panel Driver");
> -MODULE_LICENSE("GPL");
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c b/drivers/gp=
u/drm/omapdrm/dss/omapdss-boot-init.c
> index dfeaea639920..2b41c75ce988 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
> @@ -189,7 +189,6 @@ static const struct of_device_id omapdss_of_fixups_wh=
itelist[] __initconst =3D {
>  	{ .compatible =3D "hdmi-connector" },
>  	{ .compatible =3D "lgphilips,lb035q02" },
>  	{ .compatible =3D "nec,nl8048hl11" },
> -	{ .compatible =3D "panel-dpi" },
>  	{ .compatible =3D "panel-dsi-cm" },
>  	{ .compatible =3D "sharp,ls037v7dw01" },
>  	{ .compatible =3D "sony,acx565akm" },
> --=20
> Regards,
>=20
> Laurent Pinchart
>=20
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--7h5phxslf6kpegul
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlxeSKMACgkQ2O7X88g7
+pqylg//ao5MQJKEWZLp1y1WSOzQlG3lBvwvIfQvgV8RtGvAoCnuGqkH0Tl+93PK
QTbgTa1M9notoFQeNdiv1aer/lJOKVNA2BiOqcKlLU6pKbOHvfipALZfnMQKX7wb
yVD4P6Z0yJf2zCVsgC/Krb9Hr9EF/ON3JvuivGX4kCLEhXrHOZv+/8Mg9RHNEtQY
RE579qLu7QKwzpwTAPot1ERqpitsZTXkhj5RgBRGquu0YMgEzeVSDUBrQDnJdqw1
yxziHeZ8TxKy+e8d4ohtswq4phkbwaRj2hRBEhGzUNph+TTp/Ts+s8uS+baRAoyq
PhEQbNJU3QFgGghjsf7hurjNkRTyommNFq4PLjgwuJsV+5ezgjzYxhrvpBEBvFp7
gDMZFmrDnoQzC+j1VF9lPUnWgqMsNAaQB9K7r/VajUO10rpmB+HMLNa4D7MSXqxB
CMLhSQkE9YUz9xW8VRUqWCs2rtcEaOJ1757K5UAkcI2l2FuxHi88l+vXjXSefmrk
ci7d7XnJTyaw7IRO7BomPjUhMVGXKBnIGeoQSsfCgu8BFc++80GmQqlY84IlSoJb
jWK7GlzGI+22XS9VUNdUoH+LZXnIxjHaoQEED+nNMiPXybdm6rQD83Q9hbfnWru4
BGzYxr7A1WUUSiZvpLViEw+pOxLw3LcrbfCtv4XQ7STcGZVCWJg=
=wfQB
-----END PGP SIGNATURE-----

--7h5phxslf6kpegul--

--===============0386669784==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0386669784==--