From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65189C282C4 for ; Sat, 9 Feb 2019 15:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C5AF218D2 for ; Sat, 9 Feb 2019 15:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726943AbfBIP70 (ORCPT ); Sat, 9 Feb 2019 10:59:26 -0500 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:54104 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726894AbfBIP70 (ORCPT ); Sat, 9 Feb 2019 10:59:26 -0500 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2001:1bc8:1a6:d3d5::80:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id E160F634C7B; Sat, 9 Feb 2019 17:59:07 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.89) (envelope-from ) id 1gsV23-0000wr-Hp; Sat, 09 Feb 2019 17:59:07 +0200 Date: Sat, 9 Feb 2019 17:59:07 +0200 From: Sakari Ailus To: Frederic Chen Cc: hans.verkuil@cisco.com, laurent.pinchart+renesas@ideasonboard.com, tfiga@chromium.org, matthias.bgg@gmail.com, mchehab@kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Sean.Cheng@mediatek.com, sj.huang@mediatek.com, christie.yu@mediatek.com, holmes.chiou@mediatek.com, Jerry-ch.Chen@mediatek.com, jungo.lin@mediatek.com, Rynn.Wu@mediatek.com, linux-media@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [RFC PATCH V0 1/7] [media] dt-bindings: mt8183: Add binding for DIP shared memory Message-ID: <20190209155907.rbgwbdablndcesid@valkosipuli.retiisi.org.uk> References: <1549020091-42064-1-git-send-email-frederic.chen@mediatek.com> <1549020091-42064-2-git-send-email-frederic.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1549020091-42064-2-git-send-email-frederic.chen@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Frederic, Could you cc the devicetree list, please? On Fri, Feb 01, 2019 at 07:21:25PM +0800, Frederic Chen wrote: > This patch adds the binding for describing the shared memory > used to exchange configuration and tuning data between the > co-processor and Digital Image Processing (DIP) unit of the > camera ISP system on Mediatek SoCs. > > Signed-off-by: Frederic Chen > --- > .../mediatek,reserve-memory-dip_smem.txt | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > diff --git a/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > new file mode 100644 > index 0000000..0ded478 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > @@ -0,0 +1,45 @@ > +Mediatek DIP Shared Memory binding > + > +This binding describes the shared memory, which serves the purpose of > +describing the shared memory region used to exchange data between Digital > +Image Processing (DIP) and co-processor in Mediatek SoCs. > + > +The co-processor doesn't have the iommu so we need to use the physical > +address to access the shared buffer in the firmware. > + > +The Digital Image Processing (DIP) can access memory through mt8183 IOMMU so > +it can use dma address to access the memory region. > +(See iommu/mediatek,iommu.txt for the detailed description of Mediatek IOMMU) What kind of purpose is the memory used for? Buffers containing video data, or something else? Could the buffer objects be mapped on the devices based on the need instead? > + > + > +Required properties: > + > +- compatible: must be "mediatek,reserve-memory-dip_smem" > + > +- reg: required for static allocation (see reserved-memory.txt for > + the detailed usage) > + > +- alloc-range: required for dynamic allocation. The range must > + between 0x00000400 and 0x100000000 due to the co-processer's > + addressing limitation > + > +- size: required for dynamic allocation. The unit is bytes. > + If you want to enable the full feature of Digital Processing Unit, > + you need 20 MB at least. > + > + > +Example: > + > +The following example shows the DIP shared memory setup for MT8183. > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + reserve-memory-isp_smem { > + compatible = "mediatek,reserve-memory-dip_smem"; > + size = <0 0x1400000>; > + alignment = <0 0x1000>; > + alloc-ranges = <0 0x40000000 0 0x50000000>; > + }; > + }; -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [RFC PATCH V0 1/7] [media] dt-bindings: mt8183: Add binding for DIP shared memory Date: Sat, 9 Feb 2019 17:59:07 +0200 Message-ID: <20190209155907.rbgwbdablndcesid@valkosipuli.retiisi.org.uk> References: <1549020091-42064-1-git-send-email-frederic.chen@mediatek.com> <1549020091-42064-2-git-send-email-frederic.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1549020091-42064-2-git-send-email-frederic.chen@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Frederic Chen Cc: Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, hans.verkuil@cisco.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org Hi Frederic, Could you cc the devicetree list, please? On Fri, Feb 01, 2019 at 07:21:25PM +0800, Frederic Chen wrote: > This patch adds the binding for describing the shared memory > used to exchange configuration and tuning data between the > co-processor and Digital Image Processing (DIP) unit of the > camera ISP system on Mediatek SoCs. > > Signed-off-by: Frederic Chen > --- > .../mediatek,reserve-memory-dip_smem.txt | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > diff --git a/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > new file mode 100644 > index 0000000..0ded478 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > @@ -0,0 +1,45 @@ > +Mediatek DIP Shared Memory binding > + > +This binding describes the shared memory, which serves the purpose of > +describing the shared memory region used to exchange data between Digital > +Image Processing (DIP) and co-processor in Mediatek SoCs. > + > +The co-processor doesn't have the iommu so we need to use the physical > +address to access the shared buffer in the firmware. > + > +The Digital Image Processing (DIP) can access memory through mt8183 IOMMU so > +it can use dma address to access the memory region. > +(See iommu/mediatek,iommu.txt for the detailed description of Mediatek IOMMU) What kind of purpose is the memory used for? Buffers containing video data, or something else? Could the buffer objects be mapped on the devices based on the need instead? > + > + > +Required properties: > + > +- compatible: must be "mediatek,reserve-memory-dip_smem" > + > +- reg: required for static allocation (see reserved-memory.txt for > + the detailed usage) > + > +- alloc-range: required for dynamic allocation. The range must > + between 0x00000400 and 0x100000000 due to the co-processer's > + addressing limitation > + > +- size: required for dynamic allocation. The unit is bytes. > + If you want to enable the full feature of Digital Processing Unit, > + you need 20 MB at least. > + > + > +Example: > + > +The following example shows the DIP shared memory setup for MT8183. > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + reserve-memory-isp_smem { > + compatible = "mediatek,reserve-memory-dip_smem"; > + size = <0 0x1400000>; > + alignment = <0 0x1000>; > + alloc-ranges = <0 0x40000000 0 0x50000000>; > + }; > + }; -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C154AC282C4 for ; Sat, 9 Feb 2019 15:59:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9145D218D2 for ; Sat, 9 Feb 2019 15:59:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Nbwz09dF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9145D218D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=iki.fi Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Iv/deiusu7DF7SeScLbezTt+b3wY8r/5YuBTH8l2vc=; b=Nbwz09dFACQ7y4 6ofu+IGSRAG82BcPY3eWMs8/bE3SiucPNDcJBz2uJFwaGrFCdX7o4a12BelDfj6YkAyofeDIBP1wU hsCTPqO673u5HcNXbAuaVOb2JMBloZxgEI0N8At8s1OgMkyLGuJ3ECAAvjO378WQ/cNPNfhgcRcSk 5nN3oB+AwXItu7qxUa86d3e2pgr493oDOpUFWBSBi4ZEPAgOOidFxmw13SDJJ2gslJk/k0Q0lLS60 561kYX5QX77kd30p/fheskA5MJLKQ3JqtcBYCxOwU3TTUvStkZNr03yf3KPfu9Iz5Qxp1zQgYWrr1 5p6SNd9rUia5MBxhrBDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsV2d-0007iM-2p; Sat, 09 Feb 2019 15:59:43 +0000 Received: from hillosipuli.retiisi.org.uk ([2001:1bc8:1a6:d3d5::81:2]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsV2X-0007do-Pv; Sat, 09 Feb 2019 15:59:41 +0000 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2001:1bc8:1a6:d3d5::80:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id E160F634C7B; Sat, 9 Feb 2019 17:59:07 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.89) (envelope-from ) id 1gsV23-0000wr-Hp; Sat, 09 Feb 2019 17:59:07 +0200 Date: Sat, 9 Feb 2019 17:59:07 +0200 From: Sakari Ailus To: Frederic Chen Subject: Re: [RFC PATCH V0 1/7] [media] dt-bindings: mt8183: Add binding for DIP shared memory Message-ID: <20190209155907.rbgwbdablndcesid@valkosipuli.retiisi.org.uk> References: <1549020091-42064-1-git-send-email-frederic.chen@mediatek.com> <1549020091-42064-2-git-send-email-frederic.chen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1549020091-42064-2-git-send-email-frederic.chen@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190209_075938_220215_B21A88C0 X-CRM114-Status: GOOD ( 19.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, hans.verkuil@cisco.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frederic, Could you cc the devicetree list, please? On Fri, Feb 01, 2019 at 07:21:25PM +0800, Frederic Chen wrote: > This patch adds the binding for describing the shared memory > used to exchange configuration and tuning data between the > co-processor and Digital Image Processing (DIP) unit of the > camera ISP system on Mediatek SoCs. > > Signed-off-by: Frederic Chen > --- > .../mediatek,reserve-memory-dip_smem.txt | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > diff --git a/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > new file mode 100644 > index 0000000..0ded478 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > @@ -0,0 +1,45 @@ > +Mediatek DIP Shared Memory binding > + > +This binding describes the shared memory, which serves the purpose of > +describing the shared memory region used to exchange data between Digital > +Image Processing (DIP) and co-processor in Mediatek SoCs. > + > +The co-processor doesn't have the iommu so we need to use the physical > +address to access the shared buffer in the firmware. > + > +The Digital Image Processing (DIP) can access memory through mt8183 IOMMU so > +it can use dma address to access the memory region. > +(See iommu/mediatek,iommu.txt for the detailed description of Mediatek IOMMU) What kind of purpose is the memory used for? Buffers containing video data, or something else? Could the buffer objects be mapped on the devices based on the need instead? > + > + > +Required properties: > + > +- compatible: must be "mediatek,reserve-memory-dip_smem" > + > +- reg: required for static allocation (see reserved-memory.txt for > + the detailed usage) > + > +- alloc-range: required for dynamic allocation. The range must > + between 0x00000400 and 0x100000000 due to the co-processer's > + addressing limitation > + > +- size: required for dynamic allocation. The unit is bytes. > + If you want to enable the full feature of Digital Processing Unit, > + you need 20 MB at least. > + > + > +Example: > + > +The following example shows the DIP shared memory setup for MT8183. > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + reserve-memory-isp_smem { > + compatible = "mediatek,reserve-memory-dip_smem"; > + size = <0 0x1400000>; > + alignment = <0 0x1000>; > + alloc-ranges = <0 0x40000000 0 0x50000000>; > + }; > + }; -- Kind regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel