* [PATCH] mtd: spi-nor: Add support for mx25u3235f
@ 2019-01-30 4:11 Ding Tao
2019-02-03 11:32 ` Tudor.Ambarus
2019-02-10 18:56 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Ding Tao @ 2019-01-30 4:11 UTC (permalink / raw)
To: avalentin, hauke, marek.vasut, dwmw2, computersforpeace,
boris.brezillon, richard, Tudor.Ambarus
Cc: Ding Tao, linux-mtd
From: André Valentin <avalentin@marcant.net>
The mx25u3235f is found on the ZyXEL NBG6817 router, therefore
add driver support for it so that we can upstream board support.
Minimal tested with u-boot tools fw_printenv/fw_setenv on GlobalScale
ESPRESSObin v5 board.
[miyatsu@qq.com: Remove unnecessary white space.]
Signed-off-by: André Valentin <avalentin@marcant.net>
Signed-off-by: Ding Tao <miyatsu@qq.com>
---
drivers/mtd/spi-nor/spi-nor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 6e13bbd1aaa5..01ac2e4babaa 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1836,6 +1836,8 @@ static const struct flash_info spi_nor_ids[] = {
{ "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
{ "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
{ "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
+ { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
{ "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
{ "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
--
2.17.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add support for mx25u3235f
2019-01-30 4:11 [PATCH] mtd: spi-nor: Add support for mx25u3235f Ding Tao
@ 2019-02-03 11:32 ` Tudor.Ambarus
2019-02-10 18:56 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Tudor.Ambarus @ 2019-02-03 11:32 UTC (permalink / raw)
To: miyatsu, avalentin, hauke, marek.vasut, dwmw2, computersforpeace,
bbrezillon, richard
Cc: linux-mtd
Hi, Boris,
On 01/30/2019 06:11 AM, Ding Tao wrote:
> From: André Valentin <avalentin@marcant.net>
>
> The mx25u3235f is found on the ZyXEL NBG6817 router, therefore
> add driver support for it so that we can upstream board support.
>
> Minimal tested with u-boot tools fw_printenv/fw_setenv on GlobalScale
> ESPRESSObin v5 board.
>
> [miyatsu@qq.com: Remove unnecessary white space.]
Would you please move this line between Andre's S-o-b and Ding's?
> Signed-off-by: André Valentin <avalentin@marcant.net>
Ding,
your change should be indicated between the last Signed-off-by header and yours,
see Documentation/process/submitting-patches.rst. Your Tested-by tag could have
been here too.
> Signed-off-by: Ding Tao <miyatsu@qq.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Andre and Hauke, we will take this version of the patch, because Ding has worked
on it too.
> ---
change log was nice to have here.
Cheers,
ta
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 6e13bbd1aaa5..01ac2e4babaa 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1836,6 +1836,8 @@ static const struct flash_info spi_nor_ids[] = {
> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> { "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mtd: spi-nor: Add support for mx25u3235f
2019-01-30 4:11 [PATCH] mtd: spi-nor: Add support for mx25u3235f Ding Tao
2019-02-03 11:32 ` Tudor.Ambarus
@ 2019-02-10 18:56 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2019-02-10 18:56 UTC (permalink / raw)
To: Ding Tao, avalentin, hauke, marek.vasut, dwmw2,
computersforpeace, boris.brezillon, richard, Tudor.Ambarus
Cc: linux-mtd, Boris Brezillon
From: Boris Brezillon <bbrezillon@kernel.org>
On Wed, 2019-01-30 at 04:11:21 UTC, Ding Tao wrote:
> From: André Valentin <avalentin@marcant.net>
>
> The mx25u3235f is found on the ZyXEL NBG6817 router, therefore
> add driver support for it so that we can upstream board support.
>
> Minimal tested with u-boot tools fw_printenv/fw_setenv on GlobalScale
> ESPRESSObin v5 board.
>
> [miyatsu@qq.com: Remove unnecessary white space.]
> Signed-off-by: André Valentin <avalentin@marcant.net>
> Signed-off-by: Ding Tao <miyatsu@qq.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Applied to http://git.infradead.org/linux-mtd.git spi-nor/next, thanks.
Boris
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-10 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-30 4:11 [PATCH] mtd: spi-nor: Add support for mx25u3235f Ding Tao
2019-02-03 11:32 ` Tudor.Ambarus
2019-02-10 18:56 ` Boris Brezillon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.