All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Cc: <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: unlock unused_pages timely when doing writeback
Date: Sun, 10 Feb 2019 23:54:29 -0500	[thread overview]
Message-ID: <20190211045429.GI23000@mit.edu> (raw)
In-Reply-To: <20190129020531.1665-1-xiaoguang.wang@linux.alibaba.com>

On Tue, Jan 29, 2019 at 10:05:31AM +0800, Xiaoguang Wang wrote:
> In mpage_add_bh_to_extent(), when accumulated extents length is greater
> than MAX_WRITEPAGES_EXTENT_LEN or buffer head's b_stat is not equal, we
> will not continue to search unmapped area for this page, but note this
> page is locked, and will only be unlocked in mpage_release_unused_pages()
> after ext4_io_submit, if io also is throttled by blk-throttle or similar
> io qos, we will hold this page locked for a while, it's unnecessary.
> 
> I think the best fix is to refactor mpage_add_bh_to_extent() to let it
> return some hints whether to unlock this page, but given that we will
> improve dioread_nolock later, we can let it done later, so currently
> the simple fix would just call mpage_release_unused_pages() before
> ext4_io_submit().
> 
> Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>

Thanks, applied.

					- Ted

      reply	other threads:[~2019-02-11  4:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  2:05 [PATCH] ext4: unlock unused_pages timely when doing writeback Xiaoguang Wang
2019-02-11  4:54 ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211045429.GI23000@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=xiaoguang.wang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.