From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C41DC169C4 for ; Mon, 11 Feb 2019 08:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F56E20863 for ; Mon, 11 Feb 2019 08:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727232AbfBKIjf (ORCPT ); Mon, 11 Feb 2019 03:39:35 -0500 Received: from mga17.intel.com ([192.55.52.151]:48867 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726930AbfBKIjf (ORCPT ); Mon, 11 Feb 2019 03:39:35 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2019 00:39:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,358,1544515200"; d="scan'208";a="145815851" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 11 Feb 2019 00:39:30 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 11 Feb 2019 10:39:29 +0200 Date: Mon, 11 Feb 2019 10:39:29 +0200 From: Heikki Krogerus To: Andy Shevchenko Cc: Greg Kroah-Hartman , Chen Yu , Jun Li , Hans de Goede , USB , Linux Kernel Mailing List Subject: Re: [PATCH v2 7/9] usb: typec: Find the ports by also matching against the device node Message-ID: <20190211083929.GD16987@kuha.fi.intel.com> References: <20190130160259.46919-1-heikki.krogerus@linux.intel.com> <20190130160259.46919-8-heikki.krogerus@linux.intel.com> <20190131133537.GA13072@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131133537.GA13072@kuha.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Thu, Jan 31, 2019 at 03:35:37PM +0200, Heikki Krogerus wrote: > On Wed, Jan 30, 2019 at 06:51:56PM +0200, Andy Shevchenko wrote: > > On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus > > wrote: > > > > > > When the connections are defined in firmware, struct > > > device_connection will have the fwnode member pointing to > > > the device node (struct fwnode_handle) of the requested > > > device, and the endpoint will not be used at all in that > > > case. > > > > > + /* > > > + * FIXME: Check does the fwnode supports the requested SVID. If it does > > > + * we need to return ERR_PTR(-PROBE_DEFER) when there is no device. > > > + */ > > > + if (con->fwnode) > > > + return class_find_device(typec_class, NULL, con->fwnode, > > > + typec_port_fwnode_match); > > > + > > > + dev = class_find_device(typec_class, NULL, con->endpoint[ep], > > > + typec_port_name_match); > > > + > > > + return dev ? dev : ERR_PTR(-EPROBE_DEFER); > > > > Just to be clear, this one takes a reference on dev. Is it taken into account? > > Yes. That is what we want it to do. Gentle ping. Is the series OK? thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,7/9] usb: typec: Find the ports by also matching against the device node From: Heikki Krogerus Message-Id: <20190211083929.GD16987@kuha.fi.intel.com> Date: Mon, 11 Feb 2019 10:39:29 +0200 To: Andy Shevchenko Cc: Greg Kroah-Hartman , Chen Yu , Jun Li , Hans de Goede , USB , Linux Kernel Mailing List List-ID: SGkgQW5keSwKCk9uIFRodSwgSmFuIDMxLCAyMDE5IGF0IDAzOjM1OjM3UE0gKzAyMDAsIEhlaWtr aSBLcm9nZXJ1cyB3cm90ZToKPiBPbiBXZWQsIEphbiAzMCwgMjAxOSBhdCAwNjo1MTo1NlBNICsw MjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4gPiBPbiBXZWQsIEphbiAzMCwgMjAxOSBhdCA2 OjAzIFBNIEhlaWtraSBLcm9nZXJ1cwo+ID4gPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5j b20+IHdyb3RlOgo+ID4gPgo+ID4gPiBXaGVuIHRoZSBjb25uZWN0aW9ucyBhcmUgZGVmaW5lZCBp biBmaXJtd2FyZSwgc3RydWN0Cj4gPiA+IGRldmljZV9jb25uZWN0aW9uIHdpbGwgaGF2ZSB0aGUg Zndub2RlIG1lbWJlciBwb2ludGluZyB0bwo+ID4gPiB0aGUgZGV2aWNlIG5vZGUgKHN0cnVjdCBm d25vZGVfaGFuZGxlKSBvZiB0aGUgcmVxdWVzdGVkCj4gPiA+IGRldmljZSwgYW5kIHRoZSBlbmRw b2ludCB3aWxsIG5vdCBiZSB1c2VkIGF0IGFsbCBpbiB0aGF0Cj4gPiA+IGNhc2UuCj4gPiAKPiA+ ID4gKyAgICAgICAvKgo+ID4gPiArICAgICAgICAqIEZJWE1FOiBDaGVjayBkb2VzIHRoZSBmd25v ZGUgc3VwcG9ydHMgdGhlIHJlcXVlc3RlZCBTVklELiBJZiBpdCBkb2VzCj4gPiA+ICsgICAgICAg ICogd2UgbmVlZCB0byByZXR1cm4gRVJSX1BUUigtUFJPQkVfREVGRVIpIHdoZW4gdGhlcmUgaXMg bm8gZGV2aWNlLgo+ID4gPiArICAgICAgICAqLwo+ID4gPiArICAgICAgIGlmIChjb24tPmZ3bm9k ZSkKPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBjbGFzc19maW5kX2RldmljZSh0eXBlY19j bGFzcywgTlVMTCwgY29uLT5md25vZGUsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdHlwZWNfcG9ydF9md25vZGVfbWF0Y2gpOwo+ID4gPiArCj4gPiA+ICsg ICAgICAgZGV2ID0gY2xhc3NfZmluZF9kZXZpY2UodHlwZWNfY2xhc3MsIE5VTEwsIGNvbi0+ZW5k cG9pbnRbZXBdLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR5cGVjX3Bv cnRfbmFtZV9tYXRjaCk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICByZXR1cm4gZGV2ID8gZGV2IDog RVJSX1BUUigtRVBST0JFX0RFRkVSKTsKPiA+IAo+ID4gSnVzdCAgdG8gYmUgY2xlYXIsIHRoaXMg b25lIHRha2VzIGEgcmVmZXJlbmNlIG9uIGRldi4gSXMgaXQgdGFrZW4gaW50byBhY2NvdW50Pwo+ IAo+IFllcy4gVGhhdCBpcyB3aGF0IHdlIHdhbnQgaXQgdG8gZG8uCgpHZW50bGUgcGluZy4gSXMg dGhlIHNlcmllcyBPSz8KCnRoYW5rcywK