From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F450C169C4 for ; Mon, 11 Feb 2019 12:12:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E65F218D8 for ; Mon, 11 Feb 2019 12:12:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="knF1plx4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfBKMML (ORCPT ); Mon, 11 Feb 2019 07:12:11 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:38452 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfBKMMK (ORCPT ); Mon, 11 Feb 2019 07:12:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BPtXQOxeYch/V0X+MBJp9wTl973Cc6vheZfDDJ3vJ1M=; b=knF1plx4j7WuqTz9tOcA7myib 6p3FyKk+tbMpsSd/mVBx2nyHUziOgR2nxHufUUq8xgF+i23LnegLWIDZBDw1yID6TccRsHBgX098r wpvnaFbVc5Jx54K+xqAypmZG4OhLOuK8oESV01holg8Wu3tNMT9x/bkFZAdkNo9d9rj3TjoYx99ad bdmsboI8goqhAoKeAS4SiMw4oY0phQ/PE0ewAYxD92Jpub+1VDkRidQfYis9w8vdBuaSVSIqez5Iu PjV5o4hOtyDvZ9lFXKTqXdSyc8CDfuqmMc3OuNi0yZYqrwTEOR+TRvedM96Hx+8JavPwlOe10bzwa V9vQRBwBQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtARU-00075I-CL; Mon, 11 Feb 2019 12:12:08 +0000 Date: Mon, 11 Feb 2019 04:12:08 -0800 From: Matthew Wilcox To: Tariq Toukan Cc: Ilias Apalodimas , David Miller , "brouer@redhat.com" , "toke@redhat.com" , "netdev@vger.kernel.org" , "mgorman@techsingularity.net" , "linux-mm@kvack.org" Subject: Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t Message-ID: <20190211121208.GB12668@bombadil.infradead.org> References: <1549550196-25581-1-git-send-email-ilias.apalodimas@linaro.org> <20190207150745.GW21860@bombadil.infradead.org> <20190207152034.GA3295@apalos> <20190207.132519.1698007650891404763.davem@davemloft.net> <20190207213400.GA21860@bombadil.infradead.org> <20190207214237.GA10676@Iliass-MBP.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 11, 2019 at 08:53:19AM +0000, Tariq Toukan wrote: > It's great to use the struct page to store its dma mapping, but I am > worried about extensibility. > page_pool is evolving, and it would need several more per-page fields. > One of them would be pageref_bias, a planned optimization to reduce the > number of the costly atomic pageref operations (and replace existing > code in several drivers). There's space for five words (20 or 40 bytes on 32/64 bit).