From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D69C169C4 for ; Mon, 11 Feb 2019 15:03:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDE6D222B0 for ; Mon, 11 Feb 2019 15:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897381; bh=zClhYNYU/GZQoz5hrfZx2hEGl2NnoYrBQYgFUgjDc9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MxuU1tq0F733dpvDtZNQdRXcwd7A8M2+bcxaLeNbo8+KXD/6voBfr3mB0aWC18fea BlOi3/MHQGGe0iAhCI/kDOdYrR6zCDXZMHMztdlXI8excrgHUfA2rTkjkr9PUfTgfk dBpMlKR1cBjwkRLgZnYFAqR91TusP7quVf+kn+Ts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390522AbfBKPDA (ORCPT ); Mon, 11 Feb 2019 10:03:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:51100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390490AbfBKPCw (ORCPT ); Mon, 11 Feb 2019 10:02:52 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1001222A6; Mon, 11 Feb 2019 15:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897371; bh=zClhYNYU/GZQoz5hrfZx2hEGl2NnoYrBQYgFUgjDc9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZUtMsGbKFimVIgX+LHvGXvgIJp9aWVgh7x/JF7DNLrxsy10fj+kZbw5UbNOd9ncWL EPucSzT7J6UV0uasNwMTLiTPj9JG3qaqfIvLh3P+SQRipOKuwZi9b8XcuMuGxzY+aS rPtTza13jwDvBS9Y0yJoD5uCQBBeqTOlXJ4iZQqI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+c1e36d30ee3416289cc0@syzkaller.appspotmail.com, Miklos Szeredi Subject: [PATCH 4.14 179/205] fuse: handle zero sized retrieve correctly Date: Mon, 11 Feb 2019 15:19:37 +0100 Message-Id: <20190211141840.083778886@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Miklos Szeredi commit 97e1532ef81acb31c30f9e75bf00306c33a77812 upstream. Dereferencing req->page_descs[0] will Oops if req->max_pages is zero. Reported-by: syzbot+c1e36d30ee3416289cc0@syzkaller.appspotmail.com Tested-by: syzbot+c1e36d30ee3416289cc0@syzkaller.appspotmail.com Fixes: b2430d7567a3 ("fuse: add per-page descriptor to fuse_req") Cc: # v3.9 Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1691,7 +1691,6 @@ static int fuse_retrieve(struct fuse_con req->in.h.nodeid = outarg->nodeid; req->in.numargs = 2; req->in.argpages = 1; - req->page_descs[0].offset = offset; req->end = fuse_retrieve_end; index = outarg->offset >> PAGE_SHIFT; @@ -1706,6 +1705,7 @@ static int fuse_retrieve(struct fuse_con this_num = min_t(unsigned, num, PAGE_SIZE - offset); req->pages[req->num_pages] = page; + req->page_descs[req->num_pages].offset = offset; req->page_descs[req->num_pages].length = this_num; req->num_pages++;