From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A69BEC169C4 for ; Mon, 11 Feb 2019 15:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 799FA222B5 for ; Mon, 11 Feb 2019 15:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897455; bh=XS1UvPpMyic+D+vvOkncGgjSTFnTIeUoQJaJUKzkQ48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QpB6bvOP4DOhXb6cANpY8m9Lv7gquf3tlfXq26TMYg1Ovbegj4AafZm5gZbjRGEj0 95BFBvQ64s9WAN6BISAznSrFZ04WaIVUWY71sU9dzLH1OTOEaBbC/8xWgLhMTBq7Qs 5nVHPKbhEQhYzbk/rdRKKGp3ntZqha/sn4MQuxns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390734AbfBKPEN (ORCPT ); Mon, 11 Feb 2019 10:04:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:53086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390668AbfBKPEK (ORCPT ); Mon, 11 Feb 2019 10:04:10 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83D42222A7; Mon, 11 Feb 2019 15:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897450; bh=XS1UvPpMyic+D+vvOkncGgjSTFnTIeUoQJaJUKzkQ48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FB9yTf4zXrlsmiLYl0+fGh1H/KpWPUPkYJ7OttqieF9VtMj5lj5XBrhspdmk2azot 7TG0E2j4qyqktUpqhtZssf2GeHRJbtlaBgPzGEEoJBbIdixUnULRSvaZufkTwyA39v dJ52hkQzYe0Cw0L7nal4gU+q1cc6/hfSm7N8Q40c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tejas Joglekar , Felipe Balbi Subject: [PATCH 4.14 186/205] usb: dwc3: gadget: Handle 0 xfer length for OUT EP Date: Mon, 11 Feb 2019 15:19:44 +0100 Message-Id: <20190211141840.564258507@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tejas Joglekar commit 1e19cdc8060227b0802bda6bc0bd22b23679ba32 upstream. For OUT endpoints, zero-length transfers require MaxPacketSize buffer as per the DWC_usb3 programming guide 3.30a section 4.2.3.3. This patch fixes this by explicitly checking zero length transfer to correctly pad up to MaxPacketSize. Fixes: c6267a51639b ("usb: dwc3: gadget: align transfers to wMaxPacketSize") Cc: stable@vger.kernel.org Signed-off-by: Tejas Joglekar Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1114,7 +1114,7 @@ static void dwc3_prepare_one_trb_linear( unsigned int maxp = usb_endpoint_maxp(dep->endpoint.desc); unsigned int rem = length % maxp; - if (rem && usb_endpoint_dir_out(dep->endpoint.desc)) { + if ((!length || rem) && usb_endpoint_dir_out(dep->endpoint.desc)) { struct dwc3 *dwc = dep->dwc; struct dwc3_trb *trb;