All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Matthew Garrett <matthewgarrett@google.com>
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
	roberto.sassu@huawei.com, Matthew Garrett <mjg59@google.com>
Subject: Re: [PATCH V2 1/4] tpm: Abstract crypto agile event size calculations
Date: Mon, 11 Feb 2019 16:35:27 +0200	[thread overview]
Message-ID: <20190211143527.GA12051@linux.intel.com> (raw)
In-Reply-To: <20190211142800.GE8431@linux.intel.com>

On Mon, Feb 11, 2019 at 04:28:00PM +0200, Jarkko Sakkinen wrote:
> On Mon, Feb 04, 2019 at 01:33:00PM -0800, Matthew Garrett wrote:
> > +static inline int _calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
> > +					struct tcg_pcr_event *event_header)
> 
> Maybe __calc_tpm2_event_size().

Nice to have: add a kdoc since the function is now public e.g. a brief
description how the event size is calculated.

/Jarkko

  reply	other threads:[~2019-02-11 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190204213303.131064-1-matthewgarrett@google.com>
2019-02-04 21:33 ` [PATCH V2 1/4] tpm: Abstract crypto agile event size calculations Matthew Garrett
2019-02-11 14:28   ` Jarkko Sakkinen
2019-02-11 14:35     ` Jarkko Sakkinen [this message]
2019-02-04 21:33 ` [PATCH V2 2/4] tpm: Reserve the TPM final events table Matthew Garrett
2019-02-11 16:38   ` Jarkko Sakkinen
2019-02-11 20:58     ` Matthew Garrett
2019-02-12 23:11       ` Jarkko Sakkinen
2019-02-04 21:33 ` [PATCH V2 3/4] tpm: Append the final event log to the TPM event log Matthew Garrett
2019-02-04 21:33 ` [PATCH V2 4/4] efi: Attempt to get the TCG2 event log in the boot stub Matthew Garrett
2019-02-05  9:27 ` your mail Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211143527.GA12051@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=matthewgarrett@google.com \
    --cc=mjg59@google.com \
    --cc=peterhuewe@gmx.de \
    --cc=roberto.sassu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.