From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gtG2l-0002Ff-7F for mharc-grub-devel@gnu.org; Mon, 11 Feb 2019 13:10:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtG2j-0002FX-4j for grub-devel@gnu.org; Mon, 11 Feb 2019 13:10:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtG2h-0005o5-Bn for grub-devel@gnu.org; Mon, 11 Feb 2019 13:10:57 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:51864 helo=foss.arm.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtG2h-0005kF-34 for grub-devel@gnu.org; Mon, 11 Feb 2019 13:10:55 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 64C58EBD; Mon, 11 Feb 2019 10:10:51 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FC8C3F557; Mon, 11 Feb 2019 10:10:50 -0800 (PST) Date: Mon, 11 Feb 2019 18:10:47 +0000 From: Andre Przywara To: Daniel Kiper Cc: Vladimir Serbinenko , Andrei Borzenkov , Daniel Kiper , Mark Rutland , Subject: Re: [PATCH] bootp: add native DHCPv4 support Message-ID: <20190211181047.299610dc@donnerap.cambridge.arm.com> In-Reply-To: <20190124141319.fse4uzv3sqmr3oel@tomti.i.net-space.pl> References: <20190111155934.233587-1-andre.przywara@arm.com> <20190121120208.tadbamgtdl2fpztl@tomti.i.net-space.pl> <20190121141048.6f5ec78f@donnerap.cambridge.arm.com> <20190124141319.fse4uzv3sqmr3oel@tomti.i.net-space.pl> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.140.101.70 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 18:10:58 -0000 On Thu, 24 Jan 2019 15:13:19 +0100 Daniel Kiper wrote: Hi Daniel, > On Mon, Jan 21, 2019 at 02:10:48PM +0000, Andre Przywara wrote: > > On Mon, 21 Jan 2019 13:02:08 +0100 > > Daniel Kiper wrote: ... > > > Is it possible to split this patch to smaller pieces? > > > > Possible: yes, though I am not sure I understand enough of it and grub > > to do it properly. Will try my best, though, as soon as I find some > > spare cycles to understand the patch a bit better. > > Is it matter of days, weeks or months? Apparently a matter of 18 days ;-) So I read the Wikipedia pages for DHCP and BOOTP, skimmed over the various RFCs and wrapped my head around the high level functionality of the grub network stack. After starring a while at Andrei's patch I think I figured what he did. So I managed to break it down into a series of refactoring patches, with some patches on top to add the actual DHCP functionality. I will clean that up and try to test it as far as possible. > > The rest of the comments make sense, I will address them eventually, > > unless someone (Andrei?) screams... > > Thanks a lot! > > I am looking forward for next version of this patch. Prepare for a series of 9 patches (at the moment) later this week. ;-) Cheers, Andre.