From: Markus Mayer <code@mmayer.net>
To: Brian Norris <computersforpeace@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>
Cc: Markus Mayer <mmayer@broadcom.com>,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] soc: brcmstb: dpfe: use msleep() over udelay()
Date: Mon, 11 Feb 2019 17:24:41 -0800 [thread overview]
Message-ID: <20190212012443.21819-2-code@mmayer.net> (raw)
In-Reply-To: <20190212012443.21819-1-code@mmayer.net>
From: Markus Mayer <mmayer@broadcom.com>
To be more "scheduler friendly", we use msleep() rather than udelay()
while we wait for the DCPU to respond.
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
drivers/memory/brcmstb_dpfe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
index 04599eccd604..8e1ccdb0e59d 100644
--- a/drivers/memory/brcmstb_dpfe.c
+++ b/drivers/memory/brcmstb_dpfe.c
@@ -111,7 +111,7 @@
#define DPFE_MSG_TYPE_COMMAND 1
#define DPFE_MSG_TYPE_RESPONSE 2
-#define DELAY_LOOP_MAX 200000
+#define DELAY_LOOP_MAX 1000
enum dpfe_msg_fields {
MSG_HEADER,
@@ -323,7 +323,7 @@ static int __send_command(struct private_data *priv, unsigned int cmd,
resp = readl_relaxed(regs + REG_TO_HOST_MBOX);
if (resp > 0)
break;
- udelay(5);
+ msleep(1);
}
if (i == DELAY_LOOP_MAX) {
--
2.17.1
next prev parent reply other threads:[~2019-02-12 1:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 1:24 [PATCH 0/3] Some minor updates and fixes for the BRCMSTB DPFE driver Markus Mayer
2019-02-12 1:24 ` Markus Mayer [this message]
2019-03-09 22:03 ` [PATCH 1/3] soc: brcmstb: dpfe: use msleep() over udelay() Florian Fainelli
2019-03-09 22:03 ` Florian Fainelli
2019-02-12 1:24 ` [PATCH 2/3] soc: brcmstb: dpfe: optimize generic_show() Markus Mayer
2019-03-09 22:03 ` Florian Fainelli
2019-03-09 22:03 ` Florian Fainelli
2019-02-12 1:24 ` [PATCH 3/3] soc: brcmstb: dpfe: use byte 3 of registers MR4-MR8 Markus Mayer
2019-03-09 22:03 ` Florian Fainelli
2019-03-09 22:03 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212012443.21819-2-code@mmayer.net \
--to=code@mmayer.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.