From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBE7F6E008 for ; Tue, 12 Feb 2019 08:45:36 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id a2so1493230edi.0 for ; Tue, 12 Feb 2019 00:45:36 -0800 (PST) Date: Tue, 12 Feb 2019 09:45:32 +0100 From: Daniel Vetter Message-ID: <20190212084532.GX23159@phenom.ffwll.local> References: <20190211180208.29406-1-daniel.vetter@ffwll.ch> <20190211180208.29406-3-daniel.vetter@ffwll.ch> <154991899170.15715.1631719136617848704@skylake-alporthouse-com> <20190211223825.GV23159@phenom.ffwll.local> <154992607608.14378.13727024411543835857@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <154992607608.14378.13727024411543835857@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t 3/9] lib: Don't leak children in igt_waitchildren_timeout List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT development , Daniel Vetter , Daniel Vetter List-ID: T24gTW9uLCBGZWIgMTEsIDIwMTkgYXQgMTE6MDE6MTZQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxOS0wMi0xMSAyMjozODoyNSkKPiA+IE9u IE1vbiwgRmViIDExLCAyMDE5IGF0IDA5OjAzOjEyUE0gKzAwMDAsIENocmlzIFdpbHNvbiB3cm90 ZToKPiA+ID4gUXVvdGluZyBEYW5pZWwgVmV0dGVyICgyMDE5LTAyLTExIDE4OjAyOjAyKQo+ID4g PiA+IEluc3RlYWQgb2YgY2xlYW5pbmcgdXAgdGhlIG1lc3MgaW4gaWd0X2V4aXQgbWFrZSBzdXJl IHdlIGRvbid0IGV2ZW4KPiA+ID4gPiBsZXQgaXQgb3V0IG9mIHRoZSBjb250YWluZXIuIFNlZSBh bHNvCj4gPiA+ID4gCj4gPiA+ID4gY29tbWl0IDc1NDg3NjM3OGQ2YzliMjc3NWU4YzA3YjRkMTZm OTg3OGM1NTk0OWYKPiA+ID4gPiBBdXRob3I6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+ID4gPiA+IERhdGU6ICAgRnJpIEZlYiAyNiAyMjoxMToxMCAyMDE2ICswMDAw Cj4gPiA+ID4gCj4gPiA+ID4gICAgIGlndC9nZW1fc3luYzogRW5mb3JjZSBhIHRpbWVvdXQgb2Yg MjBzCj4gPiA+ID4gCj4gPiA+ID4gd2hpY2ggYWRkZWQgdGhpcyBoZWxwZXIuCj4gPiA+ID4gCj4g PiA+ID4gVG8gbWFrZSBzdXJlIHRoYXQgZXZlcnlvbmUgZm9sbG93cyB0aGUgcnVsZXMsIGFkZCBh biBhc3NlcnQuCj4gPiA+ID4gCj4gPiA+ID4gV2UncmUga2VlcGluZyB0aGUgY2xlYW51cCBjb2Rl IGFzIGEgZmFpbHNhZmUsIGFuZCBiZWNhdXNlIGl0IHNwZWVkcwo+ID4gPiA+IHVwIHRoZSB0ZXN0 Y2FzZSBJJ20gZm9sbG93aW5nIHVwIHdpdGguCj4gPiA+ID4gCj4gPiA+ID4gdjI6IENocmlzIHBv aW50ZWQgb3V0IHRoYXQgbXkgb3JpZ2luYWwgcGF0Y2ggZGlkIG5vdGhpbmcuIFdoaWNoIEkKPiA+ ID4gPiBkaWRuJ3QgY2F0Y2ggYmVjYXVzZSBteSB0ZXN0Y2FzZSB3YXMgYWxzbyBicm9rZW4uIFVu Zm9ydHVuYXRlbHkgdGhpcwo+ID4gPiA+IG1lYW5zIHdlIG5lZWQgdG8gb3BlbiBjb2RlIHBhcnQg b2YgdGhlIHdhaXRpbmcuCj4gPiA+ID4gCj4gPiA+ID4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIg PGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICBsaWIvaWd0X2Nv cmUuYyB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gPiA+ ICAxIGZpbGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiA+ID4g PiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9jb3JlLmMgYi9saWIvaWd0X2NvcmUuYwo+ ID4gPiA+IGluZGV4IGNiYmU3OWY4ODA3MC4uMzA1MzY5N2RhNThjIDEwMDY0NAo+ID4gPiA+IC0t LSBhL2xpYi9pZ3RfY29yZS5jCj4gPiA+ID4gKysrIGIvbGliL2lndF9jb3JlLmMKPiA+ID4gPiBA QCAtMTUyNSw2ICsxNTI1LDcgQEAgdm9pZCBpZ3RfZXhpdCh2b2lkKQo+ID4gPiA+ICAKPiA+ID4g PiAgICAgICAgIGZvciAoaW50IGMgPSAwOyBjIDwgbnVtX3Rlc3RfY2hpbGRyZW47IGMrKykKPiA+ ID4gPiAgICAgICAgICAgICAgICAga2lsbCh0ZXN0X2NoaWxkcmVuW2NdLCBTSUdLSUxMKTsKPiA+ ID4gPiArICAgICAgIGFzc2VydCghbnVtX3Rlc3RfY2hpbGRyZW4pOwo+ID4gPiA+ICAKPiA+ID4g PiAgICAgICAgIGlmICghdGVzdF93aXRoX3N1YnRlc3RzKSB7Cj4gPiA+ID4gICAgICAgICAgICAg ICAgIHN0cnVjdCB0aW1lc3BlYyBub3c7Cj4gPiA+ID4gQEAgLTE4MzIsMjAgKzE4MzMsNDggQEAg dm9pZCBpZ3Rfd2FpdGNoaWxkcmVuKHZvaWQpCj4gPiA+ID4gICAgICAgICAgICAgICAgIGlndF9m YWlsKGVycik7Cj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4gK3N0YXRpYyBib29sIGlndF9r aWxsY2hpZHJlbl90aW1lZF9vdXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgdm9pZCBpZ3Rf YWxhcm1fa2lsbGNoaWxkcmVuKGludCBzaWduYWwpCj4gPiA+ID4gK3sKPiA+ID4gPiArICAgICAg IGlndF9pbmZvKCJUaW1lZCBvdXQgd2FpdGluZyBmb3IgY2hpbGRyZW5cbiIpOwo+ID4gPiAKPiA+ ID4gV2UgdXNlZCB0byBwcmludCB0aGUgY2FsbGVyIHN1cHBsaWVkIHJlYXNvbi4gQWx0aG91Z2gg dGhhdCBhcHBlYXJzIHRvCj4gPiA+IGhhdmUgbmV2ZXIgYmVlbiB1c2VkLCBzbyBtaWdodCBhcyB3 ZWxsIGRyb3AgaXQgZnJvbSB0aGUgQVBJLgo+ID4gPiAKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAg ICBpZ3Rfa2lsbGNoaWRyZW5fdGltZWRfb3V0ID0gdHJ1ZTsKPiA+ID4gPiArCj4gPiA+ID4gKyAg ICAgICBmb3IgKGludCBjID0gMDsgYyA8IG51bV90ZXN0X2NoaWxkcmVuOyBjKyspCj4gPiA+ID4g KyAgICAgICAgICAgICAgIGtpbGwodGVzdF9jaGlsZHJlbltjXSwgU0lHS0lMTCk7Cj4gPiA+IAo+ ID4gPiBPaywga2lsbCgpIGlzIHNpZ25hbC1zYWZlLgo+ID4gPiAKPiA+ID4gPiArfQo+ID4gPiA+ ICsKPiA+ID4gPiAgLyoqCj4gPiA+ID4gICAqIGlndF93YWl0Y2hpbGRyZW5fdGltZW91dDoKPiA+ ID4gPiAgICogQHNlY29uZHM6IHRpbWVvdXQgaW4gc2Vjb25kcyB0byB3YWl0Cj4gPiA+ID4gICAq IEByZWFzb246IGRlYnVnIHN0cmluZyBleHBsYWluaW5nIHdoYXQgdGltZWRvdXQKPiA+ID4gPiAg ICoKPiA+ID4gPiAtICogV2FpdCBmb3IgYWxsIGNoaWxkcmVuIGZvcmtlZCB3aXRoIGlndF9mb3Jr LCBmb3IgYSBtYXhpbXVtIG9mIEBzZWNvbmRzLgo+ID4gPiA+IC0gKgo+ID4gPiA+IC0gKiBXcmFw cyBpZ3Rfd2FpdGNoaWxkcmVuKCkgYW5kIGlndF9zZXRfdGltZW91dCgpCj4gPiA+ID4gKyAqIFdh aXQgZm9yIGFsbCBjaGlsZHJlbiBmb3JrZWQgd2l0aCBpZ3RfZm9yaywgZm9yIGEgbWF4aW11bSBv ZiBAc2Vjb25kcy4gSWYgdGhlCj4gPiA+ID4gKyAqIHRpbWVvdXQgZXhwaXJlcywga2lsbHMgYWxs IGNoaWxkcmVuIGFuZCBjbGVhbnMgdGhlbSB1cC4KPiA+ID4gPiAgICovCj4gPiA+ID4gIHZvaWQg aWd0X3dhaXRjaGlsZHJlbl90aW1lb3V0KGludCBzZWNvbmRzLCBjb25zdCBjaGFyICpyZWFzb24p Cj4gPiA+ID4gIHsKPiA+ID4gPiAtICAgICAgIGlndF9zZXRfdGltZW91dChzZWNvbmRzLCByZWFz b24pOwo+ID4gPiA+IC0gICAgICAgaWd0X3dhaXRjaGlsZHJlbigpOwo+ID4gPiA+ICsgICAgICAg c3RydWN0IHNpZ2FjdGlvbiBzYTsKPiA+ID4gPiArICAgICAgIGludCByZXQ7Cj4gPiA+ID4gKwo+ ID4gPiA+ICsgICAgICAgc2Euc2FfaGFuZGxlciA9IGlndF9hbGFybV9raWxsY2hpbGRyZW47Cj4g PiA+ID4gKyAgICAgICBzaWdlbXB0eXNldCgmc2Euc2FfbWFzayk7Cj4gPiA+ID4gKyAgICAgICBz YS5zYV9mbGFncyA9IDA7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgICAgaWd0X2tpbGxjaGlkcmVu X3RpbWVkX291dCA9IGZhbHNlOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgIHNpZ2FjdGlvbihT SUdBTFJNLCAmc2EsIE5VTEwpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgIGFsYXJtKHNlY29u ZHMpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgIHJldCA9IF9faWd0X3dhaXRjaGlsZHJlbigp Owo+ID4gPiA+ICsgICAgICAgaWYgKCFpZ3Rfa2lsbGNoaWRyZW5fdGltZWRfb3V0ICYmIHJldCkK PiA+ID4gPiArICAgICAgICAgICAgICAgaWd0X2ZhaWwocmV0KTsKPiA+ID4gPiAgICAgICAgIGln dF9yZXNldF90aW1lb3V0KCk7Cj4gPiA+ID4gKyAgICAgICBfX2lndF93YWl0Y2hpbGRyZW4oKTsK PiA+ID4gPiArICAgICAgIGlmIChpZ3Rfa2lsbGNoaWRyZW5fdGltZWRfb3V0KQo+ID4gPiA+ICsg ICAgICAgICAgICAgICBpZ3RfZmFpbChJR1RfRVhJVF9GQUlMVVJFKTsKPiA+ID4gCj4gPiA+IERv dWJsZSBfX2lndF93YWl0Y2hpbGRyZW4oKT8gTXkgcmVhZGluZyBvZiBfX2lndF93YWl0Y2hpbGRy ZW4oKSBpcyB0aGF0Cj4gPiA+IGl0IHdpbGwgY29udGludWUgb24gYWZ0ZXIgdGhlIGFsYXJtKCkg d2FrZXMgd2FpdCgpIHVwIHdpdGggU0lHSU5UIGFuZAo+ID4gPiByZXBlYXQgdGhlIHdhaXQoKSB1 bnRpbCBhbGwgY2hpbGRyZW4gZGllLiBBbmQgbm93IHRob3NlIGNoaWxkcmVuIHdpbGwKPiA+ID4g ZGllLCByYXRoZXIgdGhhbiB0aGUgcGFyZW50IGFzIGJlZm9yZS4KPiA+IAo+ID4gaWd0X3dhaXRj aGlsZHJlbl90aW1lb3V0IGJlZm9yZSB0aGlzIHBhdGNoIHdvdWxkbid0IHdvcmsgaWYgaXQgZGlk IHRoYXQuCj4gCj4gQmVmb3JlIHRoaXMgcGF0Y2gsIHRoZSBhbGFybSBoYW5kbGVyIGRpZCBpZ3Rf ZmFpbCAtPiBleGl0KDEpIGluIHRoZQo+IHBhcmVudC4KPiAKPiA+IFRoZSBwaWQgPT0gd2FpdCgp OyBpZiAocGlkID09IC0xKSBjb250aW51ZTsgYmFpbHMgb3V0IHRvIHRoZSBuZXh0IGNoaWxkIGlu Cj4gPiBjYXNlIG9mIGludGVycnVwdHMuIEhlbmNlIHRoZSB3YWl0OyBraWxsOyB3YWl0IHNlcXVl bmNlIGhlcmUuIEkgZGlzY292ZXJlZAo+ID4gdGhpcyB0aHJvdWdoIHRlc3RjYXNlcyA6LSkKPiAK PiBOb3cgYWxhcm0gLT4gd2FpdCgpIHJldHVybmluZyAtMSArIGVycm5vPUVJTlRSLCByaWdodD8g VGhlbiB0aGUKPiBzaWdoYW5kbGVyIGRvZXMga2lsbGFsbCAtOSwgc28gb24gdGhlIG5leHQgd2Fp dCBpdCBzZWVzIHRoYXQgYWxsIHRoZQo+IGNoaWxkcmVuIGFyZSBkZWFkLgo+IAo+IF9faWd0X3dh aXRjaGlsZHJlbigpIGV2ZW4gc2V0cyBudW1fdGVzdF9jaGlsZHJlbiA9IDAgb24gcmV0dXJuLCBz byB0aGUKPiBzZWNvbmQgX19pZ3Rfd2FpdGNoaWxkcmVuKCkgbXVzdCBkbyBub3RoaW5nLiBPciBJ IGFtIHZlcnkgY29uZnVzZWQuCgpIbSByaWdodCBJIHRoaW5rIEkgZ290IG15c2VsZiB0b3RhbGx5 IGNvbmZ1c2VkIHdpdGggc29tZSBvbGRlciB2ZXJzaW9uIG9mCnRoaXMgKHdoaWNoIHdhcyBicm9r ZW4pLCBpbiBjb21iaW5hdGlvbiB3aXRoIGFsc28gYnJva2VuIHRlc3RjYXNlcy4KCkxvb2tpbmcg YXQgdGhlIGNvZGUgYWdhaW4gaXQgZG9lcyBpbmRlZWQgbG9vcCB1bnRpbCBpdCBoYXMgdGhlbSBh bGwsIHBsdXMKdGhlcmUgaXMgZXZlbiBhIGxvb3AgdG8ga2lsbCBhbGwgdGhlIGNoaWxkcmVuIGlm IG9uZSBmYWlsZWQuIEknbGwgc2VlIHdoYXQKaGFwcGVucyB3aGVuIEkgZHJvcCB0aGUgMm5kIHdh aXRjaGlsZHJlbiwgYW5kIGRvdWJsZS1jaGVjayBteSB0ZXN0cyBkbwp0ZXN0cyB3aGF0IEkgd2Fu dCB0byB0ZXN0LgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2lndC1kZXY=