From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id C71A76E586 for ; Tue, 12 Feb 2019 12:46:59 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id m12so372624edv.4 for ; Tue, 12 Feb 2019 04:46:59 -0800 (PST) Date: Tue, 12 Feb 2019 13:46:55 +0100 From: Daniel Vetter Message-ID: <20190212124655.GY23159@phenom.ffwll.local> References: <20190211180208.29406-3-daniel.vetter@ffwll.ch> <20190212120429.20625-1-daniel.vetter@ffwll.ch> <154997336486.2447.5977084066251962615@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <154997336486.2447.5977084066251962615@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t] lib: Don't leak children in igt_waitchildren_timeout List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT development , Daniel Vetter List-ID: T24gVHVlLCBGZWIgMTIsIDIwMTkgYXQgMTI6MDk6MjVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxOS0wMi0xMiAxMjowNDoyOSkKPiA+IElu c3RlYWQgb2YgY2xlYW5pbmcgdXAgdGhlIG1lc3MgaW4gaWd0X2V4aXQgbWFrZSBzdXJlIHdlIGRv bid0IGV2ZW4KPiA+IGxldCBpdCBvdXQgb2YgdGhlIGNvbnRhaW5lci4gU2VlIGFsc28KPiA+IAo+ ID4gY29tbWl0IDc1NDg3NjM3OGQ2YzliMjc3NWU4YzA3YjRkMTZmOTg3OGM1NTk0OWYKPiA+IEF1 dGhvcjogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiBEYXRlOiAg IEZyaSBGZWIgMjYgMjI6MTE6MTAgMjAxNiArMDAwMAo+ID4gCj4gPiAgICAgaWd0L2dlbV9zeW5j OiBFbmZvcmNlIGEgdGltZW91dCBvZiAyMHMKPiA+IAo+ID4gd2hpY2ggYWRkZWQgdGhpcyBoZWxw ZXIuCj4gPiAKPiA+IFRvIG1ha2Ugc3VyZSB0aGF0IGV2ZXJ5b25lIGZvbGxvd3MgdGhlIHJ1bGVz LCBhZGQgYW4gYXNzZXJ0Lgo+ID4gCj4gPiBXZSdyZSBrZWVwaW5nIHRoZSBjbGVhbnVwIGNvZGUg YXMgYSBmYWlsc2FmZSwgYW5kIGJlY2F1c2UgaXQgc3BlZWRzCj4gPiB1cCB0aGUgdGVzdGNhc2Ug SSdtIGZvbGxvd2luZyB1cCB3aXRoLgo+ID4gCj4gPiB2MjogQ2hyaXMgcG9pbnRlZCBvdXQgdGhh dCBteSBvcmlnaW5hbCBwYXRjaCBkaWQgbm90aGluZy4gV2hpY2ggSQo+ID4gZGlkbid0IGNhdGNo IGJlY2F1c2UgbXkgdGVzdGNhc2Ugd2FzIGFsc28gYnJva2VuLiBVbmZvcnR1bmF0ZWx5IHRoaXMK PiA+IG1lYW5zIHdlIG5lZWQgdG8gb3BlbiBjb2RlIHBhcnQgb2YgdGhlIHdhaXRpbmcuCj4gPiAK PiA+IHYzOiBUaGUgMm5kIF9faWd0X3dhaXRjaGlsZHJlbigpIGlzbid0IG5lY2Vzc2FyeSwgX19p Z3Rfd2FpdGNoaWxkcmVuCj4gPiByZWNvdmVycyBmcm9tIEVJTlRSIGFscmVhZHkgYW5kIGtlZXBz IHdhaXRpbmcgKENocmlzIFdpbHNvbikuCj4gPiAKPiA+IENjOiBDaHJpcyBXaWxzb24gPGNocmlz QGNocmlzLXdpbHNvbi5jby51az4KPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgbGliL2lndF9jb3JlLmMgfCAzOCAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2Vk LCAzMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv bGliL2lndF9jb3JlLmMgYi9saWIvaWd0X2NvcmUuYwo+ID4gaW5kZXggY2JiZTc5Zjg4MDcwLi5m YTczNzEyY2VkOTEgMTAwNjQ0Cj4gPiAtLS0gYS9saWIvaWd0X2NvcmUuYwo+ID4gKysrIGIvbGli L2lndF9jb3JlLmMKPiA+IEBAIC0xNTI1LDYgKzE1MjUsNyBAQCB2b2lkIGlndF9leGl0KHZvaWQp Cj4gPiAgCj4gPiAgICAgICAgIGZvciAoaW50IGMgPSAwOyBjIDwgbnVtX3Rlc3RfY2hpbGRyZW47 IGMrKykKPiA+ICAgICAgICAgICAgICAgICBraWxsKHRlc3RfY2hpbGRyZW5bY10sIFNJR0tJTEwp Owo+ID4gKyAgICAgICBhc3NlcnQoIW51bV90ZXN0X2NoaWxkcmVuKTsKPiA+ICAKPiA+ICAgICAg ICAgaWYgKCF0ZXN0X3dpdGhfc3VidGVzdHMpIHsKPiA+ICAgICAgICAgICAgICAgICBzdHJ1Y3Qg dGltZXNwZWMgbm93Owo+ID4gQEAgLTE4MzIsMjAgKzE4MzMsNDcgQEAgdm9pZCBpZ3Rfd2FpdGNo aWxkcmVuKHZvaWQpCj4gPiAgICAgICAgICAgICAgICAgaWd0X2ZhaWwoZXJyKTsKPiA+ICB9Cj4g PiAgCj4gPiArc3RhdGljIGJvb2wgaWd0X2tpbGxjaGlkcmVuX3RpbWVkX291dDsKPiA+ICsKPiA+ ICtzdGF0aWMgdm9pZCBpZ3RfYWxhcm1fa2lsbGNoaWxkcmVuKGludCBzaWduYWwpCj4gPiArewo+ ID4gKyAgICAgICBpZ3RfaW5mbygiVGltZWQgb3V0IHdhaXRpbmcgZm9yIGNoaWxkcmVuXG4iKTsK PiA+ICsKPiA+ICsgICAgICAgaWd0X2tpbGxjaGlkcmVuX3RpbWVkX291dCA9IHRydWU7Cj4gPiAr Cj4gPiArICAgICAgIGZvciAoaW50IGMgPSAwOyBjIDwgbnVtX3Rlc3RfY2hpbGRyZW47IGMrKykK PiA+ICsgICAgICAgICAgICAgICBraWxsKHRlc3RfY2hpbGRyZW5bY10sIFNJR0tJTEwpOwo+ID4g K30KPiA+ICsKPiA+ICAvKioKPiA+ICAgKiBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQ6Cj4gPiAg ICogQHNlY29uZHM6IHRpbWVvdXQgaW4gc2Vjb25kcyB0byB3YWl0Cj4gPiAgICogQHJlYXNvbjog ZGVidWcgc3RyaW5nIGV4cGxhaW5pbmcgd2hhdCB0aW1lZG91dAo+ID4gICAqCj4gPiAtICogV2Fp dCBmb3IgYWxsIGNoaWxkcmVuIGZvcmtlZCB3aXRoIGlndF9mb3JrLCBmb3IgYSBtYXhpbXVtIG9m IEBzZWNvbmRzLgo+ID4gLSAqCj4gPiAtICogV3JhcHMgaWd0X3dhaXRjaGlsZHJlbigpIGFuZCBp Z3Rfc2V0X3RpbWVvdXQoKQo+ID4gKyAqIFdhaXQgZm9yIGFsbCBjaGlsZHJlbiBmb3JrZWQgd2l0 aCBpZ3RfZm9yaywgZm9yIGEgbWF4aW11bSBvZiBAc2Vjb25kcy4gSWYgdGhlCj4gPiArICogdGlt ZW91dCBleHBpcmVzLCBraWxscyBhbGwgY2hpbGRyZW4gYW5kIGNsZWFucyB0aGVtIHVwLgo+ID4g ICAqLwo+ID4gIHZvaWQgaWd0X3dhaXRjaGlsZHJlbl90aW1lb3V0KGludCBzZWNvbmRzLCBjb25z dCBjaGFyICpyZWFzb24pCj4gPiAgewo+ID4gLSAgICAgICBpZ3Rfc2V0X3RpbWVvdXQoc2Vjb25k cywgcmVhc29uKTsKPiA+IC0gICAgICAgaWd0X3dhaXRjaGlsZHJlbigpOwo+ID4gKyAgICAgICBz dHJ1Y3Qgc2lnYWN0aW9uIHNhOwo+ID4gKyAgICAgICBpbnQgcmV0Owo+ID4gKwo+ID4gKyAgICAg ICBzYS5zYV9oYW5kbGVyID0gaWd0X2FsYXJtX2tpbGxjaGlsZHJlbjsKPiA+ICsgICAgICAgc2ln ZW1wdHlzZXQoJnNhLnNhX21hc2spOwo+ID4gKyAgICAgICBzYS5zYV9mbGFncyA9IDA7Cj4gPiAr Cj4gPiArICAgICAgIGlndF9raWxsY2hpZHJlbl90aW1lZF9vdXQgPSBmYWxzZTsKPiA+ICsKPiA+ ICsgICAgICAgc2lnYWN0aW9uKFNJR0FMUk0sICZzYSwgTlVMTCk7Cj4gPiArCj4gPiArICAgICAg IGFsYXJtKHNlY29uZHMpOwo+ID4gKwo+ID4gKyAgICAgICByZXQgPSBfX2lndF93YWl0Y2hpbGRy ZW4oKTsKPiA+ICsgICAgICAgaWYgKCFpZ3Rfa2lsbGNoaWRyZW5fdGltZWRfb3V0ICYmIHJldCkK PiA+ICsgICAgICAgICAgICAgICBpZ3RfZmFpbChyZXQpOwo+ID4gICAgICAgICBpZ3RfcmVzZXRf dGltZW91dCgpOwo+IAo+IEV4cGVyaWVuY2Ugc2F5cyB0byBjYW5jZWwgdGhlIGFsYXJtIGFzIHNv b24gYXMgeW91IG5vIGxvbmdlciBuZWVkIGl0Lgo+IAo+ID4gKyAgICAgICBpZiAoaWd0X2tpbGxj aGlkcmVuX3RpbWVkX291dCkKPiA+ICsgICAgICAgICAgICAgICBpZ3RfZmFpbChJR1RfRVhJVF9G QUlMVVJFKTsKPiAKPiBTb21ldGhpbmcgbGlrZQo+IAo+IHJldCA9IF9faWd0X3dhaXRjaGlsZHJl bigpOwo+IGlndF9yZXNldF90aW1lb3V0KCk7Cj4gaWYgKGlndF9raWxsY2hpbGRyZW5fdGltZWRf b3V0ICYmICFyZXQpIC8vIHRoaXMgc2hvdWxkIGJlIGltcG9zc2libGUhCj4gCXJldCA9IElHVF9F WElUX0ZBSUxVUkU7Cj4gaWYgKHJldCkKPiAJaWd0X2ZhaWwocmV0KTsKPiAKPiBKdXN0IHRvIGhh dmUgb25seSBvbmUgcGF0aCB0byB0aGUgaWd0X2ZhaWwuIEknbSBub3QgZXZlbiBzdXJlIGFib3V0 Cj4gbmVlZGluZyB0aGUgaWd0X2tpbGxjaGlsZHJlbl90aW1lZF9vdXQ7IGlmIG5vIGNoaWxkIHdh cyBraWxsZWQgdGhlbiB3ZQo+IGRpZG4ndCBleGFjdGx5IHRpbWVvdXQgOikKCkhtIHJpZ2h0IG9y ZGVyZWQgdGhpcyB3YXkgd2Ugc2hvdWxkIGVpdGhlciBnZXQgYSBTSUdLSUxMIHN0YXR1cyBpbiBy ZXQsIG9yCml0IGFsbCB3b3JrZWQgb3V0LiBJJ2xsIHJlc3Bpbi4KLURhbmllbAotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K aWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2