From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD009C282C4 for ; Tue, 12 Feb 2019 12:56:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 989B4214DA for ; Tue, 12 Feb 2019 12:56:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="vezDLPPs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729448AbfBLM4x (ORCPT ); Tue, 12 Feb 2019 07:56:53 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:48331 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728365AbfBLM4x (ORCPT ); Tue, 12 Feb 2019 07:56:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=33/92cUn2Qa1jrfNNoAizuKRYz9AY7n92wrqTTSAxoo=; b=vezDLPPstzTTJ/tC8VqbyqvmpN 3W1D93PjrlOWSN0hpgiJ+I+oAikqPNis1whU0XHe+P21eqZF6tbvvEJx0e1WWU5/CRZemRXqEVT2D 22so4DceUiKNUuOY4hTZ0iAYGBC9tnfKTfgvvMMiVbYACyRqpfRN/j4oWxKSPLfdRmfk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gtXcC-00021b-G5; Tue, 12 Feb 2019 13:56:44 +0100 Date: Tue, 12 Feb 2019 13:56:44 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: John David Anglin , Russell King , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org Subject: Re: [PATCH net] dsa: mv88e6xxx: Ensure all pending interrupts are handled prior to exit Message-ID: <20190212125644.GA7527@lunn.ch> References: <20190130223846.GB30115@lunn.ch> <9415d82e-965b-7777-0ad0-f23d6c9f177e@bell.net> <53b49df8-53ed-704f-9197-230b18d83090@bell.net> <824d011b-3692-69c3-5e2c-58e950a80abf@bell.net> <6a1ebc61-3505-beb8-21cb-ea42ad9fe67e@bell.net> <20190211233327.GB8591@lunn.ch> <2b6bbb4c-1346-461b-ff7a-cb96b4142f7a@bell.net> <20190212035806.GE19023@lunn.ch> <13c1e6d5-c287-0091-3b24-1978f9a18e7e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13c1e6d5-c287-0091-3b24-1978f9a18e7e@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 12, 2019 at 07:51:05AM +0100, Heiner Kallweit wrote: > On 12.02.2019 04:58, Andrew Lunn wrote: > >>> Hi David > >>> > >>> I just tested this on one of my boards. It loops endlessly: > >>> > >>> [ 47.173396] mv88e6xxx_g1_irq_thread_work: c881 a8 80 > >>> [ 47.182108] mv88e6xxx_g1_irq_thread_work: c881 a8 80 > >>> [ 47.190820] mv88e6xxx_g1_irq_thread_work: c881 a8 80 > >>> [ 47.199535] mv88e6xxx_g1_irq_thread_work: c881 a8 80 > >>> [ 47.208254] mv88e6xxx_g1_irq_thread_work: c881 a8 80 > >>> > >>> These are reg, ctl1, reg & ctl1. > >>> > >>> So there is an unhandled device interrupt. > > > > Hi Heiner > > > > Your patch Fixes: 2b3e88ea6528 ("net: phy: improve phy state > > checking") is causing me problems with interrupts for the Marvell > > switches. > > > Hi Andrew, > > what kernel version is it? It is a little bit old, 5.0-rc1 net-next. I should rebase and retest. I'm testing on a ZII board which is not fully in mainline So i need some patches. > And the PHY driver in use is "Marvell 88E6390" ? Yes, the marvell 1G driver. Andrew