From: Andrew Lunn <andrew@lunn.ch>
To: "Kiyanovski, Arthur" <akiyano@amazon.com>
Cc: Moritz Fischer <moritz.fischer@ettus.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>
Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to 2.0.3
Date: Tue, 12 Feb 2019 14:11:15 +0100 [thread overview]
Message-ID: <20190212131115.GB7527@lunn.ch> (raw)
In-Reply-To: <55dcaee1242649e2a4d8984f120844ae@EX13D22EUA004.ant.amazon.com>
On Tue, Feb 12, 2019 at 11:42:31AM +0000, Kiyanovski, Arthur wrote:
> Hi Moritz,
>
> > -----Original Message-----
> > From: Moritz Fischer <moritz.fischer@ettus.com>
> > Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to
> > 2.0.3
> >
> > Hi Arthur,
> >
> > On Mon, Feb 11, 2019 at 9:19 AM <akiyano@amazon.com> wrote:
> > >
> > > From: Arthur Kiyanovski <akiyano@amazon.com>
> > >
> > > Update driver version due to bug fix.
> >
> > Wouldn't you want to do this atomically with the actual fix in one commit?
> >
> > Thanks,
> > Moritz
>
> Thanks for the feedback.
> I don't want to add the version to the fix.
> Version 2.0.3 includes all of its content that came before this fix, including features.
> Fixes are cherry-picked to older driver versions automatically using the "Fixes:" directive.
> If I add the version change to the fix, older driver versions that get this fix will become version 2.0.3, which is incorrect feature-wise.
Hi Arthur
I think this points out how useless the version string it, and why
many drivers don't use it.
Andrew
next prev parent reply other threads:[~2019-02-12 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 17:17 [PATCH V1 net 0/2] net: ena: race condition bug fix and version update akiyano
2019-02-11 17:17 ` [PATCH V1 net 1/2] net: ena: fix race between link up and device initalization akiyano
2019-02-11 17:17 ` [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to 2.0.3 akiyano
2019-02-12 11:12 ` Moritz Fischer
2019-02-12 11:42 ` Kiyanovski, Arthur
2019-02-12 13:11 ` Andrew Lunn [this message]
2019-02-12 19:06 ` [PATCH V1 net 0/2] net: ena: race condition bug fix and version update David Miller
2019-03-13 12:59 ` Bshara, Saeed
2019-03-13 17:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212131115.GB7527@lunn.ch \
--to=andrew@lunn.ch \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=gtzalik@amazon.com \
--cc=matua@amazon.com \
--cc=moritz.fischer@ettus.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.