From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C238C282C4 for ; Tue, 12 Feb 2019 17:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AFB0206A3 for ; Tue, 12 Feb 2019 17:02:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="jDr9FmHs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729685AbfBLRCf (ORCPT ); Tue, 12 Feb 2019 12:02:35 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40745 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfBLRCf (ORCPT ); Tue, 12 Feb 2019 12:02:35 -0500 Received: by mail-pg1-f196.google.com with SMTP id z10so1524890pgp.7 for ; Tue, 12 Feb 2019 09:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=b3qQj4mXhxHuk7HUx8hKMYx+LaexHXIfoktLdRsumAQ=; b=jDr9FmHsDi3YRiGCLevnZCwEB2nhHWUmEwPivYEF+hbegnWBGWfC//Z1dUa7BxXDEp h0qnc9GulmDvEMrDcFH/qN7AWFWIYnufC/GBQMQtgDIFW4hruW1mMOFZAY1vFNx5ZV8L FTfPIT+iRJ9EYwaWbZjGaiv1WdHWdthIuGnyf1s7kmvbYD77iqC+IQw54sSWRP9fz2QM IrxFIDUPRn7Y/ZYXjYluL4HA9nSJYM93NXWfFiMk9CnVYQ380MgsLKPM9YTt4+8OWG+U T9cy+gD7myuHY22w5IjmzY+GQ67ej4Z6pM06KLUmB4Vc/9NfB6bs3ySJtp/Kjlgf0jj5 SteA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=b3qQj4mXhxHuk7HUx8hKMYx+LaexHXIfoktLdRsumAQ=; b=Xqj8LE73nhcivibKhffBFSWvtPOXsSqKZX8PUgbQNgVtNzQLPZKTzsA/nKf4qQvC1I eoqmi0YAbiztYKE7VkCfniTfegrQV8jaC9kev/ogtUqXuu5OmA5nra4jSItu+AOkTzo8 Hia9hTQWQ3q0vX1foIpS9/WcP5sa16rt4hdQppd18pjcMUd2XJMXWF7KgbPnuz9w0q++ zpnnWFQUe9RhjTCB33YiAccTR3qKT5OYatnYtqyPDX/p3wcjrVt+YyXNpZ5bWYpT4lgK N160LMRtQXwknFm5EyrNFkv0tY9HGGnZZxpOXbuSFxBSv3KsvjUSJSUQASRABqjA5lLW rQRQ== X-Gm-Message-State: AHQUAuY7SOaqq/lcVi304LQP1vzEJvct7ipAuXCRtMWgK+r9spfqryyb 0fG2lEp+RqHe5SV8MX5lBFgj9HaFdwI= X-Google-Smtp-Source: AHgI3IZcAur4FikCpr2FJRhCmCi9XuPygUiDdFF5zPRo74Iv6fBBqj6rZy5nYiwLSnC0DmAIzojhWg== X-Received: by 2002:a62:3a01:: with SMTP id h1mr4733036pfa.169.1549990954509; Tue, 12 Feb 2019 09:02:34 -0800 (PST) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id y19sm15287314pfm.181.2019.02.12.09.02.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Feb 2019 09:02:33 -0800 (PST) Date: Tue, 12 Feb 2019 09:02:32 -0800 From: Stanislav Fomichev To: Alexei Starovoitov Cc: Willem de Bruijn , Stanislav Fomichev , Network Development , David Miller , Alexei Starovoitov , Daniel Borkmann , simon.horman@netronome.com, Willem de Bruijn Subject: Re: [RFC bpf-next 0/7] net: flow_dissector: trigger BPF hook when called from eth_get_headlen Message-ID: <20190212170232.GB10595@mini-arch> References: <20190205173629.160717-1-sdf@google.com> <20190205204003.GB10769@mini-arch> <20190206004714.pz44evow5uwgvt4x@ast-mbp.dhcp.thefacebook.com> <20190206005931.GF10769@mini-arch> <20190206031215.qldeh7pfgqr3frg3@ast-mbp> <20190206035619.GG10769@mini-arch> <20190206041112.h3ccahimp2uerdfk@ast-mbp> <20190206054946.GH10769@mini-arch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206054946.GH10769@mini-arch> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/05, Stanislav Fomichev wrote: > On 02/05, Alexei Starovoitov wrote: > > On Tue, Feb 05, 2019 at 07:56:19PM -0800, Stanislav Fomichev wrote: > > > On 02/05, Alexei Starovoitov wrote: > > > > On Tue, Feb 05, 2019 at 04:59:31PM -0800, Stanislav Fomichev wrote: > > > > > On 02/05, Alexei Starovoitov wrote: > > > > > > On Tue, Feb 05, 2019 at 12:40:03PM -0800, Stanislav Fomichev wrote: > > > > > > > On 02/05, Willem de Bruijn wrote: > > > > > > > > On Tue, Feb 5, 2019 at 12:57 PM Stanislav Fomichev wrote: > > > > > > > > > > > > > > > > > > Currently, when eth_get_headlen calls flow dissector, it doesn't pass any > > > > > > > > > skb. Because we use passed skb to lookup associated networking namespace > > > > > > > > > to find whether we have a BPF program attached or not, we always use > > > > > > > > > C-based flow dissector in this case. > > > > > > > > > > > > > > > > > > The goal of this patch series is to add new networking namespace argument > > > > > > > > > to the eth_get_headlen and make BPF flow dissector programs be able to > > > > > > > > > work in the skb-less case. > > > > > > > > > > > > > > > > > > The series goes like this: > > > > > > > > > 1. introduce __init_skb and __init_skb_shinfo; those will be used to > > > > > > > > > initialize temporary skb > > > > > > > > > 2. introduce skb_net which can be used to get networking namespace > > > > > > > > > associated with an skb > > > > > > > > > 3. add new optional network namespace argument to __skb_flow_dissect and > > > > > > > > > plumb through the callers > > > > > > > > > 4. add new __flow_bpf_dissect which constructs temporary on-stack skb > > > > > > > > > (using __init_skb) and calls BPF flow dissector program > > > > > > > > > > > > > > > > The main concern I see with this series is this cost of skb zeroing > > > > > > > > for every packet in the device driver receive routine, *independent* > > > > > > > > from the real skb allocation and zeroing which will likely happen > > > > > > > > later. > > > > > > > Yes, plus ~200 bytes on the stack for the callers. > > > > > > > > > > > > > > Not sure how visible this zeroing though, I can probably try to get some > > > > > > > numbers from BPF_PROG_TEST_RUN (running current version vs running with > > > > > > > on-stack skb). > > > > > > > > > > > > imo extra 256 byte memset for every packet is non starter. > > > > > We can put pre-allocated/initialized skbs without data into percpu or even > > > > > use pcpu_freelist_pop/pcpu_freelist_push to make sure we don't have to think > > > > > about having multiple percpu for irq/softirq/process contexts. > > > > > Any concerns with that approach? > > > > > Any other possible concerns with the overall series? > > > > > > > > I'm missing why the whole thing is needed. > > > > You're saying: > > > > " make BPF flow dissector programs be able to work in the skb-less case". > > > > What does it mean specifically? > > > > The only non-skb case is XDP. > > > > Are you saying you want flow_dissector prog to be run in XDP? > > > eth_get_headlen that drivers call on RX path on a chunk of data to > > > guesstimate the length of the headers calls flow dissector without an skb > > > (__skb_flow_dissect was a weird interface where it accepts skb or > > > data+len). Right now, there is no way to trigger BPF flow dissector > > > for this case (we don't have an skb to get associated namespace/etc/etc). > > > The patch series tries to fix that to make sure that we always trigger > > > BPF program if it's attached to a device's namespace. > > > > then why not to create flow_dissector prog type that works without skb? > > Why do you need to fake an skb? > > XDP progs work just fine without it. > What's the advantage of having another prog type? In this case we would have > to write the same flow dissector program twice: first time against __skb_buff > interface, second time against xdp_md. > By using fake skb, we make the same flow dissector __sk_buff BPF program > work in both contexts without a rewrite to an xdp interface (I don't > think users should care whether flow dissector was called form "xdp" vs skb > context; and we're sort of stuck with __sk_buff interface already). Should I follow up with v2 where I address memset(,,256) for each packet? Or you still have some questions/doubts/suggestions regarding the problem I'm trying to solve?