From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Trent Piepho <tpiepho@impinj.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH v3 3/4] rtc: isl1208: Add new style nvmem support to driver
Date: Wed, 13 Feb 2019 00:10:33 +0100 [thread overview]
Message-ID: <20190212231033.GE10129@piout.net> (raw)
In-Reply-To: <20190212023225.2710-3-tpiepho@impinj.com>
On 12/02/2019 02:34:05+0000, Trent Piepho wrote:
> Add support for the RTC's NVRAM using the standard nvmem support that is
> part of the Linux RTC framework.
>
> This driver already has a sysfs attribute that provides access to the
> RTC's NVRAM as a single 16-bit value. Some chips have more than two
> bytes of NVRAM, so this will not work for them. It's also non-standard.
>
> This sysfs attribute is left in for backward compatibility, but will only
> be able to read the first two bytes of NVRAM. The nvmem interface will
> allow access to all NVRAM, e.g. eight bytes on the isl1218.
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
> drivers/rtc/rtc-isl1208.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-02-12 23:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 2:34 [PATCH v3 1/4] rtc: isl1208: Introduce driver state struct Trent Piepho
2019-02-12 2:34 ` [PATCH v3 2/4] rtc: isl1208: Support more chip variations Trent Piepho
2019-02-12 23:10 ` Alexandre Belloni
2019-02-12 2:34 ` [PATCH v3 4/4] dt-bindings: rtc: Update for new chip in isl1208 series Trent Piepho
2019-02-12 23:10 ` Alexandre Belloni
2019-02-12 2:34 ` [PATCH v3 3/4] rtc: isl1208: Add new style nvmem support to driver Trent Piepho
2019-02-12 23:10 ` Alexandre Belloni [this message]
2019-02-12 23:10 ` [PATCH v3 1/4] rtc: isl1208: Introduce driver state struct Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212231033.GE10129@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=linux-rtc@vger.kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.