From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F478C282C2 for ; Wed, 13 Feb 2019 13:56:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45E3F207E0 for ; Wed, 13 Feb 2019 13:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388601AbfBMN42 (ORCPT ); Wed, 13 Feb 2019 08:56:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:37636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbfBMN41 (ORCPT ); Wed, 13 Feb 2019 08:56:27 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DDC3207E0; Wed, 13 Feb 2019 13:56:25 +0000 (UTC) Date: Wed, 13 Feb 2019 08:56:23 -0500 From: Steven Rostedt To: Lukasz Luba Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, b.zolnierkie@samsung.com, myungjoo.ham@samsung.com, cw00.choi@samsung.com, kyungmin.park@samsung.com, m.szyprowski@samsung.com, s.nawrocki@samsung.com, tkjos@google.com, joel@joelfernandes.org, chris.diamand@arm.com, mka@chromium.org, mingo@redhat.com Subject: Re: [PATCH v3 6/7] trace: events: add devfreq trace event file Message-ID: <20190213085623.660e19da@gandalf.local.home> In-Reply-To: <1550010238-24002-7-git-send-email-l.luba@partner.samsung.com> References: <1550010238-24002-1-git-send-email-l.luba@partner.samsung.com> <1550010238-24002-7-git-send-email-l.luba@partner.samsung.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Feb 2019 23:23:57 +0100 Lukasz Luba wrote: > The patch adds a new file for with trace events for devfreq > framework. They are used for performance analysis of the framework. > It also contains updates in MAINTAINERS file adding new entry for > devfreq maintainers. > > Signed-off-by: Lukasz Luba > --- > MAINTAINERS | 1 + > include/trace/events/devfreq.h | 39 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 include/trace/events/devfreq.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9919840..c042fda 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4447,6 +4447,7 @@ S: Maintained > F: drivers/devfreq/ > F: include/linux/devfreq.h > F: Documentation/devicetree/bindings/devfreq/ > +F: include/trace/events/devfreq.h > > DEVICE FREQUENCY EVENT (DEVFREQ-EVENT) > M: Chanwoo Choi > diff --git a/include/trace/events/devfreq.h b/include/trace/events/devfreq.h > new file mode 100644 > index 0000000..fec9304 > --- /dev/null > +++ b/include/trace/events/devfreq.h > @@ -0,0 +1,39 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM devfreq > + > +#if !defined(_TRACE_DEVFREQ_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_DEVFREQ_H > + > +#include > +#include > + > +TRACE_EVENT(devfreq_monitor, > + TP_PROTO(const char *dev_name, unsigned long freq, > + unsigned int polling_ms, unsigned long busy_time, > + unsigned long total_time), > + > + TP_ARGS(dev_name, freq, polling_ms, busy_time, total_time), > + > + TP_STRUCT__entry( > + __string(dev_name, dev_name) I would also put the string at the end. Strings are stored as a dynamic array in the event, where the position of __string() holds a 32 bit number. The 16 MSBs is the length of the string and the 16 LSBs is the offset into the trace event (after the TP_STRUCT__entry). That means on a 64 bit machine, there's a chance that this struct will have a 4 byte "hole" between the __string() meta data and the freq field. -- Steve > + __field(unsigned long, freq) > + __field(unsigned int, polling_ms) > + __field(unsigned int, load) > + ), > + > + TP_fast_assign( > + __assign_str(dev_name, dev_name); > + __entry->freq = freq; > + __entry->polling_ms = polling_ms; > + __entry->load = (100 * busy_time) / total_time; > + ), > + > + TP_printk("dev_name=%s freq=%lu polling_ms=%u load=%u", > + __get_str(dev_name), __entry->freq, __entry->polling_ms, > + __entry->load) > +); > +#endif /* _TRACE_DEVFREQ_H */ > + > +/* This part must be outside protection */ > +#include