From: Luca Boccassi <bluca@debian.org>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Luca Boccassi <bluca@debian.org>
Subject: [PATCH v7 1/5] build: bump minimum Meson version to 0.47.1
Date: Wed, 13 Feb 2019 11:54:48 +0000 [thread overview]
Message-ID: <20190213115452.2264-1-bluca@debian.org> (raw)
In-Reply-To: <20190103175725.5836-1-bluca@debian.org>
Meson 0.47.1 fixed a bug that is difficult to work around, which causes
the linker flag of dependencies to be repeated dozens of times, which
causes issues especially when using the built-in dependency() API.
Bump the minimum version and remove obsolete version checks.
Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: bump meson minimum version to 0.47.1 to avoid meson bug
v3: split away first independent patch from series
v4: add acked-by
drivers/meson.build | 5 +----
kernel/linux/meson.build | 6 +-----
meson.build | 35 +++++++++++++++--------------------
3 files changed, 17 insertions(+), 29 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index c3c66bbc0..e37d4fe2b 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -148,8 +148,5 @@ foreach class:driver_classes
endif # build
endforeach
- if meson.version().version_compare('>=0.47')
- # prior to 0.47, set_variable can't take array params
- set_variable(class + '_drivers', class_drivers)
- endif
+ set_variable(class + '_drivers', class_drivers)
endforeach
diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
index 5b7ec06e1..d751d939f 100644
--- a/kernel/linux/meson.build
+++ b/kernel/linux/meson.build
@@ -27,11 +27,7 @@ else
make_returncode = run_command('make', '-sC', kernel_dir,
'kernelversion').returncode()
if make_returncode != 0
- if meson.version().version_compare('>=0.44')
- warning(WARN_NO_HEADERS)
- else
- message('WARNING: ' + WARN_NO_HEADERS)
- endif
+ warning(WARN_NO_HEADERS)
else # returncode == 0
# DO ACTUAL MODULE BUILDING
diff --git a/meson.build b/meson.build
index 7f5e8674b..e9793b127 100644
--- a/meson.build
+++ b/meson.build
@@ -5,7 +5,7 @@ project('DPDK', 'C',
version: '19.05.0-rc0',
license: 'BSD',
default_options: ['buildtype=release', 'default_library=static'],
- meson_version: '>= 0.41'
+ meson_version: '>= 0.47.1'
)
# set up some global vars for compiler, platform, configuration, etc.
@@ -105,23 +105,18 @@ foreach lib:enabled_libs
endforeach
message(output_message + '\n')
-
-# prior to 0.47 set_variable didn't work with arrays, so we can't
-# track driver lists easily
-if meson.version().version_compare('>=0.47')
- output_message = '\n===============\nDrivers Enabled\n===============\n'
- foreach class:driver_classes
- class_drivers = get_variable(class + '_drivers')
- output_message += '\n' + class + ':\n\t'
- output_count = 0
- foreach drv:class_drivers
- output_message += drv + ', '
- output_count += 1
- if output_count == 8
- output_message += '\n\t'
- output_count = 0
- endif
- endforeach
+output_message = '\n===============\nDrivers Enabled\n===============\n'
+foreach class:driver_classes
+ class_drivers = get_variable(class + '_drivers')
+ output_message += '\n' + class + ':\n\t'
+ output_count = 0
+ foreach drv:class_drivers
+ output_message += drv + ', '
+ output_count += 1
+ if output_count == 8
+ output_message += '\n\t'
+ output_count = 0
+ endif
endforeach
- message(output_message + '\n')
-endif
+endforeach
+message(output_message + '\n')
--
2.20.1
next prev parent reply other threads:[~2019-02-13 11:55 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 17:57 [PATCH 1/2] build: use static deps of libs for pkg-config libs.private Luca Boccassi
2019-01-03 17:57 ` [PATCH 2/2] build: use dependency() instead of find_library() Luca Boccassi
2019-01-07 14:28 ` Bruce Richardson
2019-01-07 16:39 ` [dpdk-stable] " Luca Boccassi
2019-01-07 16:55 ` Bruce Richardson
2019-01-07 17:03 ` [dpdk-techboard] " Thomas Monjalon
2019-01-07 17:45 ` [dpdk-stable] [dpdk-techboard] " Thomas Monjalon
2019-01-07 21:09 ` Luca Boccassi
2019-01-07 22:03 ` Luca Boccassi
2019-01-11 11:10 ` [dpdk-stable] " Luca Boccassi
2019-01-11 11:52 ` Bruce Richardson
2019-01-11 12:39 ` Luca Boccassi
2019-01-11 14:24 ` Bruce Richardson
2019-01-11 14:56 ` Luca Boccassi
2019-01-11 15:49 ` Bruce Richardson
2019-01-11 16:27 ` Luca Boccassi
2019-01-11 12:38 ` [PATCH v2 1/3] build: use static deps of libs for pkg-config libs.private Luca Boccassi
2019-01-11 12:38 ` [PATCH v2 2/3] build: use dependency() instead of find_library() Luca Boccassi
2019-01-11 12:38 ` [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd Luca Boccassi
2019-01-11 14:27 ` Bruce Richardson
2019-01-11 14:30 ` Bruce Richardson
2019-01-11 15:04 ` Luca Boccassi
2019-01-11 15:50 ` Bruce Richardson
2019-01-11 16:14 ` Luca Boccassi
2019-01-11 16:26 ` [PATCH v3 1/4] build: bump minimum Meson version to 0.47.1 Luca Boccassi
2019-01-11 16:26 ` [PATCH v3 2/4] build: use dependency() instead of find_library() Luca Boccassi
2019-01-11 17:21 ` Bruce Richardson
2019-01-11 18:16 ` Luca Boccassi
2019-01-11 21:49 ` Bruce Richardson
2019-01-11 16:26 ` [PATCH v3 3/4] build: reorder libraries and build eal before cmdline Luca Boccassi
2019-01-11 17:22 ` Bruce Richardson
2019-01-11 16:26 ` [PATCH v3 4/4] build: use dependency() for libbsd instead of manual append to ldflags Luca Boccassi
2019-01-11 17:24 ` Bruce Richardson
2019-01-11 17:17 ` [PATCH v3 1/4] build: bump minimum Meson version to 0.47.1 Bruce Richardson
2019-01-11 18:22 ` [PATCH v4 " Luca Boccassi
2019-01-11 18:22 ` [PATCH v4 2/4] build: use dependency() instead of find_library() Luca Boccassi
2019-01-11 18:22 ` [PATCH v4 3/4] build: reorder libraries and build eal before cmdline Luca Boccassi
2019-01-11 18:22 ` [PATCH v4 4/4] build: use dependency() for libbsd instead of manual append to ldflags Luca Boccassi
2019-01-22 13:10 ` [PATCH v5 1/4] build: bump minimum Meson version to 0.47.1 Luca Boccassi
2019-01-22 13:10 ` [PATCH v5 2/4] build: use dependency() instead of find_library() Luca Boccassi
2019-01-22 13:46 ` Bruce Richardson
2019-01-22 14:09 ` Luca Boccassi
2019-01-22 14:24 ` Bruce Richardson
2019-01-22 14:25 ` Bruce Richardson
2019-01-22 13:10 ` [PATCH v5 3/4] build: reorder libraries and build eal before cmdline Luca Boccassi
2019-01-22 13:10 ` [PATCH v5 4/4] build: use dependency() for libbsd instead of manual append to ldflags Luca Boccassi
2019-01-22 13:42 ` [PATCH v5 1/4] build: bump minimum Meson version to 0.47.1 Bruce Richardson
2019-02-06 17:08 ` [PATCH v6 1/5] " Luca Boccassi
2019-02-06 17:08 ` [PATCH v6 2/5] build: use dependency() instead of find_library() Luca Boccassi
2019-02-12 11:15 ` Thomas Monjalon
2019-02-12 11:31 ` Bruce Richardson
2019-02-12 11:36 ` Thomas Monjalon
2019-02-12 11:43 ` Bruce Richardson
2019-02-12 14:47 ` Thomas Monjalon
2019-02-12 15:03 ` Bruce Richardson
2019-02-12 16:21 ` Thomas Monjalon
2019-02-13 10:49 ` Luca Boccassi
2019-02-13 11:10 ` Thomas Monjalon
2019-02-13 13:45 ` Luca Boccassi
2019-02-13 11:48 ` Luca Boccassi
2019-02-06 17:08 ` [PATCH v6 3/5] build: reorder libraries and build eal before cmdline Luca Boccassi
2019-02-06 17:08 ` [PATCH v6 4/5] build: use dependency() for libbsd instead of manual append to ldflags Luca Boccassi
2019-02-06 17:08 ` [PATCH v6 5/5] build: use integers for numerical options Luca Boccassi
2019-02-08 14:44 ` Bruce Richardson
2019-02-13 11:54 ` Luca Boccassi [this message]
2019-02-13 11:54 ` [PATCH v7 2/5] build: use dependency() instead of find_library() Luca Boccassi
2019-02-13 15:35 ` Bruce Richardson
2019-02-13 11:54 ` [PATCH v7 3/5] build: reorder libraries and build eal before cmdline Luca Boccassi
2019-02-13 11:54 ` [PATCH v7 4/5] build: use dependency() for libbsd instead of manual append to ldflags Luca Boccassi
2019-02-13 11:54 ` [PATCH v7 5/5] build: use integers for numerical options Luca Boccassi
2019-02-26 17:46 ` [PATCH v8 1/6] build: bump minimum Meson version to 0.47.1 luca.boccassi
2019-02-26 17:46 ` [PATCH v8 2/6] build: use dependency() instead of find_library() luca.boccassi
2019-02-26 17:46 ` [PATCH v8 3/6] build: reorder libraries and build eal before cmdline luca.boccassi
2019-02-26 17:46 ` [PATCH v8 4/6] build: use dependency() for libbsd instead of manual append to ldflags luca.boccassi
2019-02-26 17:46 ` [PATCH v8 5/6] build: use integers for numerical options luca.boccassi
2019-02-26 17:46 ` [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library luca.boccassi
2019-02-26 17:49 ` Luca Boccassi
2019-02-27 8:33 ` Thomas Monjalon
2019-02-27 9:47 ` Bruce Richardson
2019-02-27 10:50 ` Luca Boccassi
2019-02-27 10:56 ` Thomas Monjalon
2019-02-27 12:03 ` Luca Boccassi
2019-02-27 13:53 ` Bruce Richardson
2019-02-28 17:40 ` Bruce Richardson
2019-03-01 13:13 ` Thomas Monjalon
2019-03-01 15:13 ` Luca Boccassi
2019-03-01 13:22 ` Thomas Monjalon
2019-02-27 11:29 ` [PATCH v8 1/6] build: bump minimum Meson version to 0.47.1 Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213115452.2264-1-bluca@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.