From: Matthew Wilcox <willy@infradead.org>
To: Roman Gushchin <guro@fb.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guroan@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Kernel Team <Kernel-team@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] vmalloc enhancements
Date: Wed, 13 Feb 2019 12:26:15 -0800 [thread overview]
Message-ID: <20190213202614.GV12668@bombadil.infradead.org> (raw)
In-Reply-To: <20190212223605.GA15979@tower.DHCP.thefacebook.com>
On Tue, Feb 12, 2019 at 10:36:12PM +0000, Roman Gushchin wrote:
> On Tue, Feb 12, 2019 at 12:34:09PM -0800, Andrew Morton wrote:
> > On Tue, 12 Feb 2019 13:47:24 -0500 Johannes Weiner <hannes@cmpxchg.org> wrote:
> > > I don't understand what prompted this change to percpu counters.
>
> I *think*, I see some performance difference, but it's barely measurable
> in my setup. Also as I remember, Matthew was asking why not percpu here.
> So if everybody prefers a global atomic, I'm fine with either.
I was asking why you were using an accessor instead of a direct reference
to the atomic_long_t.
next prev parent reply other threads:[~2019-02-13 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 17:56 [PATCH v2 0/3] vmalloc enhancements Roman Gushchin
2019-02-12 17:56 ` [PATCH v2 1/3] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Roman Gushchin
2019-02-12 17:56 ` [PATCH v2 2/3] mm: separate memory allocation and actual work in alloc_vmap_area() Roman Gushchin
2019-02-12 17:56 ` [PATCH v2 3/3] mm: show number of vmalloc pages in /proc/meminfo Roman Gushchin
2019-02-12 18:47 ` [PATCH v2 0/3] vmalloc enhancements Johannes Weiner
2019-02-12 20:34 ` Andrew Morton
2019-02-12 22:36 ` Roman Gushchin
2019-02-13 20:26 ` Matthew Wilcox [this message]
2019-02-14 0:38 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213202614.GV12668@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=guroan@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.