All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] configs/orangepi_one_plus: fix kernel headers option
@ 2019-02-13 21:10 Thomas Petazzoni
  2019-02-14 20:48 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2019-02-13 21:10 UTC (permalink / raw)
  To: buildroot

Contrary to what the comment in the defconfig says, the
orangepi_one_plus_defconfig was not using the "same as kernel" option
for kernel headers, but really selecting explicitly Linux 4.18
headers, independently from the kernel version.

Except that in the mean time, BR2_KERNEL_HEADERS_4_18 has been
removed, causing a build failure due to the legacy checking:

Makefile.legacy:9: *** "You have legacy configuration in your .config! Please check your configuration.".  Stop.

This commit fixes that by using the proper
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_18 option.

Fixes:

  https://gitlab.com/buildroot.org/buildroot/-/jobs/158295166

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 configs/orangepi_one_plus_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/orangepi_one_plus_defconfig b/configs/orangepi_one_plus_defconfig
index d950f16610..30c422efc2 100644
--- a/configs/orangepi_one_plus_defconfig
+++ b/configs/orangepi_one_plus_defconfig
@@ -3,7 +3,7 @@ BR2_cortex_a53=y
 BR2_ARM_FPU_VFPV4=y
 
 # Linux headers same as kernel, a 4.18 series
-BR2_KERNEL_HEADERS_4_18=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_18=y
 
 # Firmware
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] configs/orangepi_one_plus: fix kernel headers option
  2019-02-13 21:10 [Buildroot] [PATCH] configs/orangepi_one_plus: fix kernel headers option Thomas Petazzoni
@ 2019-02-14 20:48 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2019-02-14 20:48 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Contrary to what the comment in the defconfig says, the
 > orangepi_one_plus_defconfig was not using the "same as kernel" option
 > for kernel headers, but really selecting explicitly Linux 4.18
 > headers, independently from the kernel version.

 > Except that in the mean time, BR2_KERNEL_HEADERS_4_18 has been
 > removed, causing a build failure due to the legacy checking:

 > Makefile.legacy:9: *** "You have legacy configuration in your .config! Please check your configuration.".  Stop.

 > This commit fixes that by using the proper
 > BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_18 option.

 > Fixes:

 >   https://gitlab.com/buildroot.org/buildroot/-/jobs/158295166

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-14 20:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 21:10 [Buildroot] [PATCH] configs/orangepi_one_plus: fix kernel headers option Thomas Petazzoni
2019-02-14 20:48 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.