From: Stefano Brivio <sbrivio@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2 net-next v2 3/4] ss: Buffer raw fields first, then render them as a table
Date: Wed, 13 Feb 2019 23:20:47 +0100 [thread overview]
Message-ID: <20190213232047.4b7c2f08@redhat.com> (raw)
In-Reply-To: <20190213135534.01dacee5@shemminger-XPS-13-9360>
On Wed, 13 Feb 2019 13:55:34 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:
> What I would favor:
> * use big enough columns that for the common case everything lines up fine
> * if column is to wide just print that element wider (which is what print %Ns does)
This is very close to what was done before, but as soon as you mix,
say, UNIX sockets with TCP sockets, "big enough" columns typically make
output for TCP sockets unreadable.
With buffering, instead, I can decide that a line split is needed, and
keep fields aligned no matter what.
> and
> * add json output for programs that want to parse
> * use print_uint etc for that
Sure, I think we all agree with this, but it's not going to be quick to
implement (even though it's perhaps a bit easier with abstracted columns
and buffering). Eric reported a problem and I'm trying to fix it
quickly.
> The buffering patch (in iproute2-next) can/will be reverted.
I think it received generally good feedback (also from users, later on)
and this is the first report of a serious issue -- it's also an issue
which looks easy to fix (I'm half way through that by now).
By the way, this patch was merged in iproute2 more than one year ago
(December 2017, by you).
--
Stefano
next prev parent reply other threads:[~2019-02-13 22:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 0:46 [PATCH iproute2 net-next v2 0/4] Abstract columns, properly space and wrap fields Stefano Brivio
2017-12-12 0:46 ` [PATCH iproute2 net-next v2 1/4] ss: Replace printf() calls for "main" output by calls to helper Stefano Brivio
2017-12-12 0:46 ` [PATCH iproute2 net-next v2 2/4] ss: Introduce columns lightweight abstraction Stefano Brivio
2017-12-12 0:46 ` [PATCH iproute2 net-next v2 3/4] ss: Buffer raw fields first, then render them as a table Stefano Brivio
2019-02-13 0:42 ` Eric Dumazet
2019-02-13 8:37 ` Stefano Brivio
2019-02-13 16:51 ` Stephen Hemminger
2019-02-13 17:22 ` Stefano Brivio
2019-02-13 17:32 ` Eric Dumazet
2019-02-13 17:31 ` Eric Dumazet
2019-02-13 17:38 ` Stefano Brivio
2019-02-13 18:01 ` Eric Dumazet
2019-02-13 21:17 ` Stefano Brivio
2019-02-13 21:55 ` Stephen Hemminger
2019-02-13 22:20 ` Stefano Brivio [this message]
2019-02-13 23:39 ` Phil Sutter
2019-02-13 23:47 ` David Ahern
2017-12-12 0:46 ` [PATCH iproute2 net-next v2 4/4] ss: Implement automatic column width calculation Stefano Brivio
2017-12-12 20:13 ` [PATCH iproute2 net-next v2 0/4] Abstract columns, properly space and wrap fields Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213232047.4b7c2f08@redhat.com \
--to=sbrivio@redhat.com \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.