From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode
Date: Thu, 14 Feb 2019 08:38:28 -0800 (PST)
Message-ID: <20190214.083828.206479765039661735.davem@davemloft.net>
References: <20190212141922.12849-1-vkoul@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <netdev-owner@vger.kernel.org>
In-Reply-To: <20190212141922.12849-1-vkoul@kernel.org>
Sender: netdev-owner@vger.kernel.org
To: vkoul@kernel.org
Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, niklas.cassel@linaro.org, andrew@lunn.ch, f.fainelli@gmail.com, nsekhar@ti.com, peter.ujfalusi@ti.com, marc.w.gonzalez@free.fr
List-Id: linux-arm-msm@vger.kernel.org

From: Vinod Koul <vkoul@kernel.org>
Date: Tue, 12 Feb 2019 19:49:22 +0530

> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 8ff12938ab47..7b54b54e3316 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -110,6 +110,18 @@ static int at803x_debug_reg_mask(struct phy_device *phydev, u16 reg,
>  	return phy_write(phydev, AT803X_DEBUG_DATA, val);
>  }
>  
> +static inline int at803x_enable_rx_delay(struct phy_device *phydev)
> +{
> +	return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_0, 0,
> +				     AT803X_DEBUG_RX_CLK_DLY_EN);
> +}
> +
> +static inline int at803x_enable_tx_delay(struct phy_device *phydev)
> +{
> +	return at803x_debug_reg_mask(phydev, AT803X_DEBUG_REG_5, 0,
> +				     AT803X_DEBUG_TX_CLK_DLY_EN);
> +}
> +

Please do not use the inline directive in foo.c files, let the compiler
decide.

Thank you.