From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79033C43381 for ; Mon, 18 Feb 2019 14:11:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4947021905 for ; Mon, 18 Feb 2019 14:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550499099; bh=xpct5DzxfTsrROJlZNKXr1On6NNWr08pQlk5ygxZXj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zc0/SIr0BvIR1SZOw4cMEHcB5wNskZrzdGWJNBkDjmQ4NJpW4wNkSMZLjTCiZC1ol LmX3FaxZkEScBPmbn65vWFvq17Tr3XcRaBo6nPugpcuVdSLfmRhiLj0ymxmT+EaIgl KG9rHhjjvDrfQwx/Why9ZiHlDJuqVpv5WJop2aOY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390661AbfBROLi (ORCPT ); Mon, 18 Feb 2019 09:11:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:55692 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391701AbfBROLf (ORCPT ); Mon, 18 Feb 2019 09:11:35 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20E4E217D9; Mon, 18 Feb 2019 14:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550499094; bh=xpct5DzxfTsrROJlZNKXr1On6NNWr08pQlk5ygxZXj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i9TYZSEgQRVS5lQoJyNki5GzP5356+1oBsBeXNCFKUf19uCG4slo1zLxFXJtMM0dc AglHjK1qVib/G9uCP0Eqha1f8peNZX8RzYpuWQW9ZD0yw31OHXCaeqGTQicgH1Hh/F /kGPdQGTfu7XTRc/VF7IxIekFcrfggzfz3n5f2r4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Jens Axboe , Sasha Levin Subject: [PATCH 3.18 051/108] gdrom: fix a memory leak bug Date: Mon, 18 Feb 2019 14:43:47 +0100 Message-Id: <20190218133521.881963629@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133519.525507231@linuxfoundation.org> References: <20190218133519.525507231@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 093c48213ee37c3c3ff1cf5ac1aa2a9d8bc66017 ] In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through kzalloc() and is used to hold the information of the gdrom device. To register and unregister the device, the pointer 'gd.cd_info' is passed to the functions register_cdrom() and unregister_cdrom(), respectively. However, this buffer is not freed after it is used, which can cause a memory leak bug. This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the above issue. Signed-off-by: Wenwen Wang Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/cdrom/gdrom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c index e2808fefbb78..1852d19d0d7b 100644 --- a/drivers/cdrom/gdrom.c +++ b/drivers/cdrom/gdrom.c @@ -882,6 +882,7 @@ static void __exit exit_gdrom(void) platform_device_unregister(pd); platform_driver_unregister(&gdrom_driver); kfree(gd.toc); + kfree(gd.cd_info); } module_init(init_gdrom); -- 2.19.1