From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B598C43381 for ; Mon, 18 Feb 2019 16:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C6A8214DA for ; Mon, 18 Feb 2019 16:26:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389064AbfBRQ0S (ORCPT ); Mon, 18 Feb 2019 11:26:18 -0500 Received: from muru.com ([72.249.23.125]:39312 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731218AbfBRQ0R (ORCPT ); Mon, 18 Feb 2019 11:26:17 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D65D380E4; Mon, 18 Feb 2019 16:26:26 +0000 (UTC) Date: Mon, 18 Feb 2019 08:26:13 -0800 From: Tony Lindgren To: Peter Ujfalusi Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com, grygorii.strashko@ti.com, vkoul@kernel.org, netdev@vger.kernel.org, f.fainelli@gmail.com, marc.w.gonzalez@free.fr, niklas.cassel@linaro.org Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet Message-ID: <20190218162613.GH15711@atomide.com> References: <20190218143629.28392-1-peter.ujfalusi@ti.com> <20190218144430.GE15711@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org * Peter Ujfalusi [190218 16:22]: > > > On 18/02/2019 16.44, Tony Lindgren wrote: > > * Peter Ujfalusi [190218 14:36]: > >> Hi, > >> > >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the > >> ethernet networking on evmsk (and most likely on the evm as well): > >> https://patchwork.ozlabs.org/patch/1028527/ > >> > >> v1 patch to fix the situation: > >> https://patchwork.ozlabs.org/patch/1040617/ > >> > >> It turned out that the at803x driver is actually broken and need to be fixed > >> along with the DT data. > >> > >> The following series is proposed to fix the driver: > >> https://patchwork.ozlabs.org/project/netdev/list/?series=92611 > >> > >> but the PHT mode needs to be switched to rgmii-id from rgmii-txid: > >> The rx delay is enabled by default and the driver never disabled it so when > >> asking rgmii-txid it actually got rgmii-id. > >> > >> The patch can be backported to stable, I have tested that it is not causing > >> regression with the old, broken driver. > > > > Can the dts changes be merged before the driver changes or > > does it cause the phy to stop working? > > The phy is not working atm, but this change will not cause regression > even if it is merged first. OK so sounds like these are OK to wait for v5.1 merge window then as the dts changes alone won't fix anything? Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6062C43381 for ; Mon, 18 Feb 2019 16:26:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71218214DA for ; Mon, 18 Feb 2019 16:26:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p0CZtSm5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71218214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qkc9kcQxloTKcWVJ0/OvfeUsTszumshhujAvDxgoEQc=; b=p0CZtSm5/SmRcG jEuuEIUlEKRKhKtnhBgsf3MbNXqR7FN63rzNhSenWcg60FqD96pCyqN+g1+f0sDIIcu0LvV1UL/cb KizsvTwSrhBdsEF/nTSKAZLmDOIMcU+amGnz/hveUi9Gu0lAyWTOzy33lIUir9FXMrfidMJ/uZ+p3 +TtwjimocHaeKOz4EF9W2UDntloUuIrp4TJmbDmsTFl6mX8RsSkN5bebxMoydZ5QWcEUjZd1zIvF1 O6TXF0VCKkcySAiSdVJqnXjA9DDxFegggVrdNkOz3MOf9TehSkJKd60xk/F2UkFooAZEWP7KvXeUh n/LhF3yj3zNvjihiWRfA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvlkM-0005RJ-Dj; Mon, 18 Feb 2019 16:26:22 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvlkI-0005QE-C2 for linux-arm-kernel@lists.infradead.org; Mon, 18 Feb 2019 16:26:20 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D65D380E4; Mon, 18 Feb 2019 16:26:26 +0000 (UTC) Date: Mon, 18 Feb 2019 08:26:13 -0800 From: Tony Lindgren To: Peter Ujfalusi Subject: Re: [PATCH 0/2] ARM: dts: am335x-evm/evmsk: Fix PHY mode for ethernet Message-ID: <20190218162613.GH15711@atomide.com> References: <20190218143629.28392-1-peter.ujfalusi@ti.com> <20190218144430.GE15711@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190218_082618_446912_B45E4B30 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, grygorii.strashko@ti.com, marc.w.gonzalez@free.fr, netdev@vger.kernel.org, nsekhar@ti.com, vkoul@kernel.org, f.fainelli@gmail.com, bcousson@baylibre.com, niklas.cassel@linaro.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Peter Ujfalusi [190218 16:22]: > > > On 18/02/2019 16.44, Tony Lindgren wrote: > > * Peter Ujfalusi [190218 14:36]: > >> Hi, > >> > >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the > >> ethernet networking on evmsk (and most likely on the evm as well): > >> https://patchwork.ozlabs.org/patch/1028527/ > >> > >> v1 patch to fix the situation: > >> https://patchwork.ozlabs.org/patch/1040617/ > >> > >> It turned out that the at803x driver is actually broken and need to be fixed > >> along with the DT data. > >> > >> The following series is proposed to fix the driver: > >> https://patchwork.ozlabs.org/project/netdev/list/?series=92611 > >> > >> but the PHT mode needs to be switched to rgmii-id from rgmii-txid: > >> The rx delay is enabled by default and the driver never disabled it so when > >> asking rgmii-txid it actually got rgmii-id. > >> > >> The patch can be backported to stable, I have tested that it is not causing > >> regression with the old, broken driver. > > > > Can the dts changes be merged before the driver changes or > > does it cause the phy to stop working? > > The phy is not working atm, but this change will not cause regression > even if it is merged first. OK so sounds like these are OK to wait for v5.1 merge window then as the dts changes alone won't fix anything? Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel