From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, imammedo@redhat.com,
xiaoguangrong.eric@gmail.com,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable
Date: Tue, 19 Feb 2019 14:07:18 +0800 [thread overview]
Message-ID: <20190219060719.8211-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190219060719.8211-1-richardw.yang@linux.intel.com>
Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM,
which is hotpluggable. This means it is not necessary to check this
property again.
This patch removes this check.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
hw/acpi/memory_hotplug.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
index 8c7c1013f3..b19673d337 100644
--- a/hw/acpi/memory_hotplug.c
+++ b/hw/acpi/memory_hotplug.c
@@ -266,10 +266,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, MemHotplugState *mem_st,
MemStatus *mdev;
DeviceClass *dc = DEVICE_GET_CLASS(dev);
- if (!dc->hotpluggable) {
- return;
- }
-
mdev = acpi_memory_slot_status(mem_st, dev, errp);
if (!mdev) {
return;
--
2.19.1
next prev parent reply other threads:[~2019-02-19 6:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 6:07 [Qemu-devel] [PATCH 0/2] PCDIMM cleanup Wei Yang
2019-02-19 6:07 ` Wei Yang [this message]
2019-02-19 12:26 ` [Qemu-devel] [PATCH 1/2] pc-dimm: remove check on pc-dimm hotpluggable Philippe Mathieu-Daudé
2019-02-21 14:30 ` Igor Mammedov
2019-02-19 12:29 ` Philippe Mathieu-Daudé
2019-02-19 13:02 ` Wei Yang
2019-02-19 6:07 ` [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback Wei Yang
2019-02-19 12:36 ` Philippe Mathieu-Daudé
2019-02-19 13:05 ` Wei Yang
2019-02-21 14:37 ` Igor Mammedov
2019-02-22 8:17 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219060719.8211-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.