From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74001C43381 for ; Tue, 19 Feb 2019 06:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E60B21848 for ; Tue, 19 Feb 2019 06:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbfBSG6N (ORCPT ); Tue, 19 Feb 2019 01:58:13 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:53378 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725764AbfBSG6N (ORCPT ); Tue, 19 Feb 2019 01:58:13 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 86131F2B57E038825E13; Tue, 19 Feb 2019 14:58:10 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.408.0; Tue, 19 Feb 2019 14:58:03 +0800 From: YueHaibing To: , CC: , , YueHaibing Subject: [PATCH -next] usb: typec: mux: Fix unsigned comparison with less than zero Date: Tue, 19 Feb 2019 14:57:50 +0800 Message-ID: <20190219065750.9004-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return from the call to fwnode_property_read_u16_array is int, it can be a negative error code however this is being assigned to an size_t variable 'nval', hence the check is always false. Fix this by making 'nval' an int. Detected by Coccinelle ("Unsigned expression compared with zero: nval < 0") Fixes: 96a6d031ca99 ("usb: typec: mux: Find the muxes by also matching against the device node") Signed-off-by: YueHaibing --- drivers/usb/typec/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c index a5947d9..54d7497 100644 --- a/drivers/usb/typec/mux.c +++ b/drivers/usb/typec/mux.c @@ -126,7 +126,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data) { const struct typec_altmode_desc *desc = data; struct typec_mux *mux; - size_t nval; + int nval; bool match; u16 *val; int i; -- 2.7.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] usb: typec: mux: Fix unsigned comparison with less than zero From: YueHaibing Message-Id: <20190219065750.9004-1-yuehaibing@huawei.com> Date: Tue, 19 Feb 2019 14:57:50 +0800 To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, YueHaibing List-ID: VGhlIHJldHVybiBmcm9tIHRoZSBjYWxsIHRvIGZ3bm9kZV9wcm9wZXJ0eV9yZWFkX3UxNl9hcnJh eSBpcyBpbnQsIAppdCBjYW4gYmUgYSBuZWdhdGl2ZSBlcnJvciBjb2RlIGhvd2V2ZXIgdGhpcyBp cyBiZWluZyBhc3NpZ25lZCB0bwphbiBzaXplX3QgdmFyaWFibGUgJ252YWwnLCBoZW5jZSB0aGUg Y2hlY2sgaXMgYWx3YXlzIGZhbHNlLgpGaXggdGhpcyBieSBtYWtpbmcgJ252YWwnIGFuIGludC4K CkRldGVjdGVkIGJ5IENvY2NpbmVsbGUgKCJVbnNpZ25lZCBleHByZXNzaW9uIGNvbXBhcmVkIHdp dGgKemVybzogbnZhbCA8IDAiKQoKRml4ZXM6IDk2YTZkMDMxY2E5OSAoInVzYjogdHlwZWM6IG11 eDogRmluZCB0aGUgbXV4ZXMgYnkgYWxzbyBtYXRjaGluZyBhZ2FpbnN0IHRoZSBkZXZpY2Ugbm9k ZSIpClNpZ25lZC1vZmYtYnk6IFl1ZUhhaWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNvbT4KLS0t CiBkcml2ZXJzL3VzYi90eXBlYy9tdXguYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3R5cGVjL211 eC5jIGIvZHJpdmVycy91c2IvdHlwZWMvbXV4LmMKaW5kZXggYTU5NDdkOS4uNTRkNzQ5NyAxMDA2 NDQKLS0tIGEvZHJpdmVycy91c2IvdHlwZWMvbXV4LmMKKysrIGIvZHJpdmVycy91c2IvdHlwZWMv bXV4LmMKQEAgLTEyNiw3ICsxMjYsNyBAQCBzdGF0aWMgdm9pZCAqdHlwZWNfbXV4X21hdGNoKHN0 cnVjdCBkZXZpY2VfY29ubmVjdGlvbiAqY29uLCBpbnQgZXAsIHZvaWQgKmRhdGEpCiB7CiAJY29u c3Qgc3RydWN0IHR5cGVjX2FsdG1vZGVfZGVzYyAqZGVzYyA9IGRhdGE7CiAJc3RydWN0IHR5cGVj X211eCAqbXV4OwotCXNpemVfdCBudmFsOworCWludCBudmFsOwogCWJvb2wgbWF0Y2g7CiAJdTE2 ICp2YWw7CiAJaW50IGk7Cg==