From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ADABC43381 for ; Tue, 19 Feb 2019 07:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 248F221904 for ; Tue, 19 Feb 2019 07:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbfBSHsL (ORCPT ); Tue, 19 Feb 2019 02:48:11 -0500 Received: from mga01.intel.com ([192.55.52.88]:22919 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727233AbfBSHsK (ORCPT ); Tue, 19 Feb 2019 02:48:10 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 23:48:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,387,1544515200"; d="scan'208";a="147957512" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 18 Feb 2019 23:48:07 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 19 Feb 2019 09:48:06 +0200 Date: Tue, 19 Feb 2019 09:48:06 +0200 From: Heikki Krogerus To: YueHaibing Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH -next] usb: typec: mux: Fix unsigned comparison with less than zero Message-ID: <20190219074806.GC1626@kuha.fi.intel.com> References: <20190219065750.9004-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190219065750.9004-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 02:57:50PM +0800, YueHaibing wrote: > The return from the call to fwnode_property_read_u16_array is int, > it can be a negative error code however this is being assigned to > an size_t variable 'nval', hence the check is always false. > Fix this by making 'nval' an int. > > Detected by Coccinelle ("Unsigned expression compared with > zero: nval < 0") > > Fixes: 96a6d031ca99 ("usb: typec: mux: Find the muxes by also matching against the device node") > Signed-off-by: YueHaibing Acked-by: Heikki Krogerus > --- > drivers/usb/typec/mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c > index a5947d9..54d7497 100644 > --- a/drivers/usb/typec/mux.c > +++ b/drivers/usb/typec/mux.c > @@ -126,7 +126,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data) > { > const struct typec_altmode_desc *desc = data; > struct typec_mux *mux; > - size_t nval; > + int nval; > bool match; > u16 *val; > int i; thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] usb: typec: mux: Fix unsigned comparison with less than zero From: Heikki Krogerus Message-Id: <20190219074806.GC1626@kuha.fi.intel.com> Date: Tue, 19 Feb 2019 09:48:06 +0200 To: YueHaibing Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gVHVlLCBGZWIgMTksIDIwMTkgYXQgMDI6NTc6NTBQTSArMDgwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBUaGUgcmV0dXJuIGZyb20gdGhlIGNhbGwgdG8gZndub2RlX3Byb3BlcnR5X3JlYWRfdTE2 X2FycmF5IGlzIGludCwgCj4gaXQgY2FuIGJlIGEgbmVnYXRpdmUgZXJyb3IgY29kZSBob3dldmVy IHRoaXMgaXMgYmVpbmcgYXNzaWduZWQgdG8KPiBhbiBzaXplX3QgdmFyaWFibGUgJ252YWwnLCBo ZW5jZSB0aGUgY2hlY2sgaXMgYWx3YXlzIGZhbHNlLgo+IEZpeCB0aGlzIGJ5IG1ha2luZyAnbnZh bCcgYW4gaW50Lgo+IAo+IERldGVjdGVkIGJ5IENvY2NpbmVsbGUgKCJVbnNpZ25lZCBleHByZXNz aW9uIGNvbXBhcmVkIHdpdGgKPiB6ZXJvOiBudmFsIDwgMCIpCj4gCj4gRml4ZXM6IDk2YTZkMDMx Y2E5OSAoInVzYjogdHlwZWM6IG11eDogRmluZCB0aGUgbXV4ZXMgYnkgYWxzbyBtYXRjaGluZyBh Z2FpbnN0IHRoZSBkZXZpY2Ugbm9kZSIpCj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8eXVl aGFpYmluZ0BodWF3ZWkuY29tPgoKQWNrZWQtYnk6IEhlaWtraSBLcm9nZXJ1cyA8aGVpa2tpLmty b2dlcnVzQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvdXNiL3R5cGVjL211eC5j IHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvdHlwZWMvbXV4LmMgYi9kcml2ZXJzL3VzYi90 eXBlYy9tdXguYwo+IGluZGV4IGE1OTQ3ZDkuLjU0ZDc0OTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy91c2IvdHlwZWMvbXV4LmMKPiArKysgYi9kcml2ZXJzL3VzYi90eXBlYy9tdXguYwo+IEBAIC0x MjYsNyArMTI2LDcgQEAgc3RhdGljIHZvaWQgKnR5cGVjX211eF9tYXRjaChzdHJ1Y3QgZGV2aWNl X2Nvbm5lY3Rpb24gKmNvbiwgaW50IGVwLCB2b2lkICpkYXRhKQo+ICB7Cj4gIAljb25zdCBzdHJ1 Y3QgdHlwZWNfYWx0bW9kZV9kZXNjICpkZXNjID0gZGF0YTsKPiAgCXN0cnVjdCB0eXBlY19tdXgg Km11eDsKPiAtCXNpemVfdCBudmFsOwo+ICsJaW50IG52YWw7Cj4gIAlib29sIG1hdGNoOwo+ICAJ dTE2ICp2YWw7Cj4gIAlpbnQgaTsKCnRoYW5rcywK