From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DBAC43381 for ; Tue, 19 Feb 2019 14:24:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6B1821773 for ; Tue, 19 Feb 2019 14:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="43vu+b3H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbfBSOYa (ORCPT ); Tue, 19 Feb 2019 09:24:30 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:40090 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfBSOYa (ORCPT ); Tue, 19 Feb 2019 09:24:30 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1JENoNm161574; Tue, 19 Feb 2019 14:23:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=6jL1FAvnDbD9o3wwnUnC4bzX2Oz5HWZB+4GJQjTeMLE=; b=43vu+b3H91nQYqNQgoNgNm2SBWV+WBBPCaxXboKTwjtL66gZT72Fl7jubeULckkfLj7g T2M5wmfEdA8vlih/HB7zMrCtjY1kH+k3NpsGRggCH+oyALYuB4a7lqdDhQMrwbyeDnXg qFkT7jjwtJhQwohY0Yav0oBX4BtlbTgltgLviKPtr7P5e+lRhKI1QjWcn/0Vx9o9icbO Guv7H7rzWr8i1wXv+/ZsACC43AUtcAbH0Dah5j9ePt997NR6xWz94WATzt/eo+cp/kO4 Hd5udcB4jiss/zuccqxbyxq897LtgZ4EepAm5+SXqB+JhVvf/qvn5bMh4AwuMzbR6CRG vg== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qp9xtuffh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 14:23:56 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1JENt5o020619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 14:23:55 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1JENrEn009577; Tue, 19 Feb 2019 14:23:53 GMT Received: from kadam (/197.157.0.53) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Feb 2019 06:23:53 -0800 Date: Tue, 19 Feb 2019 17:23:43 +0300 From: Dan Carpenter To: Walter Harms Cc: Mao Wenan , kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() Message-ID: <20190219142343.GI17104@kadam> References: <715767253.151509.1550580124264@ox-groupware.bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <715767253.151509.1550580124264@ox-groupware.bfs.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9171 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902190108 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 19, 2019 at 01:42:03PM +0100, Walter Harms wrote: > > Am 19.02.2019 10:06, schrieb Mao Wenan: > > - > > for (i=1; i<2; i++) { > > > the loop here seems also pointless, so you can eliminate i. > (or did i muss something ?) > True. But please do it in a separate patch. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 19 Feb 2019 14:23:43 +0000 Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() Message-Id: <20190219142343.GI17104@kadam> List-Id: References: <715767253.151509.1550580124264@ox-groupware.bfs.de> In-Reply-To: <715767253.151509.1550580124264@ox-groupware.bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Walter Harms Cc: Mao Wenan , kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr On Tue, Feb 19, 2019 at 01:42:03PM +0100, Walter Harms wrote: > > Am 19.02.2019 10:06, schrieb Mao Wenan: > > - > > for (i=1; i<2; i++) { > > > the loop here seems also pointless, so you can eliminate i. > (or did i muss something ?) > True. But please do it in a separate patch. regards, dan carpenter