From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 635F9C43381 for ; Tue, 19 Feb 2019 17:46:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3286A20838 for ; Tue, 19 Feb 2019 17:46:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FVNzvyLT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728782AbfBSRqs (ORCPT ); Tue, 19 Feb 2019 12:46:48 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58660 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726215AbfBSRqr (ORCPT ); Tue, 19 Feb 2019 12:46:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Cz59673MLumfIH3nMqRSkd8R9N0TOG5vbWeyxZJrM/8=; b=FVNzvyLTnEHNrEB6w5vgSkqGGv lbDG/iKeTKl3mTjVEXwAyiYH5bFTcjBmYauxyljB60ltjqdRODEW6+sGSU8vve/e1A4TkM/0kf5am rfV3ZlyyEoHlju+dTnQGmSyIUcL0PZ0tjMJz/TZppg7Rz5A2S+F01N/UU2vwUcstuXEA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gw9Te-00050L-J3; Tue, 19 Feb 2019 18:46:42 +0100 Date: Tue, 19 Feb 2019 18:46:42 +0100 From: Andrew Lunn To: Walter Harms Cc: Mao Wenan , kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() Message-ID: <20190219174642.GD13075@lunn.ch> References: <715767253.151509.1550580124264@ox-groupware.bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <715767253.151509.1550580124264@ox-groupware.bfs.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > for (i=1; i<2; i++) { > > > the loop here seems also pointless, so you can eliminate i. > (or did i muss something ?) If you widen out your view a bit, you find all this code is inside a #ifdef PHY_CODE_IS_FINISHED. I don't see anything which actually defines that. So a lot more code could probably be removed. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Date: Tue, 19 Feb 2019 17:46:42 +0000 Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() Message-Id: <20190219174642.GD13075@lunn.ch> List-Id: References: <715767253.151509.1550580124264@ox-groupware.bfs.de> In-Reply-To: <715767253.151509.1550580124264@ox-groupware.bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Walter Harms Cc: Mao Wenan , kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, john.fastabend@gmail.com, hawk@kernel.org, jakub.kicinski@netronome.com, daniel@iogearbox.net, ast@kernel.org, julia.lawall@lip6.fr > > for (i=1; i<2; i++) { > > > the loop here seems also pointless, so you can eliminate i. > (or did i muss something ?) If you widen out your view a bit, you find all this code is inside a #ifdef PHY_CODE_IS_FINISHED. I don't see anything which actually defines that. So a lot more code could probably be removed. Andrew