From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Blake <eblake@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/8] migration: Make multifd not experimental
Date: Wed, 20 Feb 2019 12:56:03 +0100 [thread overview]
Message-ID: <20190220115611.3192-1-quintela@redhat.com> (raw)
v2:
- Measure packet size in bytes/not pages
- Change the defalut value from 64KB to 512KB
- rename used field to pages_used
- rename size field to pages_alloc
- Create nnext_packet_size field
Will be used on compression series later.
- Be flexible about what packet sizes we allow.
Please review,
In v1:
- Change page_count default to 128.
16 was really small, and it makes much less contention on mutexes to
just have bigger packets.
- Drop multifd-page_count parameter
This parameter was useful for testing, but in all my testing 128 is
good enough, no need to have an extra knob. Libvirt don't want to
expose this parameter because it is difficult to explain.
- Drop experimental "x-" from multifd
Code is stable, nothing big is happening here.
- Multifd test
And a test for multifd, this test has already been on other patch
series. But now it uses the names without "-x".
Please review.
Juan Quintela (8):
multifd: Only send pages when packet are not empty
multifd: Rename "size" member to pages_alloc
multifd: Create new next_packet_size field
multifd: Drop x-multifd-page-count parameter
multifd: Be flexible about packet size
multifd: Change default packet size
multifd: Drop x-
tests: Add migration multifd test
hmp.c | 17 +++------
migration/migration.c | 56 +++++++-----------------------
migration/migration.h | 1 -
migration/ram.c | 79 ++++++++++++++++++++++++++++++------------
migration/trace-events | 4 +--
qapi/migration.json | 45 +++++++++---------------
tests/migration-test.c | 48 +++++++++++++++++++++++++
7 files changed, 142 insertions(+), 108 deletions(-)
--
2.20.1
next reply other threads:[~2019-02-20 11:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 11:56 Juan Quintela [this message]
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 1/8] multifd: Only send pages when packet are not empty Juan Quintela
2019-02-21 17:43 ` Dr. David Alan Gilbert
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 2/8] multifd: Rename "size" member to pages_alloc Juan Quintela
2019-02-21 17:48 ` Dr. David Alan Gilbert
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 3/8] multifd: Create new next_packet_size field Juan Quintela
2019-02-21 18:45 ` Dr. David Alan Gilbert
2019-02-27 11:02 ` Juan Quintela
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 4/8] multifd: Drop x-multifd-page-count parameter Juan Quintela
2019-02-21 17:51 ` Dr. David Alan Gilbert
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 5/8] multifd: Be flexible about packet size Juan Quintela
2019-02-21 18:30 ` Dr. David Alan Gilbert
2019-02-27 11:06 ` Juan Quintela
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 6/8] multifd: Change default " Juan Quintela
2019-02-21 18:40 ` Dr. David Alan Gilbert
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 7/8] multifd: Drop x- Juan Quintela
2019-02-20 11:56 ` [Qemu-devel] [PATCH v2 8/8] tests: Add migration multifd test Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220115611.3192-1-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.