From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C44C43381 for ; Wed, 20 Feb 2019 17:30:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 301C420859 for ; Wed, 20 Feb 2019 17:30:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qmJQZi+C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbfBTRaW (ORCPT ); Wed, 20 Feb 2019 12:30:22 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:45485 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfBTRaT (ORCPT ); Wed, 20 Feb 2019 12:30:19 -0500 Received: by mail-qk1-f193.google.com with SMTP id v139so2447365qkb.12 for ; Wed, 20 Feb 2019 09:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=E4AlJDUfTehqBxSfn4QmqQwizINvYLOUp2cX9SOJSAE=; b=qmJQZi+CD+TdP3onPusEA71E5rfRTbqIwmF2hJZQy1LZCkjlJn6paDgW+N1o11tkb7 yPYe2GegVIhslUriuI6lAMk1m+w1RuQmg9toJnVZtAJbPXres7Ll4OPBBFDYFsziG9RU zQaVEoTiMQghLBuCh0/utP967YulFEYMbgnVNiVks5p6zYwdEUwVJV/2OQDVmtiOtLtD VRiMDcEZpIcP/cWcMeLqGBiG8W6PrCAAmwKzJubWBEf675dJEalfLjEIdNoypn2NmIX2 Gk5+mrr6YS0YOjF8dLux0JtXedf4syZVE/5FYVx+8s02xFq6GTls99wNMssAgtPQVvH0 AY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=E4AlJDUfTehqBxSfn4QmqQwizINvYLOUp2cX9SOJSAE=; b=qOdSphKVvKxwzbViamrmoAMF9yqycC2a+YADqVR2Mhv46c5oU9b50bINaOPioY2/7s WogFa8PjUJWXMa0jrzWYHzi8ebN/+zO4iTUBW/jpqgLbhnuUPWX8RMnz6SkZFtq7OUcs V+igVtVMoUoK4d0aX4GIL7ny3zmMM0bV1ZaPyB2mC8HibrI9bSMFdG6BnwfwSP57uvAi Ynk4KGZ61n32bIa9WKK0NR0qOQxiSk02UvTJOusZm8rvlBAWVXlViTcUxuKb/XClQzsc SYWyIi1D0Jwo37K4brMBvi/ANBYY/ynWU8oyCPAyqm4KuKImtfdm5/yC1USd07kLfVbq PBIA== X-Gm-Message-State: AHQUAuYzi51LCLFypTO7Ghakg6QEPK2T7WvJ0g1C1dBbojK3RA5Xtv9H uAP6jpcfzgRDNvpLlDGV72uIkmnvX5s= X-Google-Smtp-Source: AHgI3IagRmh0QuJ3QiQ0FMmeNYuDBth+aVigLGmgM6NnxdsRgE3YMEUKK+M/G82jTjkBetACIns2Jw== X-Received: by 2002:a37:8105:: with SMTP id c5mr25478395qkd.116.1550683818282; Wed, 20 Feb 2019 09:30:18 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id u32sm25417658qtc.54.2019.02.20.09.30.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Feb 2019 09:30:17 -0800 (PST) Date: Wed, 20 Feb 2019 12:30:16 -0500 Message-ID: <20190220123016.GF32192@t480s.localdomain> From: Vivien Didelot To: Russell King Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next v3 1/3] net: dsa: add support for bridge flags In-Reply-To: References: <20190220123615.fcyrlhz5jpx5ecgv@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Russell, On Wed, 20 Feb 2019 12:36:48 +0000, Russell King wrote: > The Linux bridge implementation allows various properties of the bridge > to be controlled, such as flooding unknown unicast and multicast frames. > This patch adds the necessary DSA infrastructure to allow the Linux > bridge support to control these properties for DSA switches. > > We implement this by providing two new methods: one to get the switch- > wide support bitmask, and another to set the properties. This is not true anymore ;-) > > Signed-off-by: Russell King > --- > include/net/dsa.h | 2 ++ > net/dsa/dsa_priv.h | 2 ++ > net/dsa/port.c | 16 ++++++++++++++++ > net/dsa/slave.c | 6 ++++++ > 4 files changed, 26 insertions(+) > > diff --git a/include/net/dsa.h b/include/net/dsa.h > index 7f2a668ef2cc..2c2c10812814 100644 > --- a/include/net/dsa.h > +++ b/include/net/dsa.h > @@ -400,6 +400,8 @@ struct dsa_switch_ops { > void (*port_stp_state_set)(struct dsa_switch *ds, int port, > u8 state); > void (*port_fast_age)(struct dsa_switch *ds, int port); > + int (*port_egress_floods)(struct dsa_switch *ds, int port, > + bool unicast, bool multicast); > > /* > * VLAN support > diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h > index 1f4972dab9f2..f4f99ec29f5d 100644 > --- a/net/dsa/dsa_priv.h > +++ b/net/dsa/dsa_priv.h > @@ -160,6 +160,8 @@ int dsa_port_mdb_add(const struct dsa_port *dp, > struct switchdev_trans *trans); > int dsa_port_mdb_del(const struct dsa_port *dp, > const struct switchdev_obj_port_mdb *mdb); > +int dsa_port_bridge_flags(const struct dsa_port *dp, unsigned long flags, > + struct switchdev_trans *trans); > int dsa_port_vlan_add(struct dsa_port *dp, > const struct switchdev_obj_port_vlan *vlan, > struct switchdev_trans *trans); > diff --git a/net/dsa/port.c b/net/dsa/port.c > index 2d7e01b23572..b84d010fb165 100644 > --- a/net/dsa/port.c > +++ b/net/dsa/port.c > @@ -177,6 +177,22 @@ int dsa_port_ageing_time(struct dsa_port *dp, clock_t ageing_clock, > return dsa_port_notify(dp, DSA_NOTIFIER_AGEING_TIME, &info); > } > > +int dsa_port_bridge_flags(const struct dsa_port *dp, unsigned long flags, > + struct switchdev_trans *trans) > +{ > + struct dsa_switch *ds = dp->ds; > + int port = dp->index; > + > + if (switchdev_trans_ph_prepare(trans)) > + return 0; > + > + if (ds->ops->port_egress_floods) > + ds->ops->port_egress_floods(ds, port, flags & BR_FLOOD, > + flags & BR_MCAST_FLOOD); Even though we're not supposed to fail in the switchdev commit phase, I'd prefer not to ignore the return code. > + > + return 0; > +} > + > int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr, > u16 vid) > { > diff --git a/net/dsa/slave.c b/net/dsa/slave.c > index 2e5e7c04821b..f99161c3b1ea 100644 > --- a/net/dsa/slave.c > +++ b/net/dsa/slave.c > @@ -295,6 +295,9 @@ static int dsa_slave_port_attr_set(struct net_device *dev, > case SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME: > ret = dsa_port_ageing_time(dp, attr->u.ageing_time, trans); > break; > + case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS: > + ret = dsa_port_bridge_flags(dp, attr->u.brport_flags, trans); > + break; > default: > ret = -EOPNOTSUPP; > break; > @@ -384,6 +387,9 @@ static int dsa_slave_port_attr_get(struct net_device *dev, > switch (attr->id) { > case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT: > attr->u.brport_flags_support = 0; > + if (ds->ops->port_egress_floods) > + attr->u.brport_flags_support |= BR_FLOOD | > + BR_MCAST_FLOOD; > break; > default: > return -EOPNOTSUPP; Otherwise, LGTM: Reviewed-by: Vivien Didelot