From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: [PATCH yavta 7/7] Remove unneeded conditional compilation for old V4L2 API versions
Date: Wed, 20 Feb 2019 14:51:23 +0200 [thread overview]
Message-ID: <20190220125123.9410-8-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20190220125123.9410-1-laurent.pinchart@ideasonboard.com>
As we include a copy of the V4L2 kernel headers, there's no need for
conditional compilation to support old versions of the API.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
yavta.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/yavta.c b/yavta.c
index 2d49131a4271..741df82a8db0 100644
--- a/yavta.c
+++ b/yavta.c
@@ -40,10 +40,6 @@
#include <linux/videodev2.h>
-#ifndef V4L2_BUF_FLAG_ERROR
-#define V4L2_BUF_FLAG_ERROR 0x0040
-#endif
-
#define ARRAY_SIZE(a) (sizeof(a)/sizeof((a)[0]))
enum buffer_fill_mode
@@ -1142,16 +1138,9 @@ static int video_for_each_control(struct device *dev,
unsigned int id;
int ret;
-#ifndef V4L2_CTRL_FLAG_NEXT_CTRL
- unsigned int i;
-
- for (i = V4L2_CID_BASE; i <= V4L2_CID_LASTP1; ++i) {
- id = i;
-#else
id = 0;
while (1) {
id |= V4L2_CTRL_FLAG_NEXT_CTRL | V4L2_CTRL_FLAG_NEXT_COMPOUND;
-#endif
ret = query_control(dev, id, &query);
if (ret == -EINVAL)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-02-20 12:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 12:51 [PATCH yavta 0/7] Compound controls and controls reset support Laurent Pinchart
2019-02-20 12:51 ` [PATCH yavta 1/7] yavta: Refactor video_list_controls() Laurent Pinchart
2019-02-20 13:21 ` Sakari Ailus
2019-02-20 14:07 ` Laurent Pinchart
2019-02-20 14:13 ` Sakari Ailus
2019-02-20 12:51 ` [PATCH yavta 2/7] Implement VIDIOC_QUERY_EXT_CTRL support Laurent Pinchart
2019-02-20 12:51 ` [PATCH yavta 3/7] Implement compound control get support Laurent Pinchart
2019-02-20 14:06 ` Sakari Ailus
2019-02-20 14:55 ` Laurent Pinchart
2019-02-20 21:16 ` Sakari Ailus
2019-02-20 12:51 ` [PATCH yavta 4/7] Implement compound control set support Laurent Pinchart
2019-02-20 21:21 ` Sakari Ailus
2019-02-20 12:51 ` [PATCH yavta 5/7] Add support to reset device controls Laurent Pinchart
2019-02-20 12:51 ` [PATCH yavta 6/7] Support setting control from values stored in a file Laurent Pinchart
2019-02-20 21:26 ` Sakari Ailus
2019-02-22 11:47 ` Laurent Pinchart
2019-02-22 12:32 ` Sakari Ailus
2019-02-20 12:51 ` Laurent Pinchart [this message]
2019-02-20 21:33 ` [PATCH yavta 0/7] Compound controls and controls reset support Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220125123.9410-8-laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.