From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [dpdk-stable] [PATCH] net/bonding: fix reset active
	slave
Date: Thu, 21 Feb 2019 00:16:52 +0900
Message-ID: <20190220151650.GA30988@HYONKIM-7R0DR.cisco.com>
References: <no>
 <1550491163-23616-1-git-send-email-hari.kumarx.vemula@intel.com>
 <3d107ef4-576f-39b0-0e87-6b62e333fc6a@intel.com>
 <a8d165a7-d8ef-79ef-e2ae-96ec13e38daf@intel.com>
 <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Hari Kumar Vemula <hari.kumarx.vemula@intel.com>, dev@dpdk.org,
 "Pattan, Reshma" <reshma.pattan@intel.com>,
 JananeeX M <jananeex.m.parthasarathy@intel.com>,
 Declan <declan.doherty@intel.com>, stable@dpdk.org
To: Radu Nicolau <radu.nicolau@intel.com>
Return-path: <dev-bounces@dpdk.org>
Content-Disposition: inline
In-Reply-To: <67490f9f-a3cb-3b75-f0d9-db323c4787e9@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Feb 20, 2019 at 02:56:36PM +0000, Radu Nicolau wrote:
> 
> 
> On 2/20/2019 12:33 PM, Ferruh Yigit wrote:
> > On 2/18/2019 3:58 PM, Radu Nicolau wrote:
> > > 
> > > On 2/18/2019 11:59 AM, Hari Kumar Vemula wrote:
> > > > test_alb_reply_from_client test fails due to incorrect active slave
> > > > array's index. This was due to invalid active slave count.
> > > > 
> > > > Count of internals->active_slave is not updated even when active slave
> > > > is deactivated.
> > > > Hence active slave count always keeps incrementing beyond the actual
> > > > active slaves.
> > > > 
> > > > Fix is to set the internals->active_slave to starting index 0 whenever
> > > > it exceeds the number of slaves in active slave list and also update
> > > > the active slave count during slave de-activation.
> > > > 
> > > > Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
> > > > Cc: stable@dpdk.org
> > > > 
> > > > Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> > > > ---
> > > > 
> > > Acked-by: Radu Nicolau <radu.nicolau@intel.com
> > > <mailto:radu.nicolau@intel.com>>
> > Hi Radu, Hari,
> > 
> > There is another bonding patch, can you please check how related are they and if
> > are these fixing same root cause:
> > 
> > net/bonding: avoid the next active slave going out of bound
> > https://patches.dpdk.org/patch/49573/
> > 
> Hi, it's a similar fix for the same root cause, but this one covers more (or
> all) situations that can cause active_slave to go out of bounds.

If it covers more cases, please go with the new patch and drop mine. I
just want to see the issue fixed :-)

Thanks.
-Hyong