From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gwZ82-00085R-JS for mharc-grub-devel@gnu.org; Wed, 20 Feb 2019 16:10:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwZ81-00085H-AX for grub-devel@gnu.org; Wed, 20 Feb 2019 16:10:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwZ80-0003P0-Jk for grub-devel@gnu.org; Wed, 20 Feb 2019 16:10:05 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:55638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwZ80-00037N-9I for grub-devel@gnu.org; Wed, 20 Feb 2019 16:10:04 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1KKs5tp127090; Wed, 20 Feb 2019 21:09:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=41e9NZDcfVcB+x/WySDI9ocIQVqSADi/YV3sO2AvtJg=; b=dmj7at2c1HqYRAYKNbM2UE1PxYdIDVxdO8FrctH+DTLR9AP+cF0KohlOctqanG/Iaj4W 1Q3WryMYqJUOGPCiX0ApxoENacqSYq+VL65XEWIjgJM8OaFkItf+FZXe7+ssgyhIRIQi 2SqZtSKCERFCY/+ymhSi0DhUTChXgvg2lPAtCDXoky/7gF/LHXL89eusj+gXQIZUFAl6 PGgyovAROWrhlQLw6h45CVvi1KKog9fUCwfrfdfOYsfuFOAXwGYapjFw4e2op5Ic5Qbk MHbRmna1rbhbIrokyU8hFUedJNIPnF7HI6hqeJrYMVS1M4T+WbEY/u/C9AscHrG1Hx3E sQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2qp81ecbt1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Feb 2019 21:09:51 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1KL9nM1014367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Feb 2019 21:09:50 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1KL9mDZ005529; Wed, 20 Feb 2019 21:09:49 GMT Received: from tomti.i.net-space.pl (/10.175.183.221) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Feb 2019 13:09:48 -0800 Date: Wed, 20 Feb 2019 22:09:38 +0100 From: Daniel Kiper To: Andre Przywara Cc: Daniel Kiper , Vladimir Serbinenko , Andrei Borzenkov , Mark Rutland , grub-devel@gnu.org Subject: Re: [PATCH v2 1/9] net: dhcp: remove dead code Message-ID: <20190220210938.j2pyqf3btectvqhp@tomti.i.net-space.pl> References: <20190212174700.184741-1-andre.przywara@arm.com> <20190212174700.184741-2-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212174700.184741-2-andre.przywara@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9173 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902200143 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.79 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 21:10:06 -0000 Hi Andre, First of all, sorry for late reply. I am clearing my backlog after the travel. I hope that I will be replying more often starting from now. On Tue, Feb 12, 2019 at 05:46:52PM +0000, Andre Przywara wrote: > From: Andrei Borzenkov > > The comment is right, the "giaddr" fields holds the IP address of the > BOOTP relay, not a general purpose router address. > Just remove the commented code, archeologists can find it in the git > history. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel