From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52F8E891DC for ; Wed, 20 Feb 2019 21:20:48 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id m35so17252697ede.10 for ; Wed, 20 Feb 2019 13:20:48 -0800 (PST) Date: Wed, 20 Feb 2019 22:20:43 +0100 From: Daniel Vetter Message-ID: <20190220212043.GD2665@phenom.ffwll.local> References: <20190220162530.31643-1-daniel.vetter@ffwll.ch> <20190220162530.31643-3-daniel.vetter@ffwll.ch> <178261c5a84a9a7698b742d6b2b8c053ac01832a.camel@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <178261c5a84a9a7698b742d6b2b8c053ac01832a.camel@redhat.com> Subject: Re: [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lyude Paul Cc: IGT development , Keith Packard List-ID: T24gV2VkLCBGZWIgMjAsIDIwMTkgYXQgMDM6NDM6NDVQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBPbiBXZWQsIDIwMTktMDItMjAgYXQgMTc6MjUgKzAxMDAsIERhbmllbCBWZXR0ZXIgd3Jv dGU6Cj4gPiBGb3VuZCBhIGZldyB0aGluZ3MgaW4gdGhlIGtlcm5lbCB0aGF0IGxvb2tzIHN1c3Bp Y2lvdXMsIHNlcGFyYXRlCj4gPiBwYXRjaGVzIG9uIHRoZWlyIHdheS4KPiA+IAo+ID4gSSBhbHNv IHJldmlld2VkIGNvdmVyYWdlIGZvciBsaXN0LWxlc3NlcyBhbmQgZ2V0LWxlYXNlLCBhbmQgY292 ZXJhZ2UKPiA+IHNlZW1zIGNvbXBsZXRlIGZvciB0aGVzZS4KPiA+IAo+ID4gQ2M6IEtlaXRoIFBh Y2thcmQgPGtlaXRocEBrZWl0aHAuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IC0tLQo+ID4gIHRlc3RzL2ttc19sZWFzZS5j IHwgMTAwCj4gPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTAwIGluc2VydGlvbnMoKykKPiA+IAo+ID4g ZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19sZWFzZS5jIGIvdGVzdHMva21zX2xlYXNlLmMKPiA+IGlu ZGV4IGZhOTdmNmUxMTMzNC4uNDA2MmEwYjM2NWM5IDEwMDY0NAo+ID4gLS0tIGEvdGVzdHMva21z X2xlYXNlLmMKPiA+ICsrKyBiL3Rlc3RzL2ttc19sZWFzZS5jCj4gPiBAQCAtNjIzLDYgKzYyMywx MDMgQEAgc3RhdGljIHZvaWQgcnVuX3Rlc3QoZGF0YV90ICpkYXRhLCB2b2lkCj4gPiAoKnRlc3Rm dW5jKShkYXRhX3QgKikpCj4gPiAgCQkgICAgICAibm8gdmFsaWQgY3J0Yy9jb25uZWN0b3IgY29t YmluYXRpb25zIGZvdW5kXG4iKTsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIHZvaWQgaW52YWxp ZF9jcmVhdGVfbGVhc2VzKGRhdGFfdCAqZGF0YSkKPiA+ICt7Cj4gPiArCXVpbnQzMl90IG9iamVj dF9pZHNbNF07Cj4gPiArCXN0cnVjdCBsb2NhbF9kcm1fbW9kZV9jcmVhdGVfbGVhc2UgbWNsOwo+ ID4gKwlkcm1Nb2RlUmVzICpyZXNvdXJjZXM7Cj4gPiArCWludCB0bXBfZmQ7Cj4gPiArCj4gPiAr CS8qIGVtcHR5IGxlYXNlICovCj4gPiArCW1jbC5vYmplY3RfaWRzID0gMDsKPiA+ICsJbWNsLm9i amVjdF9jb3VudCA9IDA7Cj4gPiArCW1jbC5mbGFncyA9IDA7Cj4gPiArCWlndF9hc3NlcnRfZXEo Y3JlYXRlX2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1FSU5WQUwpOwo+ID4gKwo+ID4g KwkvKiBOVUxMIGFycmF5IHBvaW50ZXIgKi8KPiA+ICsJbWNsLm9iamVjdF9jb3VudCA9IDE7Cj4g PiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1F RkFVTFQpOwo+ID4gKwo+ID4gKwkvKiBuaWwgb2JqZWN0ICovCj4gPiArCW9iamVjdF9pZHNbMF0g PSAwOwo+ID4gKwltY2wub2JqZWN0X2lkcyA9ICh1aW50NjRfdCkgKHVpbnRwdHJfdCkgb2JqZWN0 X2lkczsKPiA+ICsJbWNsLm9iamVjdF9jb3VudCA9IDE7Cj4gPiArCWlndF9hc3NlcnRfZXEoY3Jl YXRlX2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1FTk9FTlQpOwo+ID4gKwo+ID4gKwkv KiBubyBjcnRjLCBub24tdW5pdmVyc2FsX3BsYW5lICovCj4gPiArCWRybVNldENsaWVudENhcChk YXRhLT5tYXN0ZXIuZmQsIERSTV9DTElFTlRfQ0FQX1VOSVZFUlNBTF9QTEFORVMsIDApOwo+ID4g KwlvYmplY3RfaWRzWzBdID0gZGF0YS0+bWFzdGVyLmRpc3BsYXkub3V0cHV0c1swXS5pZDsKPiA+ ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVJ TlZBTCk7Cj4gPiArCj4gPiArCS8qIG5vIGNvbm5lY3Rvciwgbm9uLXVuaXZlcnNhbF9wbGFuZSAq Lwo+ID4gKwlvYmplY3RfaWRzWzBdID0gZGF0YS0+bWFzdGVyLmRpc3BsYXkucGlwZXNbMF0uY3J0 Y19pZDsKPiA+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAm bWNsKSwgLUVJTlZBTCk7Cj4gPiArCj4gPiArCS8qIHNhbml0eSBjaGVjayAqLwo+ID4gKwlvYmpl Y3RfaWRzWzBdID0gZGF0YS0+bWFzdGVyLmRpc3BsYXkucGlwZXNbMF0uY3J0Y19pZDsKPiA+ICsJ b2JqZWN0X2lkc1sxXSA9IGRhdGEtPm1hc3Rlci5kaXNwbGF5Lm91dHB1dHNbMF0uaWQ7Cj4gPiAr CW1jbC5vYmplY3RfY291bnQgPSAyOwo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShk YXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAwKTsKPiA+ICsJY2xvc2UobWNsLmZkKTsKPiA+ICsKPiA+ ICsJLyogbm8gcGxhbmUsIHVuaXZlcnNhbCBwbGFuZXMgKi8KPiA+ICsJZHJtU2V0Q2xpZW50Q2Fw KGRhdGEtPm1hc3Rlci5mZCwgRFJNX0NMSUVOVF9DQVBfVU5JVkVSU0FMX1BMQU5FUywgMSk7Cj4g PiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1F SU5WQUwpOwo+ID4gKwo+ID4gKwkvKiBzYW5pdHkgY2hlY2sgKi8KPiA+ICsJb2JqZWN0X2lkc1sy XSA9IGlndF9waXBlX2dldF9wbGFuZV90eXBlKCZkYXRhLQo+ID4gPm1hc3Rlci5kaXNwbGF5LnBp cGVzWzBdLAo+ID4gKwkJCQkJCURSTV9QTEFORV9UWVBFX1BSSU1BUlkpLQo+ID4gPmRybV9wbGFu ZS0+cGxhbmVfaWQ7Cj4gPiArCW1jbC5vYmplY3RfY291bnQgPSAzOwo+ID4gKwlpZ3RfYXNzZXJ0 X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAwKTsKPiA+ICsJY2xvc2Uo bWNsLmZkKTsKPiA+ICsKPiA+ICsJLyogYXJyYXkgb3ZlcmZsb3cgKi8KPiA+ICsJbWNsLm9iamVj dF9jb3VudCA9IFVJTlQzMl9NQVggLyBzaXplb2Yob2JqZWN0X2lkc1swXSkgKyAxOwo+ID4gKwlp Z3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAtRU5PTUVN KTsKPiA+ICsJbWNsLm9iamVjdF9jb3VudCA9IFVJTlQzMl9NQVggLyBzaXplb2Yob2JqZWN0X2lk c1swXSkgKyAyOwo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIu ZmQsICZtY2wpLCAtRU5PTUVNKTsKPiA+ICsJbWNsLm9iamVjdF9jb3VudCA9IFVJTlQzMl9NQVgg LyBzaXplb2Yob2JqZWN0X2lkc1swXSkgKyAzOwo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9s ZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAtRU5PTUVNKTsKPiA+ICsJbWNsLm9iamVjdF9j b3VudCA9IFVJTlQzMl9NQVggLyBzaXplb2Yob2JqZWN0X2lkc1swXSkgKyA0Owo+ID4gKwlpZ3Rf YXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAtRU5PTUVNKTsK PiAKPiBuaXRwaWNrOiBjb3VsZCBwcm9iYWJseSBtYWtlIHRoaXMgYSBsb29wLCB1cCB0byB5b3UK ClllYWgsIHdpbGwgZG8uCgo+IAo+ID4gKwo+ID4gKwkvKiBpbnZhbGlkIGZsYWdzICovCj4gPiAr CW1jbC5vYmplY3RfY291bnQgPSAzOwo+ID4gKwltY2wuZmxhZ3MgPSBPX0NMT0VYRUMgfCBPX05P TkJMT0NLOwo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQs ICZtY2wpLCAwKTsKPiA+ICsJY2xvc2UobWNsLmZkKTsKPiAKPiBJIHRoaW5rIEknbSBtaXNzaW5n IHNvbWV0aGluZy4gVGhlIGh1bmsgYmVsb3cgdGhpcyBtYWtlcyBzZW5zZSwgYnV0IEknbSBub3QK PiBxdWl0ZSBzdXJlIEkgdW5kZXJzdGFuZCB3aGF0J3MgaGFwcGVuaW5nIGFib3ZlIGhlcmU/IF4K CkkgbGlrZSB0byBzcHJpbmtsZSBpbiBzYW5pdHkgY2hlY2sgdGVzdHMsIHRvIG1ha2Ugc3VyZSBJ J20gYWN0dWFsbHkKdGVzdGluZyB3aGF0IEknbSB0ZXN0aW5nLiBGaXJzdCBydW4gc29tZXRoaW5n IHlvdSBrbm93IHNob3VsZCB3b3JrLCB0aGVuCmNoYW5nZSBvbmUgdGhpbmcgKGFuZCBvbmUgdGhp bmcgb25seSksIHRoZW4geW91J2xsIGtub3cgdGhlIGtlcm5lbCBmYWlscwpiZWNhdXNlIG9mIHRo YXQgb25lIHRoaW5nIHlvdSdyZSB0ZXN0aW5nLCBhbmQgbm90IHNvbWUgc3RyYW5nZSBpbnRlcmFj dGlvbgp3aGljaCBtaWdodCBoaWRlIGJ1Z3MuCgpJJ2xsIGFkZCBhIC8qIHNhbml0eSBjaGVjayAq LyBoZXJlIGFuZCBtb3ZlIHRoZSAvKiBpbnZhbGlkIGZsYWdzICovIGRvd24uCi1EYW5pZWwKCj4g Cj4gQmVzaWRlcyB0aGF0LCB0aGUgcmVzdCBvZiB0aGlzIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUK PiAKPiA+ICsJbWNsLmZsYWdzID0gLTE7Cj4gPiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNl KGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1FSU5WQUwpOwo+ID4gKwo+ID4gKwkvKiBubyBzdWJs ZWFzaW5nICovCj4gPiArCW1jbC5vYmplY3RfY291bnQgPSAzOwo+ID4gKwltY2wuZmxhZ3MgPSAw Owo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wp LCAwKTsKPiA+ICsJdG1wX2ZkID0gbWNsLmZkOwo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9s ZWFzZSh0bXBfZmQsICZtY2wpLCAtRUlOVkFMKTsKPiA+ICsJY2xvc2UodG1wX2ZkKTsKPiA+ICsK PiA+ICsJLyogbm8gZG91YmxlLWxlYXNpbmcgKi8KPiA+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVf bGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgMCk7Cj4gPiArCXRtcF9mZCA9IG1jbC5mZDsK PiA+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwg LUVCVVNZKTsKPiA+ICsJY2xvc2UodG1wX2ZkKTsKPiA+ICsKPiA+ICsJLyogbm8gZG91YmxlIGxl YXNpbmcgKi8KPiA+ICsJb2JqZWN0X2lkc1szXSA9IG9iamVjdF9pZHNbMl07Cj4gPiArCW1jbC5v YmplY3RfY291bnQgPSA0Owo+ID4gKwkvKiBOb3RlOiB0aGUgRU5PU1BDIGlzIGZyb20gaWRyIGRv dWJsZS1pbnNlcnRpb24gZmFpbGluZyAqLwo+ID4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFz ZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAtRU5PU1BDKTsKPiA+ICsKPiA+ICsJLyogbm8gZW5j b2RlciBsZWFzaW5nICovCj4gPiArCXJlc291cmNlcyA9IGRybU1vZGVHZXRSZXNvdXJjZXMoZGF0 YS0+bWFzdGVyLmZkKTsKPiA+ICsJaWd0X2Fzc2VydChyZXNvdXJjZXMpOwo+ID4gKwlpZ3RfYXNz ZXJ0KHJlc291cmNlcy0+Y291bnRfZW5jb2RlcnMgPiAwKTsKPiA+ICsJb2JqZWN0X2lkc1szXSA9 IHJlc291cmNlcy0+ZW5jb2RlcnNbMF07Cj4gPiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNl KGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1FSU5WQUwpOwo+ID4gKwlkcm1Nb2RlRnJlZVJlc291 cmNlcyhyZXNvdXJjZXMpOwo+ID4gK30KPiA+ICsKPiA+ICBpZ3RfbWFpbgo+ID4gIHsKPiA+ICAJ ZGF0YV90IGRhdGE7Cj4gPiBAQCAtNjU1LDQgKzc1Miw3IEBAIGlndF9tYWluCj4gPiAgCQkJcnVu X3Rlc3QoJmRhdGEsIGYtPmZ1bmMpOwo+ID4gIAkJfQo+ID4gIAl9Cj4gPiArCj4gPiArCWlndF9z dWJ0ZXN0KCJpbnZhbGlkLWNyZWF0ZS1sZWFzZXMiKQo+ID4gKwkJaW52YWxpZF9jcmVhdGVfbGVh c2VzKCZkYXRhKTsKPiA+ICB9Cj4gLS0gCj4gQ2hlZXJzLAo+IAlMeXVkZSBQYXVsCj4gCgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDov L2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2