From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49CA6C43381 for ; Thu, 21 Feb 2019 18:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17D2B205F4 for ; Thu, 21 Feb 2019 18:53:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="bx4qOqi7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727146AbfBUSxA (ORCPT ); Thu, 21 Feb 2019 13:53:00 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:37572 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfBUSxA (ORCPT ); Thu, 21 Feb 2019 13:53:00 -0500 Received: by mail-pg1-f193.google.com with SMTP id q206so14187356pgq.4 for ; Thu, 21 Feb 2019 10:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zB4kDi76K0d9yjcGo9v2w24PrwqUQStsh3tJqp3cwAs=; b=bx4qOqi79iEkjngLif5+YZbVsoR6byT/FYj/RBAJe9ndG4/Mki4NJeskkmXX/wIWhM tFQZZIRo6mvjyisvjY6JWtwjEjeFQ/t5S++zeLFHkC4u5Clzb3Kp1VKvWHMrgsmHhgy5 3Qfx5xrLQ5PgnCPcX55wCibbZ2aA3sLUdPh52HqB5KH2h+e/y8zkHOsu3WGlDCJjEhy8 UJpmLQaOmgOQUnF6kegsZFQG2DXTjq9LR3YGngOMLGE2k90lT7OHCPOFwrbfuNvl7hlV qYWlZ0ONMWYDINbuSExaDoaBV3lYv+QqKV8pfAjjcUkKazHs2gdLeutSFxAIlFvJtRSL T2WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zB4kDi76K0d9yjcGo9v2w24PrwqUQStsh3tJqp3cwAs=; b=H5e648Mqd8hV/TheiGnFD351w3S9cAJU5HO1txubNnI01pB9cASPZDKdrrdncbQQy/ nnfHATwSByPSX4cEOvBa8dJaxAc+FX52Dlpg7wrEp58c7oSyYC7D9ozFCOYt4uLERtHa mhYYB3DmvHyZ/iOCbmnfLLvZMk9YIhmxgAhGd/Yf406C6ofqUsL9QNjGI0XImjb6cUAr Ex5V3dJQnERNMFC77TrBTqsVgaCDpzR0SEjiyEDm67eftU/JwVJFru4MxlbIUXLmvIss JfzGBD4XUittiXL5EQlWZ37RDE+SuwwEQPuAli/0dElURPOwvpyVtOtvw74619q/6yPu cVFA== X-Gm-Message-State: AHQUAuYMpSFXxlEV256vOiRD9MW0QyAYdAQdibph0nLRlwLibMDq7E34 dHqVlGWCto7Pg37IDxEH2Ms0SA== X-Google-Smtp-Source: AHgI3Iay2ClQSrNIaTN1LkRFjf+UGtwjTTWP8SPGllIgTRkKqlgpKMmQzSssagi/KGT5DAgtzGIytA== X-Received: by 2002:a63:f412:: with SMTP id g18mr1591840pgi.444.1550775179215; Thu, 21 Feb 2019 10:52:59 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id p11sm13186368pfi.10.2019.02.21.10.52.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 10:52:59 -0800 (PST) Date: Thu, 21 Feb 2019 10:52:53 -0800 From: Stephen Hemminger To: Stefano Brivio Cc: Moshe Shemesh , netdev@vger.kernel.org, Stephen Hemminger Subject: Re: [RFC] rtnetlink: handle multiple vlan tags in set_vf_vlan Message-ID: <20190221105253.422433db@shemminger-XPS-13-9360> In-Reply-To: <20190221193457.7861791e@redhat.com> References: <20190221175436.10767-1-sthemmin@microsoft.com> <20190221193457.7861791e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 21 Feb 2019 19:34:57 +0100 Stefano Brivio wrote: > On Thu, 21 Feb 2019 09:54:36 -0800 > Stephen Hemminger wrote: > > > @@ -2224,13 +2223,15 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr **tb) > > > > len++; > > } > > - if (len == 0) > > - return -EINVAL; > > > > - err = ops->ndo_set_vf_vlan(dev, ivvl[0]->vf, ivvl[0]->vlan, > > - ivvl[0]->qos, ivvl[0]->vlan_proto); > > - if (err < 0) > > - return err; > > + err = -EINVAL; /* empty list error */ > > + for (i = 0; i < len; i++) { > > + err = ops->ndo_set_vf_vlan(dev, ivvl[i]->vf, > > + ivvl[i]->vlan, ivvl[i]->qos, > > + ivvl[i]->vlan_proto); > > + if (err < 0) > > + return err; > > + } > > I think the: > > if (err < 0) > return err; > > should be outside the loop (with a "break;" inside), otherwise you won't > return anymore if len == 0. > Your right with empty list it would fall through and look at other attributes which could overwrite err.