From: Stephen Hemminger <stephen@networkplumber.org>
To: Steve Wise <swise@opengridcomputing.com>
Cc: dsahern@gmail.com, leon@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h
Date: Thu, 21 Feb 2019 10:56:31 -0800 [thread overview]
Message-ID: <20190221105631.7dfa5217@shemminger-XPS-13-9360> (raw)
In-Reply-To: <ff4f692bee0d683c0638cf88cbf14faf94ea87af.1550773362.git.swise@opengridcomputing.com>
On Thu, 21 Feb 2019 08:19:07 -0800
Steve Wise <swise@opengridcomputing.com> wrote:
> Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK /
> RDMA_NLDEV_CMD_DELLINK API.
>
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
> rdma/include/uapi/rdma/rdma_netlink.h | 74 +++++++++++++++++++++++++++--------
> 1 file changed, 58 insertions(+), 16 deletions(-)
>
> diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h
> index 04c80cebef49..23a90ad52485 100644
> --- a/rdma/include/uapi/rdma/rdma_netlink.h
> +++ b/rdma/include/uapi/rdma/rdma_netlink.h
> @@ -5,8 +5,7 @@
> #include <linux/types.h>
>
> enum {
> - RDMA_NL_RDMA_CM = 1,
> - RDMA_NL_IWCM,
> + RDMA_NL_IWCM = 2,
> RDMA_NL_RSVD,
> RDMA_NL_LS, /* RDMA Local Services */
> RDMA_NL_NLDEV, /* RDMA device interface */
You can't just drop elements from user ABI headers.
That is a break of kernel ABI guarantee.
Instead, mark unused elements:
enum {
RDMA_NL_RDMA_CM = 1, /* deprecated */
RDMA_NL_IWCM,
...
next prev parent reply other threads:[~2019-02-21 18:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 18:22 [PATCH v1 iproute2-next 0/4] Dynamic rdma link creation Steve Wise
2019-02-21 16:19 ` [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg() Steve Wise
2019-02-23 9:26 ` Leon Romanovsky
2019-02-23 9:31 ` Leon Romanovsky
2019-02-26 17:19 ` Steve Wise
2019-02-26 19:16 ` Leon Romanovsky
2019-02-26 19:55 ` Steve Wise
2019-02-26 19:55 ` David Ahern
2019-02-26 17:13 ` Steve Wise
2019-02-27 20:23 ` Steve Wise
2019-02-27 20:23 ` Steve Wise
2019-03-03 13:50 ` Leon Romanovsky
2019-03-04 14:13 ` Steve Wise
2019-03-04 14:13 ` Steve Wise
2019-03-06 21:50 ` Steve Wise
2019-03-07 8:33 ` Leon Romanovsky
2019-02-28 19:41 ` Steve Wise
2019-02-28 19:56 ` Leon Romanovsky
2019-02-28 20:10 ` Steve Wise
2019-02-21 16:19 ` [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h Steve Wise
2019-02-21 18:56 ` Stephen Hemminger [this message]
2019-02-21 22:10 ` Leon Romanovsky
2019-02-21 23:11 ` Jason Gunthorpe
2019-02-23 9:28 ` Leon Romanovsky
2019-02-26 17:15 ` Steve Wise
2019-02-21 16:19 ` [PATCH v1 iproute2-next 3/4] rdma: add 'link add/delete' commands Steve Wise
2019-02-21 23:14 ` Jason Gunthorpe
2019-02-23 9:43 ` Leon Romanovsky
2019-02-26 17:24 ` Steve Wise
2019-02-27 21:18 ` Steve Wise
2019-02-27 21:18 ` Steve Wise
2019-02-21 16:19 ` [PATCH v1 iproute2-next 4/4] rdma: man page update for link add/delete Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221105631.7dfa5217@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.