From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Starkey Subject: Re: [PATCH v5 13/19] drm: writeback: Fix leak of writeback job Date: Thu, 21 Feb 2019 17:48:09 +0000 Message-ID: <20190221174810.3bhshikduornhs22@DESKTOP-E1NTVVP.localdomain> References: <20190221103212.28764-1-laurent.pinchart+renesas@ideasonboard.com> <20190221103212.28764-14-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04hn2057.outbound.protection.outlook.com [52.101.137.57]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8369289650 for ; Thu, 21 Feb 2019 17:48:12 +0000 (UTC) In-Reply-To: <20190221103212.28764-14-laurent.pinchart+renesas@ideasonboard.com> Content-Language: en-US Content-ID: <6F4798312659954C9C4FCB9131C2FF16@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Liviu Dudau , nd , "james qian wang (Arm Technology China)" , Kieran Bingham , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiBUaHUsIEZlYiAyMSwgMjAxOSBhdCAxMjozMjowNlBNICswMjAwLCBMYXVyZW50IFBp bmNoYXJ0IHdyb3RlOgo+IFdyaXRlYmFjayBqb2JzIGFyZSBhbGxvY2F0ZWQgd2hlbiB0aGUgV1JJ VEVCQUNLX0ZCX0lEIGlzIHNldCwgYW5kCj4gZGVsZXRlZCB3aGVuIHRoZSBqb2JzIGNvbXBsZXRl LiBUaGlzIHJlc3VsdHMgaW4gYm90aCBhIG1lbW9yeSBsZWFrIG9mCj4gdGhlIGpvYiBhbmQgYSBs ZWFrIG9mIHRoZSBmcmFtZWJ1ZmZlciBpZiB0aGUgYXRvbWljIGNvbW1pdCByZXR1cm5zCj4gYmVm b3JlIHRoZSBqb2IgaXMgcXVldWVkIGZvciBwcm9jZXNzaW5nLCBmb3IgaW5zdGFuY2UgaWYgdGhl IGF0b21pYwo+IGNoZWNrIGZhaWxzIG9yIGlmIHRoZSBjb21taXQgcnVucyBpbiB0ZXN0LW9ubHkg bW9kZS4KPiAKPiBGaXggdGhpcyBieSBpbXBsZW1lbnRpbmcgdGhlIGRybV93cml0ZWJhY2tfY2xl YW51cF9qb2IoKSBmdW5jdGlvbiBhbmQKPiBjYWxsaW5nIGl0IGZyb20gX19kcm1fYXRvbWljX2hl bHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZSgpLiBBcwo+IHdyaXRlYmFjayBqb2JzIGFyZSBy ZW1vdmVkIGZyb20gdGhlIHN0YXRlIHdoZW4gdGhleSdyZSBxdWV1ZWQgZm9yCj4gcHJvY2Vzc2lu ZywgYW55IGpvYiBsZWZ0IGluIHRoZSBzdGF0ZSB3aGVuIHRoZSBzdGF0ZSBnZXRzIGRlc3Ryb3ll ZAo+IG5lZWRzIHRvIGJlIGNsZWFuZWQgdXAuCj4gCj4gVGhlIGV4aXN0aW5nIGRlY2xhcmF0aW9u IG9mIHRoZSBkcm1fd3JpdGViYWNrX2NsZWFudXBfam9iKCkgZnVuY3Rpb24KPiB3aXRob3V0IGFu IGltcGxlbWVudGF0aW9uIGhpbnRzIHRoYXQgdGhpcyBwcm9ibGVtIHdhcyBjb25zaWRlcmVkLCBi dXQKPiBuZXZlciBhZGRyZXNzZWQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFy dCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+CgpUaGFua3MgZm9y IGZpeGluZyB0aGlzLCBpdCBsb29rcyBsaWtlIGl0IGdvdCBkcm9wcGVkIGluIG9uZSBvZiB0aGUK cmV3b3JrL3JlYmFzZXMuCgpSZXZpZXdlZC1ieTogQnJpYW4gU3RhcmtleSA8YnJpYW4uc3Rhcmtl eUBhcm0uY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfc3RhdGVfaGVs cGVyLmMgfCAgNCArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMgICAgICAg ICAgIHwgMTMgKysrKysrKysrKy0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMo KyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX3N0YXRlX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfc3RhdGVf aGVscGVyLmMKPiBpbmRleCA0OTg1Mzg0ZTUxZjYuLjU5ZmZiNmI5Yzc0NSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19zdGF0ZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jCj4gQEAgLTMwLDYgKzMwLDcgQEAK PiAgI2luY2x1ZGUgPGRybS9kcm1fY29ubmVjdG9yLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2F0 b21pYy5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9kZXZpY2UuaD4KPiArI2luY2x1ZGUgPGRybS9k cm1fd3JpdGViYWNrLmg+Cj4gIAo+ICAjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+ICAjaW5jbHVk ZSA8bGludXgvZG1hLWZlbmNlLmg+Cj4gQEAgLTQxMiw2ICs0MTMsOSBAQCBfX2RybV9hdG9taWNf aGVscGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRl ICpzdGF0ZSkKPiAgCj4gIAlpZiAoc3RhdGUtPmNvbW1pdCkKPiAgCQlkcm1fY3J0Y19jb21taXRf cHV0KHN0YXRlLT5jb21taXQpOwo+ICsKPiArCWlmIChzdGF0ZS0+d3JpdGViYWNrX2pvYikKPiAr CQlkcm1fd3JpdGViYWNrX2NsZWFudXBfam9iKHN0YXRlLT53cml0ZWJhY2tfam9iKTsKPiAgfQo+ ICBFWFBPUlRfU1lNQk9MKF9fZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3Rh dGUpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV93cml0ZWJhY2suYyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMKPiBpbmRleCAzMzhiOTkzZDdjOWYuLmFm YjFhZTZlMGVjYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRlYmFjay5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV93cml0ZWJhY2suYwo+IEBAIC0yNzMsNiArMjcz LDE0IEBAIHZvaWQgZHJtX3dyaXRlYmFja19xdWV1ZV9qb2Ioc3RydWN0IGRybV93cml0ZWJhY2tf Y29ubmVjdG9yICp3Yl9jb25uZWN0b3IsCj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fd3JpdGVi YWNrX3F1ZXVlX2pvYik7Cj4gIAo+ICt2b2lkIGRybV93cml0ZWJhY2tfY2xlYW51cF9qb2Ioc3Ry dWN0IGRybV93cml0ZWJhY2tfam9iICpqb2IpCj4gK3sKPiArCWlmIChqb2ItPmZiKQo+ICsJCWRy bV9mcmFtZWJ1ZmZlcl9wdXQoam9iLT5mYik7Cj4gKwo+ICsJa2ZyZWUoam9iKTsKPiArfQo+ICsK PiAgLyoKPiAgICogQGNsZWFudXBfd29yazogZGVmZXJyZWQgY2xlYW51cCBvZiBhIHdyaXRlYmFj ayBqb2IKPiAgICoKPiBAQCAtMjg1LDEwICsyOTMsOSBAQCBzdGF0aWMgdm9pZCBjbGVhbnVwX3dv cmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJc3RydWN0IGRybV93cml0ZWJhY2tfam9i ICpqb2IgPSBjb250YWluZXJfb2Yod29yaywKPiAgCQkJCQkJICAgICBzdHJ1Y3QgZHJtX3dyaXRl YmFja19qb2IsCj4gIAkJCQkJCSAgICAgY2xlYW51cF93b3JrKTsKPiAtCWRybV9mcmFtZWJ1ZmZl cl9wdXQoam9iLT5mYik7Cj4gLQlrZnJlZShqb2IpOwo+IC19Cj4gIAo+ICsJZHJtX3dyaXRlYmFj a19jbGVhbnVwX2pvYihqb2IpOwo+ICt9Cj4gIAo+ICAvKioKPiAgICogZHJtX3dyaXRlYmFja19z aWduYWxfY29tcGxldGlvbiAtIFNpZ25hbCB0aGUgY29tcGxldGlvbiBvZiBhIHdyaXRlYmFjayBq b2IKPiAtLSAKPiBSZWdhcmRzLAo+IAo+IExhdXJlbnQgUGluY2hhcnQKPiAKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs