From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gwsk0-00054u-G5 for mharc-grub-devel@gnu.org; Thu, 21 Feb 2019 13:06:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwsjz-00054o-6x for grub-devel@gnu.org; Thu, 21 Feb 2019 13:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwsjp-0007By-Hw for grub-devel@gnu.org; Thu, 21 Feb 2019 13:06:31 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:43592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwsjk-00079F-BN for grub-devel@gnu.org; Thu, 21 Feb 2019 13:06:22 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1LHudvt171861; Thu, 21 Feb 2019 18:06:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=lKqP9a/TsqspOBmmVfacs1k4j5rUKx0qjq7JGn3pVGo=; b=hwHixECuckxfQo6JvPjJtqC/699XvEdDA7uB3IOj+qkQiYHbI0QXhELmK3v04UcDvMBX 9lDDEKmBEsK4d8Dq8aTm3PgISznTAkj2otOznQxAWQdj33rmQ9zzFQQGMhZI3EXWEYlE MQxbuq+eyzlgXRL6ZEpZAr4zfxtBLwGur5JaA//330FbvB2CxmEUDQ6HgkRMi1zb6z43 rmBB3wg3xBeZ2u8bXvpEfXCtWHV3CPDOwslIVhf1rTMzJaYA4gldnHSlWQJ8cmNwSVkt 0u9O5XFYCaToqN4Q3g9HoFfhKk4g2A6ccgszTRVZs4e9EjHKFwg2nUqJdEc4vax0DWcO yw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2qp9xu9s8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 18:06:12 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1LI6BOo004269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 18:06:11 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1LI6BaM031862; Thu, 21 Feb 2019 18:06:11 GMT Received: from tomti.i.net-space.pl (/10.175.187.233) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 21 Feb 2019 10:06:10 -0800 Date: Thu, 21 Feb 2019 19:06:05 +0100 From: Daniel Kiper To: Andre Przywara Cc: Daniel Kiper , Vladimir Serbinenko , Andrei Borzenkov , Mark Rutland , grub-devel@gnu.org Subject: Re: [PATCH v2 2/9] net: dhcp: replace parse_dhcp_vendor() with find_dhcp_option() Message-ID: <20190221180605.esaebv26u7fw3a6b@tomti.i.net-space.pl> References: <20190212174700.184741-1-andre.przywara@arm.com> <20190212174700.184741-3-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212174700.184741-3-andre.przywara@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9174 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=923 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902210127 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 18:06:36 -0000 On Tue, Feb 12, 2019 at 05:46:53PM +0000, Andre Przywara wrote: > From: Andrei Borzenkov > > For proper DHCP support we will need to parse DHCP options from a packet > more often and at various places. > > Refactor the option parsing into a new function, which will scan a > packet to find *a particular* option field. > Use that new function in places where we were dealing with DHCP options > before. > > Signed-off-by: Andre Przywara This patch also adds support for overload. Could you split it into two? Daniel