From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61229C43381 for ; Fri, 22 Feb 2019 01:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3221720685 for ; Fri, 22 Feb 2019 01:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbfBVBjU (ORCPT ); Thu, 21 Feb 2019 20:39:20 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:42418 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbfBVBjT (ORCPT ); Thu, 21 Feb 2019 20:39:19 -0500 Received: by mail-qt1-f196.google.com with SMTP id b8so809132qtr.9 for ; Thu, 21 Feb 2019 17:39:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=npvSsge+bGcOaLfo50GXR6ghdOY7fKoWqsSBdgGy94U=; b=l+mr33fitEbpYJCQKW9mfLxVQzeJIheMetk2s6zrrkj8yUvkmhHmjX9lq30A4c13lC N2MXfE1GvaIX4Qfaj6nyF5nQGdhAtS0ptd+ufo6XX4NU6eLBBuYpHMKejQer6cfd4NVe E+NO83H982NzgJ1bbz8po8IE4UtmRM49dbJLrMy3UtdA0fXnJeV2O3gMYuCRdZckZaaM xBwKEyq3ngBqzwqHgE9ayF1NR6R2K60/AsRwEmPCvAjNDvQTePMJPniSI/mplJUN8Hzk E+uFsZj9jtD7dudrkt4qqdG9AFfXd00gnEzrrLHCvjd0qaO8CmKQSQ425qQ6g7NMIVs2 SKIw== X-Gm-Message-State: AHQUAuYKuAv7tt/6WndPzTkumBwfsi3fbNZSh2WOmmB9/OWkbtVPDDHT zQg5fwc1vvxU+0FZaUtGMJ6X1x7qitFLiQ== X-Google-Smtp-Source: AHgI3IbGY0WhnIssyGwB5kQYjeeZZPl/fhGw2FcJ70KJ7s+3owAuMFbKBGmFDk+KtiL3WosFR4Xfrg== X-Received: by 2002:a0c:d24a:: with SMTP id o10mr1268669qvh.170.1550799558578; Thu, 21 Feb 2019 17:39:18 -0800 (PST) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id k66sm57006qkc.25.2019.02.21.17.39.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Feb 2019 17:39:17 -0800 (PST) Date: Thu, 21 Feb 2019 20:39:15 -0500 From: "Michael S. Tsirkin" To: Siwei Liu Cc: Jiri Pirko , Stephen Hemminger , Sridhar Samudrala , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jakub Kicinski , Jason Wang , liran.alon@oracle.com, si-wei liu Subject: Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Message-ID: <20190221203808-mutt-send-email-mst@kernel.org> References: <1523386790-12396-1-git-send-email-sridhar.samudrala@intel.com> <1523386790-12396-5-git-send-email-sridhar.samudrala@intel.com> <20180410142608.50f15b45@xeon-e3> <20180411075334.GK2028@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu wrote: > Sorry for replying to this ancient thread. There was some remaining > issue that I don't think the initial net_failover patch got addressed > cleanly, see: > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 > > The renaming of 'eth0' to 'ens4' fails because the udev userspace was > not specifically writtten for such kernel automatic enslavement. > Specifically, if it is a bond or team, the slave would typically get > renamed *before* virtual device gets created, that's what udev can > control (without getting netdev opened early by the other part of > kernel) and other userspace components for e.g. initramfs, > init-scripts can coordinate well in between. The in-kernel > auto-enslavement of net_failover breaks this userspace convention, > which don't provides a solution if user care about consistent naming > on the slave netdevs specifically. > > Previously this issue had been specifically called out when IFF_HIDDEN > and the 1-netdev was proposed, but no one gives out a solution to this > problem ever since. Please share your mind how to proceed and solve > this userspace issue if netdev does not welcome a 1-netdev model. Above says: there's no motivation in the systemd/udevd community at this point to refactor the rename logic and make it work well with 3-netdev. What would the fix be? Skip slave devices? -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5491-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id B65D89860E5 for ; Fri, 22 Feb 2019 01:39:19 +0000 (UTC) Date: Thu, 21 Feb 2019 20:39:15 -0500 From: "Michael S. Tsirkin" Message-ID: <20190221203808-mutt-send-email-mst@kernel.org> References: <1523386790-12396-1-git-send-email-sridhar.samudrala@intel.com> <1523386790-12396-5-git-send-email-sridhar.samudrala@intel.com> <20180410142608.50f15b45@xeon-e3> <20180411075334.GK2028@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) To: Siwei Liu Cc: Jiri Pirko , Stephen Hemminger , Sridhar Samudrala , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jakub Kicinski , Jason Wang , liran.alon@oracle.com, si-wei liu List-ID: On Thu, Feb 21, 2019 at 05:14:44PM -0800, Siwei Liu wrote: > Sorry for replying to this ancient thread. There was some remaining > issue that I don't think the initial net_failover patch got addressed > cleanly, see: > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 > > The renaming of 'eth0' to 'ens4' fails because the udev userspace was > not specifically writtten for such kernel automatic enslavement. > Specifically, if it is a bond or team, the slave would typically get > renamed *before* virtual device gets created, that's what udev can > control (without getting netdev opened early by the other part of > kernel) and other userspace components for e.g. initramfs, > init-scripts can coordinate well in between. The in-kernel > auto-enslavement of net_failover breaks this userspace convention, > which don't provides a solution if user care about consistent naming > on the slave netdevs specifically. > > Previously this issue had been specifically called out when IFF_HIDDEN > and the 1-netdev was proposed, but no one gives out a solution to this > problem ever since. Please share your mind how to proceed and solve > this userspace issue if netdev does not welcome a 1-netdev model. Above says: there's no motivation in the systemd/udevd community at this point to refactor the rename logic and make it work well with 3-netdev. What would the fix be? Skip slave devices? -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org