From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1gwwhU-0005mi-8z for mharc-grub-devel@gnu.org; Thu, 21 Feb 2019 17:20:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwwhS-0005ma-8O for grub-devel@gnu.org; Thu, 21 Feb 2019 17:20:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwwhR-0008PW-2h for grub-devel@gnu.org; Thu, 21 Feb 2019 17:20:14 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:59664) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwwhQ-0008Mk-He for grub-devel@gnu.org; Thu, 21 Feb 2019 17:20:12 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1LMIVlf017759; Thu, 21 Feb 2019 22:20:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=mb9X1Q6oOjhs9//P0t7fhlbE3hqrRboc3FQerQ5xKmc=; b=xMbUe/jRAvvDu7eazmwTFMiRVJ5KJuEmrF2XPK6hRvKKB5h5oajzSWgfzpu7XIE9b4PH azj/CYNg0ztm66it65jFf0pfalfIJSXok/kjnTyhHyjO3fspr41fq3L7+lbLIEELYQbv l9rnZtgzb9mnc4YS8ivZkfL1RlafeJEpqYXPnor7ankzEUO5KxkeEIdjV4TSHySpLq5F 5gzqFBOYY+TUTipUiW52Qt8ENvyUrJP7T/VBwRcaAi/GQK7lmTAIXTYYJf9aJ/r6cqdM 97ZGduHIXuoEFqhh86mmBx6tBcSceD36/DiwdxDSSraGIWEpkhWuTsTMEtqc0fdJcqkL Ug== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2qp81ekbg4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 22:20:05 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1LMK4rk015179 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Feb 2019 22:20:04 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1LMK3BB010581; Thu, 21 Feb 2019 22:20:04 GMT Received: from tomti.i.net-space.pl (/10.175.187.233) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 21 Feb 2019 14:20:03 -0800 Date: Thu, 21 Feb 2019 23:19:59 +0100 From: Daniel Kiper To: Andre Przywara Cc: Daniel Kiper , Vladimir Serbinenko , Andrei Borzenkov , Mark Rutland , grub-devel@gnu.org Subject: Re: [PATCH v2 8/9] net: dhcp: actually send out DHCPv4 DISCOVER and REQUEST messages Message-ID: <20190221221959.x56uwetfqrzrlpsq@tomti.i.net-space.pl> References: <20190212174700.184741-1-andre.przywara@arm.com> <20190212174700.184741-9-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190212174700.184741-9-andre.przywara@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9174 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902210152 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.79 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 22:20:15 -0000 On Tue, Feb 12, 2019 at 05:46:59PM +0000, Andre Przywara wrote: > From: Andrei Borzenkov > > Even though we were parsing some DHCP options sent by the server, so far > we are only using the BOOTP 2-way handshake, even when talking to a DHCP > server. > > Change this by actually sending out DHCP DISCOVER packets instead of the > generic (mostly empty) BOOTP BOOTREQUEST packets. > > A pure BOOTP server would ignore the extra DHCP options in the DISCOVER > packet and would just reply with a BOOTREPLY packet, which we also > handle in the code. > > Signed-off-by: Andre Przywara Reviewed-by: Daniel Kiper Daniel